all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 33005@debbugs.gnu.org
Subject: bug#33005: 27.0.50; Data loss with Gnus registry
Date: Tue, 26 Nov 2019 10:45:03 -0800	[thread overview]
Message-ID: <87pnhev5n4.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87k17m1tv0.fsf@web.de> (Michael Heerdegen's message of "Tue, 26 Nov 2019 17:32:19 +0100")


On 11/26/19 17:32 PM, Michael Heerdegen wrote:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Well damn. And we're coming up on Emacs 27.1, too... I've never seen
>> this before -- would you mind sending all your registry-related config
>> (off-list, if necessary), and anything else you might think is relevant,
>> and I'll try to reproduce?
>
> Ok, I debugged it.  FWIW I recently learned that "I'll try to reproduce"
> has a meaning that I didn't expect: you need to say "I'll try to
> reproduce it" or else Stallman might show up and laugh at you (it
> happened to me).

Who knew such dangers lurked on this list?!

> Ok: I have only (gnus-registry-initialize) in my init file.  And this is
> already broken:
>
> "gnus-registry.el" initializes gnus-registry-db like this:
>
>   (defvar gnus-registry-db (gnus-registry-make-db)
>     "The article registry by Message ID.  See `registry-db'.")
>
> and in `gnus-registry-load' the
>
>   (null (eieio-object-p gnus-registry-db))
>
> always fails so unless you call `gnus-registry-load' with the force arg
> you always start with an empty db.

Oh I see, when the file is loaded the variable is already initialized to
an (unloaded) registry object, so it never actually loads/reads its
persistence file.

Except that it certainly seems to! I've never seen this cause a problem,
and no one calls `gnus-registry-load' with the FORCE argument, so if
this was an issue, it seems like it would fail for everyone
immediately...

In fact, I don't know the defvar is initialized to anything at all.
For eieio-persistent objects, you're not supposed to make-instance
yourself, you're supposed to use `eieio-persistent-read' (which is what
loading is supposed to do).

Dunno why it works, though...





  reply	other threads:[~2019-11-26 18:45 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10 13:24 bug#33005: 27.0.50; Data loss with Gnus registry Michael Heerdegen
2018-10-10 14:56 ` Eric Abrahamsen
2018-10-10 15:17   ` Michael Heerdegen
2018-10-10 16:08     ` Eric Abrahamsen
2018-10-10 20:23       ` Michael Heerdegen
2018-10-10 21:24       ` Michael Heerdegen
2018-10-10 23:05         ` Eric Abrahamsen
2018-10-11 12:44           ` Michael Heerdegen
2018-10-11 13:10             ` Michael Heerdegen
2018-10-11 18:12               ` Eric Abrahamsen
2018-10-11 20:28                 ` Michael Heerdegen
2018-10-11 22:09                   ` Eric Abrahamsen
2018-10-11 22:20                     ` Michael Heerdegen
2018-10-11 22:26                       ` Eric Abrahamsen
2018-10-12 14:22                     ` Michael Heerdegen
2018-10-12 16:57                       ` Eric Abrahamsen
2018-10-11 18:53           ` Eli Zaretskii
2018-10-11 18:57             ` Eric Abrahamsen
2018-10-11 20:08             ` Michael Heerdegen
2018-10-12  4:24               ` Eli Zaretskii
2018-10-12 11:04                 ` Michael Heerdegen
2018-10-12 12:51                   ` Eli Zaretskii
2018-10-12 14:46           ` Michael Heerdegen
2018-10-12 16:58             ` Eric Abrahamsen
2019-09-24  1:35             ` Michael Heerdegen
2019-09-24  3:34               ` Eric Abrahamsen
2019-10-01 23:37                 ` Eric Abrahamsen
2019-10-14  9:53                   ` Michael Heerdegen
2019-10-14 17:51                     ` Eric Abrahamsen
2019-10-15 14:28                       ` Michael Heerdegen
2019-10-15 20:11                         ` Eric Abrahamsen
2019-10-16  9:03                           ` Michael Heerdegen
2019-10-16 15:46                             ` Eric Abrahamsen
2019-10-17  8:21                               ` Michael Heerdegen
2019-10-17 15:53                                 ` Eric Abrahamsen
2019-10-18  9:18                                   ` Michael Heerdegen
2019-10-18 14:44                                     ` Michael Heerdegen
2019-10-19  2:05                                       ` Phil Sainty
2019-10-19 14:31                                         ` Michael Heerdegen
2019-10-19 22:12                                           ` Phil Sainty
2019-10-26  8:02                                             ` Michael Heerdegen
2019-10-26 15:35                                               ` Eric Abrahamsen
2019-11-18  9:17                                                 ` Phil Sainty
2019-10-18 14:46                                     ` Michael Heerdegen
2019-10-18 19:07                                       ` Eric Abrahamsen
2019-10-18 19:09                                       ` Eric Abrahamsen
2019-10-18 19:23                                         ` Michael Heerdegen
2019-10-18 19:24                                           ` Eric Abrahamsen
2019-10-19 14:25                                             ` Michael Heerdegen
2019-10-19 18:06                                               ` Eric Abrahamsen
2019-10-18 19:06                                     ` Eric Abrahamsen
2019-10-16  9:30                           ` Michael Heerdegen
2019-10-16 15:49                             ` Eric Abrahamsen
2019-10-17  8:32                               ` Michael Heerdegen
2019-10-17 10:23                                 ` Michael Heerdegen
2019-10-17 15:54                                   ` Eric Abrahamsen
2019-10-18  3:08                             ` Richard Stallman
2019-10-18  9:50                               ` Michael Heerdegen
2019-11-26  0:17 ` Michael Heerdegen
2019-11-26  0:51   ` Eric Abrahamsen
2019-11-26 16:32     ` Michael Heerdegen
2019-11-26 18:45       ` Eric Abrahamsen [this message]
2019-11-26 20:08         ` Michael Heerdegen
2019-11-26 20:41           ` Eric Abrahamsen
2019-11-26 20:45             ` Michael Heerdegen
2019-11-26 20:48               ` Eric Abrahamsen
2019-11-26 20:54                 ` Michael Heerdegen
2019-11-28  8:43                   ` Eric Abrahamsen
2019-11-28 16:25                     ` Michael Heerdegen
2019-11-28 23:55                       ` Eric Abrahamsen
2019-11-29 12:36                         ` Michael Heerdegen
2019-12-03  9:19                           ` Eric Abrahamsen
2019-12-04 16:10                             ` Michael Heerdegen
2019-12-04 17:26                               ` Eric Abrahamsen
2019-12-04 20:41                                 ` Michael Heerdegen
2019-12-04 20:53                                   ` Eric Abrahamsen
2019-12-04 21:02                                     ` Michael Heerdegen
2019-12-04 21:16                                       ` Eric Abrahamsen
2019-12-04 21:51                                         ` Michael Heerdegen
2019-12-05  0:51                                           ` Eric Abrahamsen
2019-12-08 15:48                                             ` Michael Heerdegen
2019-12-08 20:52                                               ` Eric Abrahamsen
2019-12-09 19:38                                                 ` Michael Heerdegen
2019-12-09 22:29                                                   ` Eric Abrahamsen
2019-12-09 23:07                                                     ` Michael Heerdegen
2019-12-10  0:24                                                       ` Eric Abrahamsen
2019-12-10  2:30                                                         ` Michael Heerdegen
2019-12-10 23:31                                                           ` Eric Abrahamsen
2019-12-15 17:07                                                             ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnhev5n4.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=33005@debbugs.gnu.org \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.