From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Yuri D'Elia <wavexx@thregr.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master 5ee43ba0df causing display hangs?
Date: Sat, 07 Dec 2019 19:56:10 +0100
Message-ID: <87pnh0ezhx.fsf@wavexx.thregr.org>
References: <87k178gu5g.fsf@wavexx.thregr.org> <83sglwdoc0.fsf@gnu.org>
 <83pnh0dmvl.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="69952"; mail-complaints-to="usenet@blaine.gmane.org"
User-Agent: mu4e 1.3.5; emacs 27.0.50
Cc: emacs-devel@gnu.org
To: Eli Zaretskii <eliz@gnu.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 07 19:57:01 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1idfGG-000I3i-Td
	for ged-emacs-devel@m.gmane.org; Sat, 07 Dec 2019 19:57:01 +0100
Original-Received: from localhost ([::1]:52474 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1idfGF-0007ls-8E
	for ged-emacs-devel@m.gmane.org; Sat, 07 Dec 2019 13:56:59 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34140)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <wavexx@thregr.org>) id 1idfFZ-0007lh-Ty
 for emacs-devel@gnu.org; Sat, 07 Dec 2019 13:56:18 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <wavexx@thregr.org>) id 1idfFY-0004c4-Oc
 for emacs-devel@gnu.org; Sat, 07 Dec 2019 13:56:17 -0500
Original-Received: from erc.thregr.org ([2001:41c9:1:41f::63]:44588)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <wavexx@thregr.org>)
 id 1idfFV-0004TA-RM; Sat, 07 Dec 2019 13:56:14 -0500
Original-Received: from [2a02:27e8:ffff:10::3] (helo=localhost)
 by erc.thregr.org with esmtpsa
 (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
 id 1idfFU-000AI1-AK (envelope-from <wavexx@thregr.org>);
 Sat, 07 Dec 2019 19:56:12 +0100
In-reply-to: <83pnh0dmvl.fsf@gnu.org>
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
 recognized.
X-Received-From: 2001:41c9:1:41f::63
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:243220
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/243220>

On Sat, Dec 07 2019, Eli Zaretskii wrote:
> A stab in the dark: does the below fix the problem?
>
> diff --git a/src/xfaces.c b/src/xfaces.c
> index 6db4dcd..a2fbed8 100644
> --- a/src/xfaces.c
> +++ b/src/xfaces.c
> @@ -2168,7 +2168,7 @@ face_inherited_attr (struct window *w, struct frame *f,
>        if (CONSP (parent_face))
>       {
>         Lisp_Object tail;
> -	  for (tail = parent_face; !NILP (tail); tail = XCDR (tail))
> +	  for (tail = parent_face; CONSP (tail); tail = XCDR (tail))
>           {
>             ok = get_lface_attributes (w, f, XCAR (tail), inherited_attrs,
>                                        false, named_merge_points);

Doesn't look like.