From: Alexis <flexibeast@gmail.com>
To: Robert Pluim <rpluim@gmail.com>
Cc: 38602@debbugs.gnu.org
Subject: bug#38602: 26.3; gnutls-negotiate fails to handle :verify-error being set to t
Date: Thu, 26 Dec 2019 15:19:45 +1100 [thread overview]
Message-ID: <87pngbpvku.fsf@ada> (raw)
In-Reply-To: <m24ky3ukpk.fsf@gmail.com>
Robert Pluim <rpluim@gmail.com> writes:
> How about this? Producing a list (:hostname t) is not what you
> want,
> since that removes the 'check everything' feature of specifying
> just
> 't'.
>
> diff --git a/lisp/net/gnutls.el b/lisp/net/gnutls.el
> index 9b13adaefe..14368bc298 100644
> --- a/lisp/net/gnutls.el
> +++ b/lisp/net/gnutls.el
> @@ -345,8 +345,11 @@ gnutls-boot-parameters
> (t nil))))
> (min-prime-bits (or min-prime-bits
> gnutls-min-prime-bits)))
>
> - (when verify-hostname-error
> - (push :hostname verify-error))
> + ;; Only add :hostname if `verify-error' is not t, since t
> + ;; means "include :hostname" Bug#38602.
> + (and verify-hostname-error
> + (not (eq verify-error t))
> + (push :hostname verify-error))
>
> `(:priority ,priority-string
> :hostname ,hostname
Thank you for your prompt response - sorry to have taken so long
to get back to you.
Unfortunately, this diff didn't work for me - it results in the
error:
STARTTLS negotation failed: GnuTLS error: #<process jabber>,
nil
Alexis.
next prev parent reply other threads:[~2019-12-26 4:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-14 2:25 bug#38602: 26.3; gnutls-negotiate fails to handle :verify-error being set to t Alexis
2019-12-14 12:59 ` Robert Pluim
2019-12-26 4:19 ` Alexis [this message]
2019-12-29 21:01 ` Robert Pluim
2020-08-16 6:59 ` Alexis
2020-10-02 2:51 ` Lars Ingebrigtsen
2020-12-08 18:12 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pngbpvku.fsf@ada \
--to=flexibeast@gmail.com \
--cc=38602@debbugs.gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.