From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#39680: 27.0.60; electric-pair-mode broken by undo Date: Wed, 19 Feb 2020 19:34:37 +0100 Message-ID: <87pneaifya.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="29041"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier To: 39680@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 19 19:35:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j4UBk-0007Pt-Ew for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Feb 2020 19:35:12 +0100 Original-Received: from localhost ([::1]:58112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4UBj-00057E-C9 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Feb 2020 13:35:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60070) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4UBb-00056z-BC for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 13:35:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4UBa-0001gK-7j for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 13:35:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37392) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j4UBa-0001fc-4J for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 13:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j4UBa-0000Cz-1C for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 13:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Feb 2020 18:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39680 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.1582137291780 (code B ref -1); Wed, 19 Feb 2020 18:35:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Feb 2020 18:34:51 +0000 Original-Received: from localhost ([127.0.0.1]:43365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4UBP-0000CU-5P for submit@debbugs.gnu.org; Wed, 19 Feb 2020 13:34:51 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:49962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4UBM-0000CN-Ax for submit@debbugs.gnu.org; Wed, 19 Feb 2020 13:34:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59931) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4UBJ-00056c-UM for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 13:34:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4UBH-0001Dg-PX for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 13:34:45 -0500 Original-Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:36093) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j4UBH-0001BJ-Hs for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 13:34:43 -0500 Original-Received: by mail-wm1-x32f.google.com with SMTP id p17so1794000wma.1 for ; Wed, 19 Feb 2020 10:34:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lQ78N+KPxSay2au8vprKyJECNlBQFYy6DWqb3PO6r1w=; b=DJezC84B6rXGNEbLELUlWWDqoIkxELxlunVvcFjv5+HL/XQYdYi/hvFctylwp/NLAW WqBAwnrq6gnfeQIJ1880iK0v+S8/cNq3gzXjLGEK52jmP92aNVXDdN40FHyujoFUtJMU tA899iEr9Ap7ucsy1ukmetQbSHizeWR0egsMWrHs1qQ6S9+zJI23KkYFftAZ+PCNLt/h BKqeTqv4+CL1EVmT/o7TRRXIK8UoiDHtCS18CU0bxC2sGllXBhT55WWxWtBlmvZU6Ech CyeyEwTNo6ASH/Su6I0sw+4rR1O6pCygeBG1UxbtA8atuH/j2ZTFmlEE5BXTBxPE5VMr TgHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lQ78N+KPxSay2au8vprKyJECNlBQFYy6DWqb3PO6r1w=; b=iVJUUWb2Di7+BpTG5Cvi36n7rWPSr67TBSuqCRR9OErUXtpOU3mFKke5lsXVeUdl/Y rxSA5vhRCMCDS3ITDGzdx+1BUgY9ec1FGHtDexvN/DRtx1/lZPA3/DSRpFhVBZgrV6Pw QYdtIoLHwK1JcdbU/6WsymrNfqcKdQUSiw31NUiQabnXGRwGpK1BlrvuSqIEr7lgXDZQ iSiVRIhXqKL5Y8HOiwsImQWc7iFAJg9pjmoJBHTsW5Yphl+fPEVyaUey+BIMKoXmlEcP F+7oVrW5RO6++pCZ3n7Rim1k+csjBH5pteh5ehRBpXfFFedOHQ007t2devtQcwpaERjJ +SRQ== X-Gm-Message-State: APjAAAXD8IuhAFvG97w+AV4Qrw6mh5hylqhOSfu/5bOiZbLAbXrfnVEX LEcurRfLulRYIp4FUjldEs1C9mGF X-Google-Smtp-Source: APXvYqyuqvqD5JLELJTAj/pMYeRfTDIOd9a2lXZNg3EETD2/CKT/yd+0kzT7N86D9Xihy0tHIWZzNQ== X-Received: by 2002:a05:600c:24d2:: with SMTP id 18mr11496821wmu.149.1582137278755; Wed, 19 Feb 2020 10:34:38 -0800 (PST) Original-Received: from my-little-tumbleweed (200.143.13.109.rev.sfr.net. [109.13.143.200]) by smtp.gmail.com with ESMTPSA id w8sm947496wmm.0.2020.02.19.10.34.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2020 10:34:37 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176256 Archived-At: Hello, Commit e66d5a1c45 (2019-02-19T00:00:44Z!monnier@iro.umontreal.ca) might have introduced a bug. From emacs -Q: 1. C-x b foo RET 2. M-x electric-pair-mode RET 3. ( - A closing parenthesis has been inserted. 4. C-b C-f - This is to break undo grouping. 5. a 6. C-_ 7. ( In Emacs 26.3, buffer foo contains "(())" and point is after the innermost opening bracket. In Emacs 27, buffer foo contains "()" and point is after the closing bracket. The *Messages* buffer shows: > cancel-change-group: Undoing to some unrelated state NB: this can be reproduced with other electric-pair characters, e.g. ". I found the bug in a Python buffer trying to write a tuple of strings: I opened a parenthesis, forgot to add quotes, wrote a string, hit undo, tried to insert a single quote=E2=80=A6 and got moved past the end parenthe= sis instead. I tried to write a non-regression test; unfortunately what I came up with does not catch this bug reliably: (ert-deftest electric-pair-undo-unrelated-state () (with-temp-buffer (buffer-enable-undo) (electric-pair-mode) (let ((last-command-event ?\()) (self-insert-command 1)) (undo-boundary) (insert "hi there") (undo) (let ((last-command-event ?\()) (self-insert-command 1)))) C-x C-e'ing the (with-temp-buffer =E2=80=A6) form only triggers the error o= nce every two evaluations, for some reason. Thank you for your time. In GNU Emacs 28.0.50 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.24.13, c= airo version 1.16.0) of 2020-02-19 built on my-little-tumbleweed Repository revision: e1e1bd8f85c53fea9f61b6ec99b461ddd93461b9 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12007000 System Description: openSUSE Tumbleweed Configured using: 'configure --with-xwidgets --with-cairo'