From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error Date: Sat, 14 Mar 2020 12:41:34 +0100 Message-ID: <87pndf17v5.fsf@gnus.org> References: <20200308090630.41238-1-stepnem@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="107804"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39980@debbugs.gnu.org To: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 14 12:44:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jD5DF-000RwD-O7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Mar 2020 12:44:17 +0100 Original-Received: from localhost ([::1]:44066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jD5DE-0000Oj-O6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Mar 2020 07:44:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55322) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jD5B5-0007EQ-66 for bug-gnu-emacs@gnu.org; Sat, 14 Mar 2020 07:42:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jD5B4-0008OZ-60 for bug-gnu-emacs@gnu.org; Sat, 14 Mar 2020 07:42:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54693) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jD5B4-0008NQ-1X for bug-gnu-emacs@gnu.org; Sat, 14 Mar 2020 07:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jD5B4-0008J1-0e for bug-gnu-emacs@gnu.org; Sat, 14 Mar 2020 07:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Mar 2020 11:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39980 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39980-submit@debbugs.gnu.org id=B39980.158418610431904 (code B ref 39980); Sat, 14 Mar 2020 11:42:01 +0000 Original-Received: (at 39980) by debbugs.gnu.org; 14 Mar 2020 11:41:44 +0000 Original-Received: from localhost ([127.0.0.1]:60666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jD5Am-0008IW-8W for submit@debbugs.gnu.org; Sat, 14 Mar 2020 07:41:44 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:56224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jD5Al-0008IJ-38 for 39980@debbugs.gnu.org; Sat, 14 Mar 2020 07:41:43 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jD5Ad-0001Lt-8F; Sat, 14 Mar 2020 12:41:37 +0100 In-Reply-To: <20200308090630.41238-1-stepnem@gmail.com> ("=?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?="'s message of "Sun, 8 Mar 2020 10:06:30 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177339 Archived-At: =C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec writes: > 'gnus-shorten-url' (used by 'gnus-summary-browse-url') ignored > fragment identifiers and didn't check substring bounds, in some cases > leading to runtime errors, e.g.: > > (gnus-shorten-url "https://some.url.with/path/and#also_a_long_target" 4= 0) > ;; =3D> Lisp error: (args-out-of-range "/path/and" -18 nil) > > This commit makes it account for #fragments and fixes faulty string > computation, reusing existing helper function. Looks like a good fix to me, but is there a reason this is a defsubst instead of a defun? +(defsubst string-truncate-left (string length) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no