From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Emanuel Berg via Users list for the GNU Emacs text editor Newsgroups: gmane.emacs.help Subject: Re: How to get the actual face attribute? Date: Mon, 22 Jun 2020 23:27:17 +0200 Message-ID: <87pn9qbxl6.fsf@ebih.ebihd> References: <60C41409-88B0-4F21-AC6D-2F18394A7C46@gmail.com> <41A32155-634A-4D5A-A878-2F92E6761917@gmail.com> Reply-To: Emanuel Berg Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="42570"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:jXw6tB5J8SR58fUs7ozTEwnDeGA= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 22 23:27:55 2020 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jnTys-000Auu-0Y for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 22 Jun 2020 23:27:54 +0200 Original-Received: from localhost ([::1]:44608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnTyr-0007gW-0n for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 22 Jun 2020 17:27:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnTyT-0007f7-Dj for help-gnu-emacs@gnu.org; Mon, 22 Jun 2020 17:27:29 -0400 Original-Received: from ciao.gmane.io ([159.69.161.202]:48476) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnTyQ-0003XU-QX for help-gnu-emacs@gnu.org; Mon, 22 Jun 2020 17:27:29 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1jnTyO-000AIh-9V for help-gnu-emacs@gnu.org; Mon, 22 Jun 2020 23:27:24 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: help-gnu-emacs@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=159.69.161.202; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/22 15:50:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:123428 Archived-At: Yuan Fu wrote: > (let* ((p (or point (point)))) > (if (eq (char-after point) ?\t) > (valign--tab-width (font-at p)) > ;; (font-at 0 nil (buffer-substring p (1+ p))) doesn’t work, the > ;; font is sometimes wrong. (font-at p) doesn’t work, because > ;; it requires the buffer to be visible. > (aref (aref (font-get-glyphs (font-at p) p (1+ p)) 0) 4))) Hello Yuan Fu, you have a cool name :) re: code, the byte compiler is always your friend: geh.el: In do-something: geh.el:10:17:Warning: reference to free variable ‘point’ In end of data: geh.el:110:1:Warning: the function ‘valign--tab-width’ is not known to be defined. Also style point #1: (aref (aref (font-get-glyphs (font-at p) p (1+ p)) 0) 4))) Suggestion, break it up, do more `let*'. ditto #2: (or point (point)) Straight long-ear [1] use of `or' :) However the particular point (point) is confusing IMO. ditto #3: ... 0) 4))) hard-coded data can also be put into `let*' to increase clarity, however if they only appear once one is allowed... heh :) one is allowed to have them hard-coded. if they ever appear twice names, variables/bindings are compulsory, with the possible exceptions of -1, 0, 1, nil and t :) Keep 'em coming... [1] https://en.wikipedia.org/wiki/Hanau_epe -- underground experts united http://user.it.uu.se/~embe8573 https://dataswamp.org/~incal