From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Okay to commit purely cosmetic (indendation) fixes? Date: Sun, 09 Aug 2020 15:49:25 -0500 Message-ID: <87pn7zwnmy.fsf@red-bean.com> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28624"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 09 22:51:05 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4sHY-0007M0-Ng for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Aug 2020 22:51:04 +0200 Original-Received: from localhost ([::1]:37480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4sHX-0002wI-QY for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Aug 2020 16:51:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4sG2-000121-73 for emacs-devel@gnu.org; Sun, 09 Aug 2020 16:49:30 -0400 Original-Received: from newsp.red-bean.com ([45.79.25.59]:42166 helo=sanpietro.red-bean.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4sG0-0001AU-BA for emacs-devel@gnu.org; Sun, 09 Aug 2020 16:49:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID:Date: Reply-To:Subject:To:From:Sender:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:In-Reply-To:References; bh=ulA7OsoNUqfTjpF6Kvdj9fN44bbT4k0BJJqpAQ0ysC8=; t=1597006167; x=1598215767; b=GMjoIB5h8Iy+YDXPzwGbTEy+WNF4pxyPOMAYFbEvsMg07Epd6DUx1ttPQPvekQdqkGVqD34feY 2Pt0RxM4YF+A3Ai8E84hyJpjka1EPcVXCdNb0xhRNWmJK1vCl5SB/CyfPylNFCpEnkDq9/4Ds3W5V NNs3ZAnHkhf9XHzJ4lF1di24jTsavj+IWZQI4EPA3EGrvFVKMc7NNl+cUDKV89dYGUCefijlL4XU/ Hc/OI7CWwY1Xr8l/3pMT2SxQAyH+xk8N9pI8i7eT0T7AnZDleUWJJM8KNzSpIKUEzBR1IoLu/4cXc aR//xiobO8Ge/RJ0vgWy5VDFjMcr2jT/1cGdg==; Original-Received: from 99-112-125-163.lightspeed.cicril.sbcglobal.net ([99.112.125.163]:48180 helo=floss) by sanpietro.red-bean.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4sFy-0007BE-Lw for emacs-devel@gnu.org; Sun, 09 Aug 2020 20:49:26 +0000 Received-SPF: pass client-ip=45.79.25.59; envelope-from=kfogel@red-bean.com; helo=sanpietro.red-bean.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/09 16:19:14 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253564 Archived-At: Are we okay with purely cosmetic commits to fix source-level formatting issues? Specifically, in lisp/gnus/gnus-start.el, in `gnus-get-unread-articles', there is a multi-line `funcall' that is improperly indented. Here's the fix I'd like to commit: --- lisp/gnus/gnus-start.el +++ lisp/gnus/gnus-start.el @@ -1637,10 +1637,10 @@ gnus-get-unread-articles type-cache)) ;; Only add groups that need updating. (if (or (and foreign-level (null (numberp foreign-level))) - (funcall (if one-level #'= #'<=) (gnus-info-level info) - (if (eq (cadr method-group-list) 'foreign) - foreign-level - alevel))) + (funcall (if one-level #'= #'<=) (gnus-info-level info) + (if (eq (cadr method-group-list) 'foreign) + foreign-level + alevel))) (setcar (nthcdr 2 method-group-list) (cons info (nth 2 method-group-list))) ;; The group is inactive, so we nix out the number of unread articles. The misindentation appears to have been introduced in commit 1f5eeb7be4ac, "Honor docstring of gnus-group-get-new-news" on 4 Feb 2016. I ran across it while debugging a non-cosmetic problem related to the persistently undocumented `dont-connect' parameter, the details of which I won't go into here, but it led to the `info' variable in this function unexpectedly remaining `nil' since being first bound to `nil' in the surrounding `let*', and then `gnus-info-level' raising an error because it's being passed `nil' instead of a number... Anyway, I may or may not ever get to the bottom of that problem, since I found a workaround for my use case, but in the meantime I could at least fix the mis-indentation I found along the way. Thoughts on cosmetic fixes in general and in this specific case? Best regards, -Karl