* bug#2739: diff-mode should highlight "diff:" messages
@ 2009-03-21 17:46 jidanni
2020-08-20 18:55 ` Lars Ingebrigtsen
0 siblings, 1 reply; 7+ messages in thread
From: jidanni @ 2009-03-21 17:46 UTC (permalink / raw)
To: bug-gnu-emacs
Diff mode likes highlighting things.
Well, it should extra-highlight important lines that start with
"diff:":
diff -U0 /home/jidanni /cf/tojidanni1/source
diff: /home/jidanni/source: No such file or directory
Diff finished. Sun Mar 22 01:42:11 2009
(And it should detect the error, probably already done in your source code.)
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#2739: diff-mode should highlight "diff:" messages
2009-03-21 17:46 bug#2739: diff-mode should highlight "diff:" messages jidanni
@ 2020-08-20 18:55 ` Lars Ingebrigtsen
2020-08-21 13:34 ` 積丹尼 Dan Jacobson
0 siblings, 1 reply; 7+ messages in thread
From: Lars Ingebrigtsen @ 2020-08-20 18:55 UTC (permalink / raw)
To: jidanni; +Cc: 2739
jidanni@jidanni.org writes:
> Diff mode likes highlighting things.
> Well, it should extra-highlight important lines that start with
> "diff:":
>
> diff -U0 /home/jidanni /cf/tojidanni1/source
> diff: /home/jidanni/source: No such file or directory
>
> Diff finished. Sun Mar 22 01:42:11 2009
>
> (And it should detect the error, probably already done in your source code.)
Do you have a test case to reproduce this bug?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#2739: diff-mode should highlight "diff:" messages
2020-08-20 18:55 ` Lars Ingebrigtsen
@ 2020-08-21 13:34 ` 積丹尼 Dan Jacobson
2020-08-21 13:46 ` Lars Ingebrigtsen
2020-08-21 13:59 ` Lars Ingebrigtsen
0 siblings, 2 replies; 7+ messages in thread
From: 積丹尼 Dan Jacobson @ 2020-08-21 13:34 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 2739
>>>>> "LI" == Lars Ingebrigtsen <larsi@gnus.org> writes:
LI> jidanni@jidanni.org writes:
>> Diff mode likes highlighting things.
>> Well, it should extra-highlight important lines that start with
>> "diff:":
>>
>> diff -U0 /home/jidanni /cf/tojidanni1/source
>> diff: /home/jidanni/source: No such file or directory
>>
>> Diff finished. Sun Mar 22 01:42:11 2009
>>
>> (And it should detect the error, probably already done in your source code.)
LI> Do you have a test case to reproduce this bug?
lrwxrwxrwx 1 jidanni 4 08-21 21:31 pppp -> zzzz
lrwxrwxrwx 1 jidanni 4 08-21 21:30 yyyyy -> ssss
= runs the command dired-diff (found in dired-mode-map)
diff -U0 /home/jidanni/pppp /home/jidanni/yyyyy
diff: /home/jidanni/pppp: No such file or directory
diff: /home/jidanni/yyyyy: No such file or directory
Diff finished (diff error). Fri Aug 21 21:31:28 2020
So the errors should be in red.
And in the modeline something should indicate an error.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#2739: diff-mode should highlight "diff:" messages
2020-08-21 13:34 ` 積丹尼 Dan Jacobson
@ 2020-08-21 13:46 ` Lars Ingebrigtsen
2020-08-21 13:59 ` Lars Ingebrigtsen
1 sibling, 0 replies; 7+ messages in thread
From: Lars Ingebrigtsen @ 2020-08-21 13:46 UTC (permalink / raw)
To: 積丹尼 Dan Jacobson; +Cc: 2739
積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:
> LI> Do you have a test case to reproduce this bug?
>
> lrwxrwxrwx 1 jidanni 4 08-21 21:31 pppp -> zzzz
> lrwxrwxrwx 1 jidanni 4 08-21 21:30 yyyyy -> ssss
>
> = runs the command dired-diff (found in dired-mode-map)
>
> diff -U0 /home/jidanni/pppp /home/jidanni/yyyyy
> diff: /home/jidanni/pppp: No such file or directory
> diff: /home/jidanni/yyyyy: No such file or directory
>
> Diff finished (diff error). Fri Aug 21 21:31:28 2020
>
> So the errors should be in red.
Thanks. The base function called here is apparently:
(diff "/tmp/unexist1" "/tmp/unexist2" "-u")
Which displays the problem. It looks like diff picks up on it being an
error, but doesn't do any fontizing in this case. Which I guess should
be set up from 'diff-sentinel'.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#2739: diff-mode should highlight "diff:" messages
2020-08-21 13:34 ` 積丹尼 Dan Jacobson
2020-08-21 13:46 ` Lars Ingebrigtsen
@ 2020-08-21 13:59 ` Lars Ingebrigtsen
2020-08-21 14:30 ` 積丹尼 Dan Jacobson
1 sibling, 1 reply; 7+ messages in thread
From: Lars Ingebrigtsen @ 2020-08-21 13:59 UTC (permalink / raw)
To: 積丹尼 Dan Jacobson; +Cc: 2739
積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:
> So the errors should be in red.
I've now done this in Emacs 28.
> And in the modeline something should indicate an error.
Hm... diff-mode doesn't mess around with the mode line normally, so I
think that would be surprising. I think the red error lines is
sufficient here.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#2739: diff-mode should highlight "diff:" messages
2020-08-21 13:59 ` Lars Ingebrigtsen
@ 2020-08-21 14:30 ` 積丹尼 Dan Jacobson
2020-08-21 15:35 ` Andreas Schwab
0 siblings, 1 reply; 7+ messages in thread
From: 積丹尼 Dan Jacobson @ 2020-08-21 14:30 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 2739
>>>>> "LI" == Lars Ingebrigtsen <larsi@gnus.org> writes:
>> And in the modeline something should indicate an error.
LI> Hm... diff-mode doesn't mess around with the mode line normally, so I
LI> think that would be surprising. I think the red error lines is
LI> sufficient here.
I was just thinking it could be like
(compile "false")
So there would be three states, no differences, found differences, and errors.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#2739: diff-mode should highlight "diff:" messages
2020-08-21 14:30 ` 積丹尼 Dan Jacobson
@ 2020-08-21 15:35 ` Andreas Schwab
0 siblings, 0 replies; 7+ messages in thread
From: Andreas Schwab @ 2020-08-21 15:35 UTC (permalink / raw)
To: 積丹尼 Dan Jacobson; +Cc: Lars Ingebrigtsen, 2739
On Aug 21 2020, 積丹尼 Dan Jacobson wrote:
>>>>>> "LI" == Lars Ingebrigtsen <larsi@gnus.org> writes:
>>> And in the modeline something should indicate an error.
>
> LI> Hm... diff-mode doesn't mess around with the mode line normally, so I
> LI> think that would be surprising. I think the red error lines is
> LI> sufficient here.
>
> I was just thinking it could be like
> (compile "false")
>
> So there would be three states, no differences, found differences, and errors.
diff-mode is about highlighting the contents of a buffer, not about
producing it.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-08-21 15:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-21 17:46 bug#2739: diff-mode should highlight "diff:" messages jidanni
2020-08-20 18:55 ` Lars Ingebrigtsen
2020-08-21 13:34 ` 積丹尼 Dan Jacobson
2020-08-21 13:46 ` Lars Ingebrigtsen
2020-08-21 13:59 ` Lars Ingebrigtsen
2020-08-21 14:30 ` 積丹尼 Dan Jacobson
2020-08-21 15:35 ` Andreas Schwab
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.