From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive Date: Sun, 23 Aug 2020 23:26:26 +0200 Message-ID: <87pn7hawal.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6089"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: 43003@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 23 23:27:31 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k9xWV-0001UU-Cq for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Aug 2020 23:27:31 +0200 Original-Received: from localhost ([::1]:43494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9xWU-0004hu-8v for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Aug 2020 17:27:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9xW2-0004hm-Bb for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 17:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43692) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k9xW2-0008AX-36 for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 17:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k9xW2-0001o9-0J for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 17:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Aug 2020 21:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43003 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15982179936909 (code B ref -1); Sun, 23 Aug 2020 21:27:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Aug 2020 21:26:33 +0000 Original-Received: from localhost ([127.0.0.1]:55237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9xVY-0001nN-TM for submit@debbugs.gnu.org; Sun, 23 Aug 2020 17:26:33 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:51372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9xVX-0001nF-KH for submit@debbugs.gnu.org; Sun, 23 Aug 2020 17:26:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9xVX-0004f9-EL for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 17:26:31 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:40153) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9xVV-00081x-N4 for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 17:26:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598217987; bh=ZarThuz2JUPUOsraafRjXFULaldeF45JXp8FHri5HOw=; h=X-UI-Sender-Class:From:To:Subject:Date; b=FiE8GgHQ8EvcHlkjr7viDEoLaoAjT8C7sOMqwfHOsu4lyVFM03igl0HVLNMw8vIUG taLcdxEcbbYJ1T+EIqxPN17nvfHa10DPMT5LhU3IC/mX/ZYvpzs/3g4nWm3raCI32E /PApQlX8e9qn9KYELtnmQ/Bw1pe+uUF9okLFqToI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobe-jhalfs ([92.73.78.116]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MfHEJ-1kpJbk2G9z-00gnMh for ; Sun, 23 Aug 2020 23:26:27 +0200 X-Provags-ID: V03:K1:yORn1/Q47Ixc7H9JLzDzhO/cMWL1lLNuPVIS10MhCoFMy3okJpk uKnOxO9V1x85XY3StQ+gRaDPr5rVTav8r1Q0/RAYwBgeRwi0JDJuSKuO6plx2IugehtcFQB vGpDTLHvv5Iaelvdw8//kNtEE1hUbDg9DKD50ZnZjEohBq6OVWXXm/fHRvGnVZBjIrcVDzC 6mrbVISnb7yA2JpKZsacA== X-UI-Out-Filterresults: notjunk:1;V03:K0:dBYB7sUcjbw=:uS/HQXiQr6uJTL2ZnWMX9L M8bm1dMDAvDandcd2OC6+vo4m3sT20W6UzsfNiDk4x4fYQgmue5LjeuZLlyt9/ENNSIyDjEDH woVkCNNXSVj/Zg0aLP6y0mpItNysX+0oSNm74KUI0SF2HueRwKPOBvIUiXnjOzDBMiWJ2M1id KxpFJmdor4H1BYwbfpKD34Vfq1A60e0aawG1TzQlo9hLUamNpaTjM0lQgoak/DVT4MJ2gbwqC gvAvwjSFbj2dSmMkQJ+l/hQKekQkZDrRBiZeeqRMNqap6ek5VX1vlQKDl/wdHQSa9BY9bmRQ6 4FpYr7RWlmiy2SfxeLrEpVOQ64NPSFTea0XKZ5S2bXcYpy1hmPWeje9w1i7VoFeZeub9Djz4t awcsfJXXTYa0QX/32BTCL+vtm6s02KdoptWcIrQCg0Zv/j1QHxcZ0vgodmJf0iHUcEAJPV5c3 nyUWXV3CqmshzzuQ/vv97rq1ibIKe64NTriQpjMzDsJcrxnxaz+ShVoMWeQr17bNfMrAC3Cj5 8krGSYCrLWrsfO2ckiJYam/K+LVVHmrt3c0XJTdWDct4spsko0kDiJ5+585/3n4fUQUXII/cE m7SdFY/q27mMCpVpZyTGn0ZwuY8zWHDbzrA6T3SN7v0Ed7sUc+XUYXgAopEOCcAb05tfR8ttA 9T4JjtYe7dU0ee061l7OsijzCm/6YzRgGOVo2ZfnACFmMkR0JbRF+qqDaJSY7MkYBU/RBt4jY ULSiPKqCjbWgVuiL0kW4twDcsyIJ1k9GXx/cfhy7WWV2nvdAV8mCYP0BysOZ8Qs3TJTjZ5Lg Received-SPF: pass client-ip=212.227.17.21; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/23 17:26:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186090 Archived-At: On one of my systems, when using ssh in shell-mode (M-x shell), the password prompt does not appear in the minibuffer but only in the *shell* buffer directly under the ssh invocation, and the password is not hidden when it's entered. I've determined that reason is that the password prompt string passed to comint-output-filter begins with a carriage return character (^M), and when the rest of the prompt string begins with "Password" (which it can on this system), comint-password-prompt-regexp does not match it and thus comint-watch-for-password-prompt returns nil instead of calling comint-send-invisible. So far I haven't found out where the carriage return is coming from, maybe it's from openssh (on the system where the carriage return occurs in the prompt string I have openssh-8.2p1, another system where the carriage return does not occur has openssh-7.9p1; if anyone knows the answer, or has a suggestion for how to find out, I'd appreciate hearing it). As a workaround, I can customize comint-password-prompt-regexp to match the prompt with the carriage return. But this problem could be seen as a datapoint in favor of changing the default value of comint-password-prompt-regexp. Already in bug#31075 Noam Postavsky pondered whether eshell-password-prompt-regexp should replace comint-password-prompt-regexp, noting that "the eshell regexp looks much simpler". And indeed, on the system where the carriage return occurs in the prompt string, using ssh in the Emacs shell (M-x eshell) does use the minibuffer for password input and it is hidden; and if I set comint-password-prompt-regexp to eshell-password-prompt-regexp, then I also get minibuffer hidden input in shell-mode. So this bug report is basically a plea to change the default value of comint-password-prompt-regexp to be the same as that of eshell-password-prompt-regexp. Or is there a good reason not to do this? In GNU Emacs 28.0.50 (build 16, x86_64-pc-linux-gnu, GTK+ Version 3.24.17, cairo version 1.17.3) of 2020-08-21 built on strobe-jhalfs Repository revision: 3e10174fb65f4eb601b1921271bdcf10c933b879 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Linux From Scratch SVN-20200401 Configured using: 'configure 'CFLAGS=-Og -g3' PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD PDUMPER LCMS2