From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#32266: Cannot add directory names ending in .el with normal-top-level-add-subdirs-to-load-path Date: Wed, 26 Aug 2020 14:50:13 +0200 Message-ID: <87pn7dzi4a.fsf@gnus.org> References: <87o9dj3on5.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13404"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: =?UTF-8?Q?H=C3=A5kon_?= =?UTF-8?Q?H=C3=A6gland?= , 32266@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 26 14:51:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAutV-0003LP-AJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Aug 2020 14:51:13 +0200 Original-Received: from localhost ([::1]:43396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAutU-0000vO-Br for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Aug 2020 08:51:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAutK-0000qi-U9 for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2020 08:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54409) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAutK-00008W-L1 for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2020 08:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kAutK-0006sr-JY for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2020 08:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Aug 2020 12:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32266 X-GNU-PR-Package: emacs Original-Received: via spool by 32266-submit@debbugs.gnu.org id=B32266.159844622926388 (code B ref 32266); Wed, 26 Aug 2020 12:51:02 +0000 Original-Received: (at 32266) by debbugs.gnu.org; 26 Aug 2020 12:50:29 +0000 Original-Received: from localhost ([127.0.0.1]:37715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAusn-0006rW-5i for submit@debbugs.gnu.org; Wed, 26 Aug 2020 08:50:29 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAusk-0006rD-Pp for 32266@debbugs.gnu.org; Wed, 26 Aug 2020 08:50:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ltR1hIFKsnkpOwMiVd0ohAjK013AotMSFcNKO9nD2+Y=; b=Qrt+47+ZU3Ey9/zQwYFMuNK1dP k1DTKgIzK59cyjgu4wRAwvv8XsdWda2AY15hN0ysWG0Xg+/byfm40kGDj7hO2Swm8XGucIQkaXi4i zDaf3P7YOfhk2EM7/VrHHK6OH1j0z8Nr340GZwochxEXoDf1OkmTXb9eBfd0JvDxFfOE=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAusZ-0005dP-Bn; Wed, 26 Aug 2020 14:50:20 +0200 X-Now-Playing: Shirley Collins's _Heart's Ease_: "Tell Me True" In-Reply-To: <87o9dj3on5.fsf@gmail.com> (Robert Pluim's message of "Thu, 30 Aug 2018 16:38:54 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186435 Archived-At: Robert Pluim writes: > The comment just above says > > ;; Avoid doing a `stat' when it isn't necessary because > ;; that can cause trouble when an NFS server is down. > > which has been there for a long time. If an NFS server *is* down, then > that will manifest itself with other files anyway, so I don't see why > we'd need special handling here. I propose: Yeah, that's just odd. And having directories called .el isn't that strange, anyway, so I've applied your patch to Emacs 28: > - ;; Avoid doing a `stat' when it isn't necessary because > - ;; that can cause trouble when an NFS server is down. > - (not (string-match "\\.elc?\\'" file)) I did a "make" and "make bootstrap" and I can't see any adverse effects. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no