From: Lars Ingebrigtsen <larsi@gnus.org>
To: Yuri D'Elia <wavexx@thregr.org>
Cc: 21242@debbugs.gnu.org
Subject: bug#21242: 24.5.1; python.el: should display output buffer on exceptions when using python-shell-send-region
Date: Thu, 17 Sep 2020 20:01:20 +0200 [thread overview]
Message-ID: <87pn6kmgen.fsf@gnus.org> (raw)
In-Reply-To: <55CB52B6.8020308@thregr.org> (Yuri D'Elia's message of "Wed, 12 Aug 2015 16:05:42 +0200")
Yuri D'Elia <wavexx@thregr.org> writes:
> When evaluating the code interactively, there's currently no
> notification about evaluation errors. Exceptions in the output buffer go
> simply unnoticed, unless you watch for them closely. I like to keep the
> output buffer buried, and assume that no-notification==no-error.
>
> Exceptions caused by interactive evaluation should either:
>
> - show a notification of sorts in the minibuffer
> - display the output buffer for inspection
I don't use this stuff a lot, but I just don't understand how the patch
attached relates to the reported problem.
And there's also Andreas's comment (at the end).
Yuri, could you explain a bit more about how this patch fixes the
problem?
> - (toplevel-block-p (save-excursion
> - (goto-char start)
> - (or (zerop (line-number-at-pos start))
> - (progn
> - (python-util-forward-comment 1)
> - (zerop (current-indentation)))))))
> + (block-param (save-excursion
> + (goto-char start)
> + (progn
> + (python-util-forward-comment 1)
> + (list (current-indentation)
> + (/= (point) start)))))
> + (block-indentation (car block-param))
> + (starts-with-indentation-p (cadr block-param)))
> (with-temp-buffer
> (python-mode)
> (if fillstr (insert fillstr))
> + (when (and (> block-indentation 0) (not starts-with-indentation-p))
> + (insert (make-string block-indentation ?\s)))
> (insert substring)
> (goto-char (point-min))
> - (when (not toplevel-block-p)
> + (when (> block-indentation 0)
> (insert "if True:")
> (delete-region (point) (line-end-position)))
Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
>> Given previous experience with python-mode.el (which tends to break the
>> current window layout with his own splitting logic), I find it important
>> that the notification function (which displays the output buffer) should
>> be customizable, and this is reflected in the example code.
>
> WRT python-mode.el:
>
> Splitting-behavior _is_ customizable. It only occurs if
> py-split-window-on-execute is non-nil - default is 'just-two.
> Also there is py-keep-windows-configuration, when non-nil it precedes
> other settings.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-09-17 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 14:05 bug#21242: 24.5.1; python.el: should display output buffer on exceptions when using python-shell-send-region Yuri D'Elia
2015-08-13 6:48 ` Andreas Röhler
2020-09-17 18:01 ` Lars Ingebrigtsen [this message]
2020-09-17 18:44 ` Yuri D'Elia
2020-09-18 11:07 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn6kmgen.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=21242@debbugs.gnu.org \
--cc=wavexx@thregr.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.