bug#43896: 28.0.50; End of file during parsing ~/.pop3-uidl

[Andreas Schwab <schwab@linux-m68k.org>]

On Okt 10 2020, Lars Ingebrigtsen wrote:

> Mats Lidell <matsl@gnu.org> writes:
>
>> Trying to use gnus with pop3 but getting "end of file during parsing ~/.pop3-uidl" when fetching mail. The file that is created when fetching mails look strange:
>>
>> (("fencepost.gnu.org"
>>   ("matsl"
>>    "Mm6!!WRW!!3k~"!*&@!!" (24448 57982)
>>    "bL^"!i1n!!W#N"!Q$I!!" (24448 57982)
>>    "Dc7!!~J-!!X1T!!A%$#!" (24448 57982)
>>    "\L9!!GWa"!n+p"!Q1^"!" (24448 57982))))
>>
>> Any ideas what could be causing this?
>
> I'm not sure whether that file looks strange or not?  It looks
> well-formed, at least.

It's not, the embedded double quotes need to be quoted.

diff --git a/lisp/net/pop3.el b/lisp/net/pop3.el
index 6f5898437c..d7d563fbc2 100644
--- a/lisp/net/pop3.el
+++ b/lisp/net/pop3.el
@@ -463,7 +463,7 @@ Return non-nil if it is necessary to update the local UIDL file."
 		(when (cdr elt)
 		  (insert "(\"" (pop elt) "\"\n   ")
 		  (while elt
-		    (insert (format "\"%s\" %s\n   " (pop elt) (pop elt))))
+		    (insert (format "%S %s\n   " (pop elt) (pop elt))))
 		  (delete-char -4)
 		  (insert ")\n  ")))
 	      (delete-char -3)

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."