From: Juri Linkov <juri@linkov.net>
To: Ergus <spacibba@aol.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
Drew Adams <drew.adams@oracle.com>,
emacs-devel@gnu.org
Subject: Re: feature/completions-highlight-modifications e3c5b99 3/6: Add completions-highlight-mode initial implementation.
Date: Mon, 23 Nov 2020 11:14:47 +0200 [thread overview]
Message-ID: <87pn44juyg.fsf@mail.linkov.net> (raw)
In-Reply-To: <20201122230956.mai3i6ckqymzvyvb@Ergus> (Ergus's message of "Mon, 23 Nov 2020 00:09:56 +0100")
> Could you try it now please?
Thanks, now this feature is getting into good shape, and it seems soon
your branch will be ready for merging.
> I am wondering that with this new behavior it is a bit more like zsh but
> diverges a bit too much from the current default emacs completion, so
> making this default will be virtually impossible. And my real objective
> was to improve the default completion; not make a new one.
Don't hold out too much hope on enabling this feature by default.
Even in zsh this completion style is not enabled by default,
only adding "zstyle ':completion:*' menu select" enables it.
Also in Emacs even less intrusive icomplete-mode is not enabled
by default.
For example, currently when the completions buffer is displayed,
C-r is still available for searching through the previous history.
But when this new mode is enabled, it's more useful to allow C-r
to search in the completions buffer, that works well with your
latest commit.
IOW, the main difference of this feature is that typing TAB
enables a special mode for selecting a completion, and disables
history navigation and motion keys in the minibuffer.
> IMO we may reconsider if we should go in the direction of commit
> 60a1003aee or in the one of c7c47e78e6.
Yes, these are two diverging roads. So we need to try both, identify
their advantages/disadvantages to decide what path/patch to follow.
With c7c47e78e6, all present motion keys are still available in the
completions buffer, but are all keys that used to exit still handled?
Also setting buffer-local cursor-in-echo-area to t in the completions
buffer provides a better look and feel of editing in the minibuffer
(like you disabled mode-line).
next prev parent reply other threads:[~2020-11-23 9:14 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201115023629.19537.77471@vcs0.savannah.gnu.org>
[not found] ` <20201115023631.C78AB20A27@vcs0.savannah.gnu.org>
2020-11-15 18:41 ` feature/completions-highlight-modifications e3c5b99 3/6: Add completions-highlight-mode initial implementation Stefan Monnier
2020-11-15 22:49 ` Ergus
2020-11-15 23:32 ` Stefan Monnier
2020-11-16 3:37 ` Ergus
2020-11-16 3:56 ` Stefan Monnier
2020-11-16 5:40 ` Drew Adams
2020-11-16 7:39 ` Ergus
2020-11-16 5:38 ` Drew Adams
2020-11-16 8:54 ` Juri Linkov
2020-11-16 10:27 ` Ergus
2020-11-16 20:23 ` Juri Linkov
2020-11-16 21:16 ` Drew Adams
2020-11-17 0:46 ` Ergus
2020-11-17 20:02 ` Juri Linkov
2020-11-17 20:52 ` Drew Adams
2020-11-18 19:43 ` Juri Linkov
2020-11-18 22:45 ` Drew Adams
2020-11-19 3:25 ` Ergus
2020-11-19 7:45 ` Juri Linkov
2020-11-19 10:50 ` Ergus
2020-11-20 9:32 ` Juri Linkov
[not found] ` <20201120145248.wmbv2zgbvs7bg25i@Ergus>
2020-11-21 19:30 ` Juri Linkov
2020-11-22 13:28 ` Ergus
2020-11-22 20:03 ` Juri Linkov
2020-11-22 23:09 ` Ergus
2020-11-23 9:14 ` Juri Linkov [this message]
2020-11-23 11:46 ` Ergus
2020-11-23 14:13 ` Jean Louis
2020-11-23 19:12 ` Eli Zaretskii
2020-11-23 19:44 ` Jean Louis
2020-11-23 20:54 ` Dmitry Gutov
2020-11-23 23:27 ` Ergus via Emacs development discussions.
2020-12-10 1:16 ` Dmitry Gutov
2020-12-10 8:23 ` Juri Linkov
2020-11-25 8:49 ` Juri Linkov
2020-11-20 14:24 ` Stefan Monnier
[not found] ` <20201120144940.p55brblxpuowslag@Ergus>
2020-11-20 15:15 ` Stefan Monnier
2020-11-16 16:03 ` Drew Adams
2020-11-16 20:28 ` Juri Linkov
2020-11-16 21:31 ` Drew Adams
2020-11-18 19:30 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn44juyg.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=spacibba@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.