From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#44639: [PATCH 2/2] autorevert: map each watch descriptor to a single buffer Date: Thu, 28 Jan 2021 04:29:16 +0100 Message-ID: <87pn1p68oj.fsf@gnus.org> References: <20201114165459.9518-1-sbaugh@catern.com> <20201114165459.9518-2-sbaugh@catern.com> <87o8jcdzyv.fsf@gmx.de> <87k0rzc9o6.fsf@gnus.org> <87tur2tk3q.fsf@catern.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15719"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Michael Albinus , 44639@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 28 04:30:43 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l4y15-0003yt-KR for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Jan 2021 04:30:43 +0100 Original-Received: from localhost ([::1]:47872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4y12-0006GB-Ec for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Jan 2021 22:30:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4y0Q-0006G2-Fv for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2021 22:30:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35155) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l4y0Q-0008Ma-7h for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2021 22:30:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l4y0Q-0004KS-1F for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2021 22:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Jan 2021 03:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 44639-submit@debbugs.gnu.org id=B44639.161180457716589 (code B ref 44639); Thu, 28 Jan 2021 03:30:01 +0000 Original-Received: (at 44639) by debbugs.gnu.org; 28 Jan 2021 03:29:37 +0000 Original-Received: from localhost ([127.0.0.1]:46701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4y00-0004JV-VT for submit@debbugs.gnu.org; Wed, 27 Jan 2021 22:29:37 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:56946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4xzy-0004JI-KQ for 44639@debbugs.gnu.org; Wed, 27 Jan 2021 22:29:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=E6ZFmsoaAiNmlnpRP7Tep+dhHSYO3OK7fDHc4l8m+W8=; b=rPia68PbzukMItYvf1YBVJx8Ze HXE/+2zr92J4h5F17kQZe14z6Hlt5jmJAUrgYFydGhel4iS9MDBqDphovkbFH5DLoS3fIIocUwHHs H25C3wptvlwxNUaNEh/SF/Md9Pt4fe6iIdyApp3gRHyAq5Rceblo6NX62KMkP/17tBdA=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l4xzi-0003YX-6i; Thu, 28 Jan 2021 04:29:28 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEX5+euipq4hLE5t dYkaJkkgKkv///++XiGtAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+UBHAMaH5KRqHEAAAGjSURBVDjL rZRhboMwDIXJuABVLzC5zgFKdoDVOBeIkvtfZc8mpYC6H5NmqQX6+fk5Tugw/F9MvwEiuqWULogh 2HeyQLpuIcO43X++B8InECTqMm+Kuv6eAZbEt4Xx8H1SLHdO81cHDVcWXkslpvmdQoiFtINYhGCD yxSUVRLtSkmuJUKBO5qJVsBeRiOZQjEHlrXdmlskKrkogAAQ8WHlYgphYorkAN6x4VPISjHySdwD HdVsTu6Bds384aWoxzSKkpiADRAdwWysA+7mAIxnYekgmjXMR8JAZoLMQd6VwjDJRA8fCbMIFs5Q oCOboxzMDSSxZcjNQPR+kYVSt4Txoo90UnwQA7A+2y3emAFVB6qLzaoqR7H2p9GAL2rxHXyZyx4U tb1kB7wHllxi3IBuCo67Ie4UVif7sk5gP3Z6lhKflWjOFVOaghxAba205uCgqNnNC7oKxPoCdtr8 NagoRbYjmR0gtynOXDEFdtzPvvQDl9XSoBB/n7RKP1ctY2IoxfXg8QyA7X4YLEfWd30K6X69X67p mhL+AUKYhj/F5ZfffwDV0b6VPeyM5gAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0wMS0yOFQwMzoy NjozMCswMDowMA1OL0kAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMDEtMjhUMDM6MjY6MzArMDA6 MDB8E5f1AAAAAElFTkSuQmCC X-Now-Playing: Wishmountain's _Wishmountain is Dead_: "Bottle" In-Reply-To: <87tur2tk3q.fsf@catern.com> (Spencer Baugh's message of "Wed, 27 Jan 2021 11:34:01 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198729 Archived-At: Spencer Baugh writes: >>> Just for the records, when I apply both patches 1/2 and 2/2, >>> autorevert-tests fails. So it cannot be applied as such. >> >> Spencer, did you do any further work on this patch? > > Not this patch, no. Locally I have applied patch 1/2 and not patch > 2/2. Patch 2/2 just removes dead code after patch 1/2 removes the > functionality, and I must have gotten it wrong. > > But I can report that performance has been fine with patch 1/2 - I > haven't seen the pathological case I was seeing before, and I haven't > seen any new pathological cases to replace it. Patch 1/2 was applied to Emacs 28 some time ago (and works fine), so this was just a followup on 2/2 -- whether this clean-up patch (which apparently doesn't work correctly, according to Michael) is going to get any further work done, or whether this issue should just be closed... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no