From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: Gnus using lexical-binding Date: Tue, 02 Feb 2021 12:31:50 -0800 Message-ID: <87pn1i1aa1.fsf@ericabrahamsen.net> References: <86k0ruqub2.fsf@gmail.com> <86pn1mz4ni.fsf@gmail.com> <86wnvu80wp.fsf@gmail.com> <874kiu5o6l.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16684"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Andy Moreton , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 02 21:32:53 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l72Lz-0004CF-IU for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Feb 2021 21:32:51 +0100 Original-Received: from localhost ([::1]:42580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l72Ly-0001sZ-IA for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Feb 2021 15:32:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l72L6-0001Fs-JR for emacs-devel@gnu.org; Tue, 02 Feb 2021 15:31:56 -0500 Original-Received: from ericabrahamsen.net ([52.70.2.18]:41696 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l72L4-0002yq-I2 for emacs-devel@gnu.org; Tue, 02 Feb 2021 15:31:56 -0500 Original-Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id DB074FA165; Tue, 2 Feb 2021 20:31:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1612297912; bh=m/u1djmpwW8AtsoVxZVlhtcti6TwWmaf43pGb971kno=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=h6DC4RmrxQBO6c0bP3Tj/1RK+dXG2jTOAb8i1hCS4tFi4nX+BzYW2kB2e0SJxMqYU SM000vEM/rvapf1FQKbzVxMdt4bHVnRPJsTeh5JCOIjc71ixKhcSfB1n2jJObxqT+u iW5JqZVNYvqkANWPd2VWxha8XAZufdFXQClo5mS4= In-Reply-To: (Stefan Monnier's message of "Tue, 02 Feb 2021 14:40:00 -0500") Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263754 Archived-At: Stefan Monnier writes: >> I'm now seeing a bug with `gnus-article-browse-html-article' that might >> (?) be a result of this, I'm not sure. > > It's triggered by the recent change, indeed. > It's due to a longer standing bug, tho. [...] > I'm not completely sure why this code looks up the `standard-value`, but > the `standard-value` property is supposed to contain a cons cell whose > car is an *expression* that needs to be evaluated to get the variable's > intended standard value. Ah, hence the lambda. I can't immediately think of why we'd need the standard value of the option here, either. > So it will never be nil and using it as a value is just wrong. > > I installed a patch into `master` which should hopefully fix > the problem. Looks good! Thanks for the quick fix. Eric