From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#22066: 24.5; documentation for "values" is not accurate Date: Mon, 08 Feb 2021 17:15:37 +0100 Message-ID: <87pn1alemu.fsf@gnus.org> References: <87zhksiyyl.fsf@mouse.gnus.org> <87blcvm3m4.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12100"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Shiyao Ma , 22066@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 08 21:34:33 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9DEu-000319-MY for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Feb 2021 21:34:32 +0100 Original-Received: from localhost ([::1]:56338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9DEt-000054-Dl for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Feb 2021 15:34:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l99Cv-0003UM-4i for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 11:16:13 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40220) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l99Ck-0005jL-IJ for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 11:16:08 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l99Ck-0003NM-Eo for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 11:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2021 16:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22066 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 22066-submit@debbugs.gnu.org id=B22066.161280095312959 (code B ref 22066); Mon, 08 Feb 2021 16:16:02 +0000 Original-Received: (at 22066) by debbugs.gnu.org; 8 Feb 2021 16:15:53 +0000 Original-Received: from localhost ([127.0.0.1]:51766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l99Cb-0003Mw-Bq for submit@debbugs.gnu.org; Mon, 08 Feb 2021 11:15:53 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:49320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l99CW-0003Me-J1 for 22066@debbugs.gnu.org; Mon, 08 Feb 2021 11:15:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Y6om//VkkshGVgJFSkx753+Uyjg11AhGqEw0xcXSCI4=; b=ei1dHRM8f7706bG0dpU6PMoh1Y 3PwgQ2B9MDIhBnRZb3ou55MRArx4RkPJBiUpQ3uRV86hDyHZwnnkcR94D8RxoDyzqchieAd2LR06O Qevxh6zGPsXp+ap6NxJPFXUDDUJJLtWnkTAl1czEkOV1KDt37Me3YDPJqbXa8BEZ29U4=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l99CM-00085I-FC; Mon, 08 Feb 2021 17:15:41 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEUtIhRUOiOjjBud WhP///8fjvsCAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UCCBALIYaSMfsAAAGySURBVDjLbVQLcgUh CJP2AqAXqHKBJ9z/bg3+1vdad3bHMWsIEUwpJfkz0hy5uaq11qyZm3mrG9CmzZsBw4vnAP4xNlAU tPTE8n4AnpMF2ASIs8oFsKwYFFR8AEoH4OJL+qbSScAjOCj2sEeVz5XSe/eygycpPoC+sig+qUiQ YA/U4QyGLyBJVtMJuMbH9g6sdQL/iBKZ+9mBIOUxfcuFidZn0lSlYscGlqpIWwIwv92N9Flqljdg SEImVG3G4OnVEAllQrVhpyndQCjNONzcP4AQkFv1UjeQFoBcDID2J/hyL5gkAH0HwgyDx327y3lQ aemRKdQ9waex30iEhUoyP6q6dFHCdFTFpUoYNMREHCuPiUHfE8wleuFHv0z0zvyNAFRJ0sojVPU+ JkRRRHRb8prlAuzdXWYIAp98AvhGPb1Ay+k586KDAgC6Dv9eJqoTiqsiUn6AUIUs0IioA1ARX6ow kYo03NpPWHL6Y/RGrqhg+5GzAyzpC+5FYMks28SoRBQwU5MER2DjZeIs7uiumB1Vuxj2uM4D14Sa RdfYeGi289dsF9wjuFLmjrRa559r6Ren12CAcly3gwAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0w Mi0wOFQxNjoxMTozMyswMDowMLDSDKcAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMDItMDhUMTY6 MTE6MzMrMDA6MDDBj7QbAAAAAElFTkSuQmCC X-Now-Playing: DJ Haram's _Grace_: "Body Count" In-Reply-To: (Stefan Monnier's message of "Mon, 08 Feb 2021 11:00:46 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199610 Archived-At: Stefan Monnier writes: > FWIW, I think this `values` thingy should die. I agree -- we could mark it obsolete now, but we'd have to rewrite the one place where it's actually used: (defun elisp--eval-defun () [...] (eval-region beg end standard-output (lambda (_ignore) ;; Skipping to the end of the specified region ;; will make eval-region return. (goto-char end) form)))))) (let ((str (eval-expression-print-format (car values)))) (if str (princ str))) ;; The result of evaluation has been put onto VALUES. So return it. (car values)) `eval-region' just returns nil, but that `lambda' could just capture the value instead of the functoin then looking in `values', I think? So the one usage looks like it could be trivially rewritten. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no