From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Shiyao Ma <i@introo.me>, 22066@debbugs.gnu.org
Subject: bug#22066: 24.5; documentation for "values" is not accurate
Date: Mon, 08 Feb 2021 17:15:37 +0100 [thread overview]
Message-ID: <87pn1alemu.fsf@gnus.org> (raw)
In-Reply-To: <jwvft26wo70.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 08 Feb 2021 11:00:46 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> FWIW, I think this `values` thingy should die.
I agree -- we could mark it obsolete now, but we'd have to rewrite the
one place where it's actually used:
(defun elisp--eval-defun ()
[...]
(eval-region beg end standard-output
(lambda (_ignore)
;; Skipping to the end of the specified region
;; will make eval-region return.
(goto-char end)
form))))))
(let ((str (eval-expression-print-format (car values))))
(if str (princ str)))
;; The result of evaluation has been put onto VALUES. So return it.
(car values))
`eval-region' just returns nil, but that `lambda' could just capture the
value instead of the functoin then looking in `values', I think? So the
one usage looks like it could be trivially rewritten.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-02-08 16:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 5:48 bug#22066: 24.5; documentation for "values" is not accurate Shiyao Ma
2019-08-01 17:21 ` Lars Ingebrigtsen
2021-02-08 7:16 ` Lars Ingebrigtsen
2021-02-08 16:00 ` Stefan Monnier
2021-02-08 16:15 ` Lars Ingebrigtsen [this message]
2021-02-08 17:07 ` Stefan Monnier
2021-02-09 7:37 ` Lars Ingebrigtsen
2021-02-09 7:57 ` Lars Ingebrigtsen
2021-02-09 15:24 ` Stefan Monnier
2021-02-09 15:26 ` Lars Ingebrigtsen
2021-02-09 18:29 ` Stefan Monnier
2021-02-09 18:32 ` Lars Ingebrigtsen
2021-02-09 18:33 ` Lars Ingebrigtsen
2021-02-09 20:29 ` Stefan Monnier
2021-02-09 18:35 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn1alemu.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=22066@debbugs.gnu.org \
--cc=i@introo.me \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.