Re: Screenshots, frame shots straight from Emacs

[Leo Butler <leo.butler@umanitoba.ca>]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

Tomas Hlavaty <tom@logand.com> writes:

> this one works with plain console emacs:
> https://logand.com/sw/emacs-framebuffer/file/emacs-framebuffer.el.html#l755

Nice. I have not tried it yet, but I do notice that

https://logand.com/sw/emacs-framebuffer/file/emacs-framebuffer.el.html#l28

requires cl.

Also, when byte-compiling the file, I ran into 3 warnings which are easy
to correct (see attached). I still haven't got it working, but I think
that is due to user error.

Leo


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-patch, Size: 1337 bytes --]

diff --git a/emacs-framebuffer.el b/emacs-framebuffer.el
index ce9334e..e339a4f 100644
--- a/emacs-framebuffer.el
+++ b/emacs-framebuffer.el
@@ -25,7 +25,7 @@
 ;;; (require 'emacs-framebuffer)
 ;;; (framebuffer-install)
 
-(require 'cl)
+(require 'cl-lib)
 
 (defcustom framebuffer-w3mimgdisplay-program nil
   "Specify the path to w3mimgdisplay program."
@@ -201,6 +201,9 @@
       (framebuffer-file-exists-p "/usr/lib/w3m/w3mimgdisplay") ;; debian10
       "w3mimgdisplay"))
 
+(make-variable-buffer-local
+ (defvar framebuffer-image-mode-current-page))
+
 (defun framebuffer-draw (x y w h sx sy sw sh file)
   (setq file (framebuffer-cache-remote file))
   (let ((format (framebuffer-file-format file)))
@@ -465,8 +468,6 @@
  (defvar framebuffer-image-mode-image-size))
 (make-variable-buffer-local
  (defvar framebuffer-image-mode-npages))
-(make-variable-buffer-local
- (defvar framebuffer-image-mode-current-page))
 (make-variable-buffer-local
  (defvar framebuffer-image-mode-scale))
 (make-variable-buffer-local
@@ -663,7 +664,7 @@
     (integer
      (let* ((m (mod sec 3600))
 	    (s (mod m 60)))
-       (format "%d:%02d:%02d" (floor position 3600) (floor (- m s) 60) s)))))
+       (format "%d:%02d:%02d" (floor sec 3600) (floor (- m s) 60) s)))))
 
 (defun framebuffer-fbmpv (filename &optional position)
   (suspend-emacs