bug#49971: 28.0.50; indent-tabs-mode not working globally

bug#49971: 28.0.50; indent-tabs-mode not working globally

[Gabriel]

It seems that the new 'indent-tabs-mode' minor-mode, although defined as
global, it's working as a buffer-local minor-mode. Using emacs from
master branch built today:

1. emacs -Q
2. C-h v 'indent-tabs-mode' (value is t)
3. eval '(indent-tabs-mode -1)'
4. C-h v 'indent-tabs-mode' (local value is nil; global value is t)

bug#49971: 28.0.50; indent-tabs-mode not working globally

[Eli Zaretskii]

> From: Gabriel <gabriel376@hotmail.com>
> Date: Mon, 09 Aug 2021 18:15:46 -0300
> 
> It seems that the new 'indent-tabs-mode' minor-mode, although defined as
> global, it's working as a buffer-local minor-mode. Using emacs from
> master branch built today:
> 
> 1. emacs -Q
> 2. C-h v 'indent-tabs-mode' (value is t)
> 3. eval '(indent-tabs-mode -1)'
> 4. C-h v 'indent-tabs-mode' (local value is nil; global value is t)

Where did you see that it's "defined as global"?

bug#49971: 28.0.50; indent-tabs-mode not working globally

[Gabriel]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Gabriel <gabriel376@hotmail.com>
>> Date: Mon, 09 Aug 2021 18:15:46 -0300
>> 
>> It seems that the new 'indent-tabs-mode' minor-mode, although defined as
>> global, it's working as a buffer-local minor-mode. Using emacs from
>> master branch built today:
>> 
>> 1. emacs -Q
>> 2. C-h v 'indent-tabs-mode' (value is t)
>> 3. eval '(indent-tabs-mode -1)'
>> 4. C-h v 'indent-tabs-mode' (local value is nil; global value is t)
>
> Where did you see that it's "defined as global"?

On simple.el:

(define-minor-mode indent-tabs-mode
  "Toggle whether indentation can insert TAB characters."
  :global t :group 'indent :variable indent-tabs-mode)

bug#49971: 28.0.50; indent-tabs-mode not working globally

[Eli Zaretskii]

> From: Gabriel <gabriel376@hotmail.com>
> Date: Mon, 09 Aug 2021 23:33:37 -0300
> 
> >> 1. emacs -Q
> >> 2. C-h v 'indent-tabs-mode' (value is t)
> >> 3. eval '(indent-tabs-mode -1)'
> >> 4. C-h v 'indent-tabs-mode' (local value is nil; global value is t)
> >
> > Where did you see that it's "defined as global"?
> 
> On simple.el:
> 
> (define-minor-mode indent-tabs-mode
>   "Toggle whether indentation can insert TAB characters."
>   :global t :group 'indent :variable indent-tabs-mode)

That's the mode, but in your recipe you are looking at the variable,
not the mode.  And the documentation of the variable clearly says:

  Automatically becomes buffer-local when set.

bug#49971: 28.0.50; indent-tabs-mode not working globally

[Andreas Schwab]

On Aug 10 2021, Eli Zaretskii wrote:

>> From: Gabriel <gabriel376@hotmail.com>
>> Date: Mon, 09 Aug 2021 23:33:37 -0300
>> 
>> >> 1. emacs -Q
>> >> 2. C-h v 'indent-tabs-mode' (value is t)
>> >> 3. eval '(indent-tabs-mode -1)'
>> >> 4. C-h v 'indent-tabs-mode' (local value is nil; global value is t)
>> >
>> > Where did you see that it's "defined as global"?
>> 
>> On simple.el:
>> 
>> (define-minor-mode indent-tabs-mode
>>   "Toggle whether indentation can insert TAB characters."
>>   :global t :group 'indent :variable indent-tabs-mode)
>
> That's the mode, but in your recipe you are looking at the variable,
> not the mode.  And the documentation of the variable clearly says:
>
>   Automatically becomes buffer-local when set.

That's because it's explicitly made that way (bindings.el:799) despite
the :global declaration (which is about the _variable_ not the mode).

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

bug#49971: 28.0.50; indent-tabs-mode not working globally

[Eli Zaretskii]

> From: Andreas Schwab <schwab@linux-m68k.org>
> Cc: Gabriel <gabriel376@hotmail.com>,  49971@debbugs.gnu.org
> Date: Tue, 10 Aug 2021 14:08:19 +0200
> 
> On Aug 10 2021, Eli Zaretskii wrote:
> 
> >> (define-minor-mode indent-tabs-mode
> >>   "Toggle whether indentation can insert TAB characters."
> >>   :global t :group 'indent :variable indent-tabs-mode)
> >
> > That's the mode, but in your recipe you are looking at the variable,
> > not the mode.  And the documentation of the variable clearly says:
> >
> >   Automatically becomes buffer-local when set.
> 
> That's because it's explicitly made that way (bindings.el:799) despite
> the :global declaration (which is about the _variable_ not the mode).

Apologies.  But then I don't understand why we'd want this to be a
global minor mode.  Lars?

bug#49971: 28.0.50; indent-tabs-mode not working globally

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> That's because it's explicitly made that way (bindings.el:799) despite
>> the :global declaration (which is about the _variable_ not the mode).
>
> Apologies.  But then I don't understand why we'd want this to be a
> global minor mode.  Lars?

Uhm...  I think the :global t may be a mistake here -- I was just
following the suggestion in bug#6276 without thinking much about it.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#49971: 28.0.50; indent-tabs-mode not working globally

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Uhm...  I think the :global t may be a mistake here -- I was just
> following the suggestion in bug#6276 without thinking much about it.

I've now fixed this in Emacs 29.