From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#9923: 24.0.91; `where-is' does not find recentf menu items (cmds, not files) Date: Thu, 30 Sep 2021 09:55:21 +0300 Organization: LINKOV.NET Message-ID: <87pmsqeena.fsf@mail.linkov.net> References: <76FA3F83D086455EAA01FF0FB000FCDB@us.oracle.com> <871r6hk99k.fsf@gnus.org> <87bl5k2ug1.fsf@gnus.org> <87czpwb4gw.fsf@mail.linkov.net> <87y28kf5sn.fsf@gnus.org> <87r1ebz98c.fsf@mail.linkov.net> <875yvm8oqk.fsf@gnus.org> <87v93mazvm.fsf@mail.linkov.net> <875yvmj9ir.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26467"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 9923@debbugs.gnu.org, Lars Ingebrigtsen To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 30 09:03:55 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVq6k-0006fi-PD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Sep 2021 09:03:54 +0200 Original-Received: from localhost ([::1]:58602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVq6i-0007px-Uj for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Sep 2021 03:03:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVq53-0006JQ-61 for bug-gnu-emacs@gnu.org; Thu, 30 Sep 2021 03:02:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39716) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVq4w-0000QJ-UF for bug-gnu-emacs@gnu.org; Thu, 30 Sep 2021 03:02:08 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mVq4w-0001rk-Rx for bug-gnu-emacs@gnu.org; Thu, 30 Sep 2021 03:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Sep 2021 07:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9923 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 9923-submit@debbugs.gnu.org id=B9923.16329853177141 (code B ref 9923); Thu, 30 Sep 2021 07:02:02 +0000 Original-Received: (at 9923) by debbugs.gnu.org; 30 Sep 2021 07:01:57 +0000 Original-Received: from localhost ([127.0.0.1]:51258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVq4r-0001r6-CD for submit@debbugs.gnu.org; Thu, 30 Sep 2021 03:01:57 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:34055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVq4o-0001qn-Gt for 9923@debbugs.gnu.org; Thu, 30 Sep 2021 03:01:55 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 157A5C0003; Thu, 30 Sep 2021 07:01:45 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Tue, 31 Aug 2021 14:44:02 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215940 Archived-At: >>> @@ -1898,6 +1898,8 @@ help-fns--list-local-commands >>> (mapatoms >>> (lambda (sym) >>> (when (and (commandp sym) >>> + ;; Ignore errors in context-menu. >>> + (not (eq sym 'ignore)) >>> ;; Ignore aliases. >>> (not (symbolp (symbol-function sym))) >>> ;; Ignore everything bound. >>> >>> does it make sense to ignore 'ignore' like in this patch? >> >> I think so. Perhaps Stefan has some comments here? > > Not comments here, no, Recently clicking the context menu at the end of the buffer raises an error, and during the short time period before the problem was noticed and fixed, the error in one context menu item broke completion of M-x. It might surprise the users why an error in context menus affects such unrelated things. So maybe such patch makes sense to prevent M-x completion from breaking? diff --git a/lisp/simple.el b/lisp/simple.el index b0ff4236e1..5581d41356 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -2117,7 +2117,9 @@ read-extended-command--affixation (mapcar (lambda (command-name) (let* ((fun (and (stringp command-name) (intern-soft command-name))) - (binding (where-is-internal fun overriding-local-map t)) + (binding (unless (eq fun 'ignore) + ;; Ignore errors in context-menu. + (where-is-internal fun overriding-local-map t))) (obsolete (get fun 'byte-obsolete-info)) (alias (symbol-function fun)) (suffix (cond ((symbolp alias) --