From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#51293: 29.0.50; [PATCH] Avoid excessive specbinding in all-completions Date: Wed, 20 Oct 2021 10:21:06 +0200 Message-ID: <87pms0nm31.fsf@gnus.org> References: <871r4goex2.fsf@miha-pc> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6524"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51293@debbugs.gnu.org To: miha@kamnitnik.top Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 20 10:23:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1md6sk-0001WT-Gs for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Oct 2021 10:23:30 +0200 Original-Received: from localhost ([::1]:57224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1md6sj-0006u3-5m for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Oct 2021 04:23:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44270) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1md6rK-0005MC-96 for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 04:22:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41087) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1md6rJ-0004iM-U7 for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 04:22:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1md6rJ-0007Hr-Jz for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 04:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Oct 2021 08:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51293-submit@debbugs.gnu.org id=B51293.163471809327972 (code B ref 51293); Wed, 20 Oct 2021 08:22:01 +0000 Original-Received: (at 51293) by debbugs.gnu.org; 20 Oct 2021 08:21:33 +0000 Original-Received: from localhost ([127.0.0.1]:52633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1md6qq-0007H6-O2 for submit@debbugs.gnu.org; Wed, 20 Oct 2021 04:21:33 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:44588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1md6qa-0007GQ-2e for 51293@debbugs.gnu.org; Wed, 20 Oct 2021 04:21:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PY8TDndbVDJTBdzKZlyYQi69uJ6QVOrniJ3i67r/lpc=; b=tLyotzUzoWSWo1gDuI3OZLbrY4 u0bnvQivNezHI+PJnsSrMzTYlA8cSjOBOvnGksQvAtxmkddsEIyokHjpcSTw36jTdZ4K2VGl/KbyG npJ6a5go0EvPP/YUIS62l8Ft+rVsD/gv2pP/4J83hX8BcZh9qgUj1ZhPxMCPr9E78uhI=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1md6qQ-0005u0-If; Wed, 20 Oct 2021 10:21:09 +0200 X-Now-Playing: The Soft Pink Truth's _Am I Free To Go?_: "Cybergod (Nausea cover)" In-Reply-To: <871r4goex2.fsf@miha-pc> (miha@kamnitnik.top's message of "Tue, 19 Oct 2021 23:58:17 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217639 Archived-At: miha@kamnitnik.top writes: > (dotimes (i 300) > (get-buffer-create (format " *test-buffer-%s*" i))) > > (let ((completion-regexp-list '("\\`.*?"))) > (benchmark-run-compiled 50 > (all-completions "" obarray #'boundp))) > > 9.9 seconds without patch, > 0.83 seconds with patch applied. Impressive! I've tested your patch, and everything seems to work for me (and all tests pass). It also simplifies the code, so I've pushed this to Emacs 29 now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no