From: Lars Ingebrigtsen <larsi@gnus.org>
To: miha@kamnitnik.top
Cc: 51293@debbugs.gnu.org
Subject: bug#51293: 29.0.50; [PATCH] Avoid excessive specbinding in all-completions
Date: Wed, 20 Oct 2021 10:21:06 +0200 [thread overview]
Message-ID: <87pms0nm31.fsf@gnus.org> (raw)
In-Reply-To: <871r4goex2.fsf@miha-pc> (miha@kamnitnik.top's message of "Tue, 19 Oct 2021 23:58:17 +0200")
miha@kamnitnik.top writes:
> (dotimes (i 300)
> (get-buffer-create (format " *test-buffer-%s*" i)))
>
> (let ((completion-regexp-list '("\\`.*?")))
> (benchmark-run-compiled 50
> (all-completions "" obarray #'boundp)))
>
> 9.9 seconds without patch,
> 0.83 seconds with patch applied.
Impressive!
I've tested your patch, and everything seems to work for me (and all
tests pass). It also simplifies the code, so I've pushed this to Emacs
29 now.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2021-10-20 8:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 21:58 bug#51293: 29.0.50; [PATCH] Avoid excessive specbinding in all-completions miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-20 8:21 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pms0nm31.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=51293@debbugs.gnu.org \
--cc=miha@kamnitnik.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.