bug#52332: 29.0.50; Invisible button in the mode line

bug#52332: 29.0.50; Invisible button in the mode line

[Protesilaos Stavrou]

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

Dear maintainers,

With the current master if we launch an emacs -Q session we can use the
mouse pointer to find an invisible button to the left of the "All" word
on the mode line.

Its tooltip shows the same information as the actual "All" button.
Pressing on this invisible button provides a pop-up menu to toggle line
and column number display.

See attached screenshot.

Thank you,
Protesilaos

-- 
Protesilaos Stavrou
https://protesilaos.com

[-- Attachment #2: emacs-29-mode-line-invisible-button.png --]
[-- Type: image/png, Size: 41646 bytes --]

bug#52332: 29.0.50; Invisible button in the mode line

[Eli Zaretskii]

> From: Protesilaos Stavrou <info@protesilaos.com>
> Date: Mon, 06 Dec 2021 18:40:12 +0200
> 
> With the current master if we launch an emacs -Q session we can use the
> mouse pointer to find an invisible button to the left of the "All" word
> on the mode line.
> 
> Its tooltip shows the same information as the actual "All" button.
> Pressing on this invisible button provides a pop-up menu to toggle line
> and column number display.
> 
> See attached screenshot.

Thanks, should be fixed now.

bug#52332: 29.0.50; Invisible button in the mode line

[Protesilaos Stavrou]

On 2021-12-06, 19:11 +0200, Eli Zaretskii <eliz@gnu.org> wrote:

>> From: Protesilaos Stavrou <info@protesilaos.com>
>> Date: Mon, 06 Dec 2021 18:40:12 +0200
>> 
>> With the current master if we launch an emacs -Q session we can use the
>> mouse pointer to find an invisible button to the left of the "All" word
>> on the mode line.
>> 
>> Its tooltip shows the same information as the actual "All" button.
>> Pressing on this invisible button provides a pop-up menu to toggle line
>> and column number display.
>> 
>> See attached screenshot.
>
> Thanks, should be fixed now.

Can confirm.  Thank you!

-- 
Protesilaos Stavrou
https://protesilaos.com

bug#52332: 29.0.50; Invisible button in the mode line

[Eli Zaretskii]

> From: Protesilaos Stavrou <info@protesilaos.com>
> Cc: 52332@debbugs.gnu.org
> Date: Mon, 06 Dec 2021 20:10:40 +0200
> 
> On 2021-12-06, 19:11 +0200, Eli Zaretskii <eliz@gnu.org> wrote:
> 
> >> From: Protesilaos Stavrou <info@protesilaos.com>
> >> Date: Mon, 06 Dec 2021 18:40:12 +0200
> >> 
> >> With the current master if we launch an emacs -Q session we can use the
> >> mouse pointer to find an invisible button to the left of the "All" word
> >> on the mode line.
> >> 
> >> Its tooltip shows the same information as the actual "All" button.
> >> Pressing on this invisible button provides a pop-up menu to toggle line
> >> and column number display.
> >> 
> >> See attached screenshot.
> >
> > Thanks, should be fixed now.
> 
> Can confirm.  Thank you!

Wait with the thanks, it sounds like Lars wants that button back...

bug#52332: 29.0.50; Invisible button in the mode line

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> Wait with the thanks, it sounds like Lars wants that button back...

I've now fixed this in a different way in Emacs 29.  (But gnu.org is
still down, so it's not pushed yet.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#52332: 29.0.50; Invisible button in the mode line

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I've now fixed this in a different way in Emacs 29.  (But gnu.org is
> still down, so it's not pushed yet.)

Pushed now.

By the way, I wanted to mention -- while poking at this stuff, I noticed
that apparently the mode line is redisplayed multiple times when doing
some common things.

For instance, hitting page-down seems to render the mode line twice?
Mouse-clicking something also renders it twice.  Hm...  oh, it renders
once on mouse-down and once on mouse-up, so I guess that's OK.  So I
guess the only mysterious one is the page-down/page-up double render.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#52332: 29.0.50; Invisible button in the mode line

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: 52332@debbugs.gnu.org,  Protesilaos Stavrou <info@protesilaos.com>
> Date: Tue, 21 Dec 2021 06:32:23 +0100
> 
> By the way, I wanted to mention -- while poking at this stuff, I noticed
> that apparently the mode line is redisplayed multiple times when doing
> some common things.
> 
> For instance, hitting page-down seems to render the mode line twice?
> Mouse-clicking something also renders it twice.  Hm...  oh, it renders
> once on mouse-down and once on mouse-up, so I guess that's OK.  So I
> guess the only mysterious one is the page-down/page-up double render.

This is normal.  Scrolling commands first see if point is inside the
window, and that requires redisplay of the mode line (because its
spec could have changed in the meanwhile).  Then the scrolling
commands determine the appropriate window-start point, and then
redisplay kicks in with the second update of the mode line.