Re: emacs-28 edb1d49: * lisp/net/shr.el (shr-expand-url): Also strip trailing

Re: emacs-28 edb1d49: * lisp/net/shr.el (shr-expand-url): Also strip trailing

[Stefan Kangas]

schwab@gnu.org (Andreas Schwab) writes:

> -  ;; Strip leading whitespace
> +  ;; Strip leading/trailing whitespace
>    (and url (string-match "\\`\\s-+" url)
>         (setq url (substring url (match-end 0))))
> +  (and url (string-match "\\s-+\\'" url)
> +       (setq url (substring url 0 (match-beginning 0))))

This could be simplified to:

    (setq url (string-trim url))

Re: emacs-28 edb1d49: * lisp/net/shr.el (shr-expand-url): Also strip trailing

[Lars Ingebrigtsen]

Stefan Kangas <stefankangas@gmail.com> writes:

> schwab@gnu.org (Andreas Schwab) writes:
>
>> -  ;; Strip leading whitespace
>> +  ;; Strip leading/trailing whitespace
>>    (and url (string-match "\\`\\s-+" url)
>>         (setq url (substring url (match-end 0))))
>> +  (and url (string-match "\\s-+\\'" url)
>> +       (setq url (substring url 0 (match-beginning 0))))
>
> This could be simplified to:
>
>     (setq url (string-trim url))

And I'm not sure about the logic -- even stripping the leading spaces
seems dubious.  The function is supposed to perform expansion of URL
(which may be a fragment) to BASE, and it's not supposed to do any DWIM
stuff.

What's the use case for stripping spaces?  (Which are valid enough
characters in URLs in some (pre-encoding) cases.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: emacs-28 edb1d49: * lisp/net/shr.el (shr-expand-url): Also strip trailing

[Andreas Schwab]

On Dez 23 2021, Lars Ingebrigtsen wrote:

> What's the use case for stripping spaces?

https://www.der-postillon.com/2021/12/senfflecken-2021.html

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Re: emacs-28 edb1d49: * lisp/net/shr.el (shr-expand-url): Also strip trailing

[Lars Ingebrigtsen]

Andreas Schwab <schwab@gnu.org> writes:

>> What's the use case for stripping spaces?
>
> https://www.der-postillon.com/2021/12/senfflecken-2021.html

Ah, it's when the URL isn't relative.  Well, I guess that's what other
browsers do in this case, so we should, too.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no