From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ivan Sokolov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add history to Custom commands Date: Fri, 21 Jan 2022 13:21:58 +0300 Message-ID: <87pmoljsmx.fsf@ya.ru> References: <87y23ajafr.fsf@ya.ru> <87mtjpv2bp.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16100"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 21 11:37:31 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nArIQ-0003zU-D2 for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Jan 2022 11:37:30 +0100 Original-Received: from localhost ([::1]:53312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nArIP-0003yV-9M for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Jan 2022 05:37:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAr3c-0002ea-US for emacs-devel@gnu.org; Fri, 21 Jan 2022 05:22:17 -0500 Original-Received: from forward500o.mail.yandex.net ([37.140.190.195]:34568) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAr3Z-0004Sz-4z for emacs-devel@gnu.org; Fri, 21 Jan 2022 05:22:11 -0500 Original-Received: from iva6-f3088a0362c9.qloud-c.yandex.net (iva6-f3088a0362c9.qloud-c.yandex.net [IPv6:2a02:6b8:c0c:6105:0:640:f308:8a03]) by forward500o.mail.yandex.net (Yandex) with ESMTP id 808A1941FAF; Fri, 21 Jan 2022 13:22:00 +0300 (MSK) Original-Received: from iva6-2d18925256a6.qloud-c.yandex.net (iva6-2d18925256a6.qloud-c.yandex.net [2a02:6b8:c0c:7594:0:640:2d18:9252]) by iva6-f3088a0362c9.qloud-c.yandex.net (mxback/Yandex) with ESMTP id anB2ZmETNv-M0GqORuo; Fri, 21 Jan 2022 13:22:00 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ya.ru; s=mail; t=1642760520; bh=EvHnToL5EjAzdTxUgqt211PET5vR7UwSXyBUYuY+MX0=; h=In-Reply-To:Subject:Date:References:To:From:Message-ID:Cc; b=PnxQTGOEYFgU1xMAgUJ2pSJyLhkB7qytouis3c/rnVAT5aSsIPLuWUlN/JQAcW13x B/PmYSHtDraEEP7vd8Hrgj54urpEIzSY4n30q5JnGEw/Lu+4aM/9ZQ5/AEqPZa6VMs BCN6JjnhvWxJKTAJYplQUQKRyR8R65IZh/zajepM= Authentication-Results: iva6-f3088a0362c9.qloud-c.yandex.net; dkim=pass header.i=@ya.ru Original-Received: by iva6-2d18925256a6.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id vInbZXbH5N-LxPeik02; Fri, 21 Jan 2022 13:21:59 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-Yandex-Fwd: 2 In-Reply-To: <87mtjpv2bp.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 21 Jan 2022 10:57:14 +0100") Received-SPF: pass client-ip=37.140.190.195; envelope-from=ivan-p-sokolov@ya.ru; helo=forward500o.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285112 Archived-At: Lars Ingebrigtsen writes: > I'm not sure whether it makes sense to have separate histories for these > commands -- it's nice if you're expected to customise the same things > several times, but not if you have the things in the general history. Maybe I was too hasty with this patch. I was using customize-variable instead of revert-buffer, which is unavailable for Custom buffers, and some other commands without dedicated history variables. All of the above has led to massive abuse of M-p.