From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?I=C3=B1igo?= Serna Newsgroups: gmane.emacs.devel Subject: Compilation of master with pgtk and xwidgets is broken since commit 16c785b621 Date: Sat, 22 Jan 2022 12:57:27 +0100 Message-ID: <87pmokc6gs.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27523"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.6.10; emacs 29.0.50 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 22 13:16:03 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nBFJL-000723-7G for ged-emacs-devel@m.gmane-mx.org; Sat, 22 Jan 2022 13:16:03 +0100 Original-Received: from localhost ([::1]:55338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nBFJK-0006R6-AG for ged-emacs-devel@m.gmane-mx.org; Sat, 22 Jan 2022 07:16:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBFIP-0005kC-RU for emacs-devel@gnu.org; Sat, 22 Jan 2022 07:15:05 -0500 Original-Received: from [2a00:1450:4864:20::434] (port=34312 helo=mail-wr1-x434.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nBFIN-0005Cb-Mh for emacs-devel@gnu.org; Sat, 22 Jan 2022 07:15:05 -0500 Original-Received: by mail-wr1-x434.google.com with SMTP id f17so4661596wrx.1 for ; Sat, 22 Jan 2022 04:15:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=user-agent:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=ILtoyYAS+McRPsa0jG/hJzdFl622QrRT3FLHfyvahcw=; b=NTHC+Ytw4C74yLIUnDXdvoobh/E5ZCrdBR8SVMY0zQhPv/DUFD0A2X+F/e8tpFnCtv TH2+amPHzDgubQZjOoLyFhmXjyJcnefSbyslwPejSWSbTBHoN78F1jGF/2mU24nDIL9C i7+bTFedOYlbfLCT2LoMAs3tibI8SYHsAUouR4uTZqui2KbgWUk6Xf9LcGovDkQBnhf3 1VxJ+AYGyoquj6/ELPE9jB/Z+ZSl/UyRel3jWcSw3nq7289HSML0xov/XPL/uvCwW0xZ 9mO5qmv5O/Nv37gGmFXY0zzCx3HNMgjCvk4oTst606UHp9wCYSDDq2l8SSVc2sT9U7Tm 10Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version:content-transfer-encoding; bh=ILtoyYAS+McRPsa0jG/hJzdFl622QrRT3FLHfyvahcw=; b=TEXr6bo0R3lhdV+HvI//uM0Oh/s1DH9hsrveH9R4EaIumwtCjd4v3gtLjRb31WfOJg VFuptsAVf1ESI6nVTHQavGh5hDESiZTAHxy3oQxtfrIkWhFQR0qPRLswz3XTPYGfpGsb 1QYXgKAdMshM1EhNXRipFY2ZAkShoLgIBqhA4Lxri+dOxLHDvFJ+Wo0cDcjg9AX+FYnq d0MA/X0NKor6mbR+PIufpeQhvA26GWwbKrNch280/LSj6gUGzJWqRJIMqhx0Iz9RaYuy N0saIleZ7pPqUcLWcvPN280ZQuesl2Y6AYcyQkBwoh6KJzzqMguDbMLQBAL0gJuvNlXP VMpQ== X-Gm-Message-State: AOAM531bbVKdQrsGNO9x10CN6qnOy5EHR6qVuIYhGqsv+DN+9WGs8ad/ 0l1AqAl6Cof3wih/qaexLk9ll9w= X-Google-Smtp-Source: ABdhPJziY1nG6KxIZoTwycd5TzbYt3+f66+QvAMn8tWapG9nlrxYuOwy3sZEN6e2ZWjRbN8m79fO0A== X-Received: by 2002:a5d:4c45:: with SMTP id n5mr7330828wrt.141.1642853701729; Sat, 22 Jan 2022 04:15:01 -0800 (PST) Original-Received: from zeus.gmail.com (244.red-79-153-222.dynamicip.rima-tde.net. [79.153.222.244]) by smtp.gmail.com with ESMTPSA id u15sm3124073wrn.48.2022.01.22.04.15.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jan 2022 04:15:01 -0800 (PST) X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::434 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=inigoserna@gmail.com; helo=mail-wr1-x434.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285203 Archived-At: Hi, Compilation of master with pgtk and xwidgets is broken since=20 commit 16c785b621. I added the error at the end of the email. I simple fix is to move "#include " in file=20 src/xwidget.c line 42 one line below, inside #ifndef HAVE_PGTK. Thanks, --=20 I=C3=B1igo Serna ``` make[1]: Entering directory=20 '/home/_compiling/linux/devel/emacs.git/src' CC xwidget.o In file included from /usr/include/X11/Xlib.h:44, from /usr/include/cairo/cairo-xlib.h:44, from xwidget.c:42: /usr/include/X11/X.h:96:13: error: conflicting types for =E2=80=98Window=E2= =80=99;=20 have =E2=80=98XID=E2=80=99 {aka =E2=80=98long unsigned int=E2=80=99} 96 | typedef XID Window; | ^~~~~~ In file included from dispextern.h:133, from composite.h:29, from coding.h:284, from xwidget.c:23: pgtkgui.h:49:13: note: previous declaration of =E2=80=98Window=E2=80=99 wit= h type=20 =E2=80=98Window=E2=80=99 {aka =E2=80=98int=E2=80=99} 49 | typedef int Window; | ^~~~~~ In file included from /usr/include/cairo/cairo-xlib.h:44, from xwidget.c:42: /usr/include/X11/Xlib.h:433:3: error: conflicting types for=20 =E2=80=98XRectangle=E2=80=99; have =E2=80=98struct =E2=80=99 433 | } XRectangle; | ^~~~~~~~~~ In file included from dispextern.h:133, from composite.h:29, from coding.h:284, from xwidget.c:23: pgtkgui.h:62:3: note: previous declaration of =E2=80=98XRectangle=E2=80=99 = with=20 type =E2=80=98XRectangle=E2=80=99 62 | } XRectangle; | ^~~~~~~~~~ In file included from /usr/include/cairo/cairo-xlib.h:44, from xwidget.c:42: /usr/include/X11/Xlib.h:487:26: error: conflicting types for=20 =E2=80=98Display=E2=80=99; have =E2=80=98struct _XDisplay=E2=80=99 487 | typedef struct _XDisplay Display; | ^~~~~~~ In file included from dispextern.h:133, from composite.h:29, from coding.h:284, from xwidget.c:23: pgtkgui.h:50:28: note: previous declaration of =E2=80=98Display=E2=80=99 wi= th type=20 =E2=80=98Display=E2=80=99 {aka =E2=80=98struct _GdkDisplay=E2=80=99} 50 | typedef struct _GdkDisplay Display; | ^~~~~~~ In file included from /usr/include/cairo/cairo-xlib.h:44, from xwidget.c:42: /usr/include/X11/Xlib.h:1024:3: error: conflicting types for=20 =E2=80=98XCharStruct=E2=80=99; have =E2=80=98struct =E2=80=99 1024 | } XCharStruct; | ^~~~~~~~~~~ In file included from dispextern.h:133, from composite.h:29, from coding.h:284, from xwidget.c:23: pgtkgui.h:30:3: note: previous declaration of =E2=80=98XCharStruct=E2=80=99= with=20 type =E2=80=98XCharStruct=E2=80=99 {aka =E2=80=98struct _XCharStruct=E2=80= =99} 30 | } XCharStruct; | ^~~~~~~~~~~ In file included from /usr/include/cairo/cairo-xlib.h:44, from xwidget.c:42: /usr/include/X11/Xlib.h:1067:3: error: conflicting types for=20 =E2=80=98XChar2b=E2=80=99; have =E2=80=98struct =E2=80=99 1067 | } XChar2b; | ^~~~~~~ In file included from dispextern.h:133, from composite.h:29, from coding.h:284, from xwidget.c:23: pgtkgui.h:34:17: note: previous declaration of =E2=80=98XChar2b=E2=80=99 wi= th type=20 =E2=80=98XChar2b=E2=80=99 {aka =E2=80=98short unsigned int=E2=80=99} 34 | typedef unichar XChar2b; | ^~~~~~~ make[1]: *** [Makefile:411: xwidget.o] Error 1 make[1]: Leaving directory=20 '/home/_compiling/linux/devel/emacs.git/src' make: *** [Makefile:469: src] Error 2 ```