Re: master f62a6acd00: Better handle drag-and-drop from one Emacs frame to another

Re: master f62a6acd00: Better handle drag-and-drop from one Emacs frame to another

[Lars Ingebrigtsen]

One of these changes apparently leads to this warning:

xterm.c: In function 'handle_one_xevent':
xterm.c:959:29: warning: 'target_proto' may be used uninitialized in this function [-Wmaybe-uninitialized]
  959 |   msg.xclient.data.l[1] = (((unsigned int) min (X_DND_SUPPORTED_VERSION,
xterm.c:11653:17: note: 'target_proto' was declared here
11653 |             int target_proto;
      |                 ^~~~~~~~~~~~

On Debian/bookworm.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master f62a6acd00: Better handle drag-and-drop from one Emacs frame to another

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> One of these changes apparently leads to this warning:
>
> xterm.c: In function 'handle_one_xevent':
> xterm.c:959:29: warning: 'target_proto' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   959 |   msg.xclient.data.l[1] = (((unsigned int) min (X_DND_SUPPORTED_VERSION,
> xterm.c:11653:17: note: 'target_proto' was declared here
> 11653 |             int target_proto;
>       |                 ^~~~~~~~~~~~
>
> On Debian/bookworm.

diff --git a/src/xterm.c b/src/xterm.c
index 7d1a5f4043..46a22d8dc1 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -866,6 +866,7 @@ x_dnd_get_target_window (struct x_display_info *dpyinfo,
 	  if (x_had_errors_p (dpyinfo->display) || !rc)
 	    {
 	      x_uncatch_errors_after_check ();
+	      *proto_out = -1;
 	      return None;
 	    }
 	}

Does this help?

Thanks.

Re: master f62a6acd00: Better handle drag-and-drop from one Emacs frame to another

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> Does this help?

Yup.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master f62a6acd00: Better handle drag-and-drop from one Emacs frame to another

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Yup.

Thanks, installed.

Re: master f62a6acd00: Better handle drag-and-drop from one Emacs frame to another

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Wed, 16 Mar 2022 12:16:58 +0100
> Cc: Po Lu <luangruo@yahoo.com>
> 
> One of these changes apparently leads to this warning:
> 
> xterm.c: In function 'handle_one_xevent':
> xterm.c:959:29: warning: 'target_proto' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   959 |   msg.xclient.data.l[1] = (((unsigned int) min (X_DND_SUPPORTED_VERSION,
> xterm.c:11653:17: note: 'target_proto' was declared here
> 11653 |             int target_proto;
>       |                 ^~~~~~~~~~~~
> 
> On Debian/bookworm.

Looks to me like a compiler bug, because AFAICT this variable _is_
initialized before it is used.

Re: master f62a6acd00: Better handle drag-and-drop from one Emacs frame to another

[Eli Zaretskii]

> Date: Wed, 16 Mar 2022 14:20:32 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: luangruo@yahoo.com, emacs-devel@gnu.org
> 
> > From: Lars Ingebrigtsen <larsi@gnus.org>
> > Date: Wed, 16 Mar 2022 12:16:58 +0100
> > Cc: Po Lu <luangruo@yahoo.com>
> > 
> > One of these changes apparently leads to this warning:
> > 
> > xterm.c: In function 'handle_one_xevent':
> > xterm.c:959:29: warning: 'target_proto' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >   959 |   msg.xclient.data.l[1] = (((unsigned int) min (X_DND_SUPPORTED_VERSION,
> > xterm.c:11653:17: note: 'target_proto' was declared here
> > 11653 |             int target_proto;
> >       |                 ^~~~~~~~~~~~
> > 
> > On Debian/bookworm.
> 
> Looks to me like a compiler bug, because AFAICT this variable _is_
> initialized before it is used.

Ignore me, I was looking at a fixed source file.