From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] propose to add vundo.el to ELPA Date: Fri, 15 Apr 2022 14:25:01 +0000 Message-ID: <87pmlibf0i.fsf@posteo.net> References: <15F35A7C-7A15-4B1E-8959-612C10166242@gmail.com> <87wng4vvqx.fsf@posteo.net> <926B937B-C456-4CA6-9EA9-33BA1A4CA79F@gmail.com> <878rsitt7c.fsf@posteo.net> <489553CD-96EC-489C-9445-6147BBD1D63F@gmail.com> <87k0c2rrfb.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5176"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs developers To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 15 16:26:24 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nfMtz-0001Bd-Rv for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Apr 2022 16:26:23 +0200 Original-Received: from localhost ([::1]:55214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nfMty-0003sP-9S for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Apr 2022 10:26:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfMsm-00036l-GI for emacs-devel@gnu.org; Fri, 15 Apr 2022 10:25:08 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:38347) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfMsk-0001v5-8M for emacs-devel@gnu.org; Fri, 15 Apr 2022 10:25:08 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A37EE240107 for ; Fri, 15 Apr 2022 16:25:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1650032703; bh=NsIxAj4NLZT6uKajv56b4rheT8tkeBiRfz5m2AUq8W0=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=eOvuaWhnbKwQpDKeM6iFT4beiGAWcagumk0Ee4pZ93GxVhvHeQLttv2C35TvAwwRK d3H87gjuFxFoTfD5Oe6wsaJtXvTm9Zc5ekXtBDT1PEgNQPtzaTaBxPFsVhxBjJ1OXJ oSunQZy92q6+a42gUHaYyYX4gEbMNf1s8mqEFQUzxxsfdJ66lHWMxC94WgXzuvOjys 7PhJli9i66H+9QuDIb0kAH28xD4cVsY8NFwHFJkZGCldztNaYMTY6GCRNLF02fVqRm huUwFr8K8DjqnoQDXgWG6Ud7HIZL42x8vBt2Sad7/AR/BbEKEsqbUZGhj6SYkuXBwj 7BpyeFho9G3Pw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4KfzB65Ztyz6tmg; Fri, 15 Apr 2022 16:25:02 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <87k0c2rrfb.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 06 Apr 2022 18:35:20 +0000") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288441 Archived-At: I would then want to add vundo to ELPA, unless there are any objections? Philip Kaludercic writes: > Yuan Fu writes: > >>>> >>>> diff --git a/elpa-packages b/elpa-packages >>>> index e218968e87..8fb17c4baf 100644 >>>> --- a/elpa-packages >>>> +++ b/elpa-packages >>>> @@ -630,6 +630,12 @@ >>>> ("vertico-posframe" >>>> :url "https://github.com/tumashu/vertico-posframe" >>>> :auto-sync t) >>>> + ("vundo" >>>> + :url "https://github.com/casouri/vundo" >>>> + :ignored-files ("test") >>>> + :doc "README.txt" >>> ^ >>> I am assuming this is supposed to be a :readme, not a :doc. >>> Or do you actually want to create a manual out of the README? >> >> That should be README. > > Ok. > >>> As your commentary section seems to intentionally mirror the >>> README (if this is the right thing is a different question. I >>> don't know why a package.el user is interested in testing if the >>> testing code isn't bundled in the package), this could just be >>> dropped. >> >> Should I let ELPA ignore README.txt and only use Commentary then? > > Sure that can be done. I personally like this approach because a README > in my eyes is what a contributor is interested in while the commentary > section is what a package user wants to know. > >>> >>>> + :news "NEWS.txt" >>> >>> I see that your README also contains a news section. It might make >>> sense only maintain the news in one of the two, to avoid duplication on >>> elpa.gnu.org. >>> >>> Besides that, it seems to be that the introduction in README.txt doesn't >>> immediately explain what the package is about. This might confuse >>> people using C-h P to preview the package before installing it. >> >> Thanks. I fixed those points and here is the new patch. In this patch >> I removed README.txt. If it turns out to be not desirable, I can make >> another patch. > > Looks good. BTW, you can also add a .elpaignore file to your repository > if you want to maintain what files to ignore on your end. -- Philip Kaludercic