EWW func add url under point as bookmark

EWW func add url under point as bookmark

[Alex]

When Im reading mails, or when Im in IRC or browsing pages with EWW,
sometimes I get an interesting url, then I want save it as eww bookmark
to read it in other moment.

I was searching a function that add a bookmark from the url under cursor
(point), but there aren't some like it.

I want write a func for it, so I was searching a func that add a
bookmark from a string.

Ex:
(defun eww-add-bookmark (&optional str)
      "Bookmark the current page or string"
         ...)

But `eww-add-bookmark' dont support arguments

Any help?

RE: [External] : EWW func add url under point as bookmark

[Drew Adams]

> When Im reading mails, or when Im in IRC or browsing pages with EWW,
> sometimes I get an interesting url, then I want save it as eww bookmark
> to read it in other moment.
> 
> I was searching a function that add a bookmark from the url under
> cursor (point), but there aren't some like it.

I can't speak for EWW (so-called) "bookmarks".

But if you want a regular, real, good-old Emacs
bookmark to a URL at point then that's available
out of the box with Bookmark+.

`bmkp-url-target-set' prompts for a URL, with
the URL at point as the default.

It works anywhere, including when in EWW or W3M.
___

If you don't want to be prompted for a URL and
thus have to hit RET to accept the URL at point,
you can write a simple wrapper command for
`bmkp-url-target-set' that just uses a URL at
point or does nothing (or raises an error) if
there's no URL at point.  You can likewise
choose a bookmark name automatically (e.g. the
URL or page title).
___

https://www.emacswiki.org/emacs/BookmarkPlus#BookmarkingFileOrUrl

Re: EWW func add url under point as bookmark

[Emanuel Berg via Users list for the GNU Emacs text editor]

Alex wrote:

> When Im reading mails, or when Im in IRC or browsing pages
> with EWW, sometimes I get an interesting url, then I want
> save it as eww bookmark to read it in other moment.
>
> I was searching a function that add a bookmark from the url
> under cursor (point), but there aren't some like it.
>
> I want write a func for it, so I was searching a func that
> add a bookmark from a string [...]
>
> But `eww-add-bookmark' dont support arguments

Check out these for inspiration and code that you can adapt:

  https://dataswamp.org/~incal/emacs-init/w3m/w3m-url.el

  https://dataswamp.org/~incal/emacs-init/w3m/w3m-bookmark-more.el

-- 
underground experts united
https://dataswamp.org/~incal

Re: [External] : EWW func add url under point as bookmark

[Michael Heerdegen]

Drew Adams <drew.adams@oracle.com> writes:

> But if you want a regular, real, good-old Emacs
> bookmark to a URL at point then that's available
> out of the box with Bookmark+.
>
> `bmkp-url-target-set' prompts for a URL, with
> the URL at point as the default.
>
> It works anywhere, including when in EWW or W3M.

"Good-old Emacs bookmark" support also has been added to eww recently.
You can check: An eww version supports standard bookmarks when
`bookmark-make-record-function' is bound to `eww-bookmark-make-record'
in any eww buffer.

But the url can't be changed when using `bookmark-set' (C-x r m), it's
always the current page's url.  Would be easy change that, though.

Michael.

Re: EWW func add url under point as bookmark

[Alex]

Yay! I get it!

#+begin_src elisp
;; Copyright 2022 Alex
;; Under GPLv3-or-later License

(defun eww-bookmark-add (url title)
  "Bookmark url with a title."
  (unless (stringp url)
    (user-error "invalid url string required"))
  (unless (stringp title)
    (user-error "invalid title string required"))
  (eww-read-bookmarks)
  (dolist (bookmark eww-bookmarks)
    (when (equal url (plist-get bookmark :url))
      (user-error "Already bookmarked")))
  (push (list :url url
	      :title title
	      :time (current-time-string))
	eww-bookmarks)
  (eww-write-bookmarks)
  (message "Bookmarked %s (%s)" url title))

(defun eww-bookmark-url-under-point (title)
  "Bookmark url under point"
  (interactive (list (read-string "Bookmark title: ")))
  (let ((str-url (thing-at-point 'url)))
    (eww-bookmark-add str-url title)))

;; test here:
;; cursor on url and M-x eww-bookmark-url-under-point RET
;; http://www.gnuhacker.org

#+end_src

-- 
Alex
Emacs Lover.
FSF Member.
Free/Libre Software supporter.
stallmansupport.org - Disinformation succeeds because so many people
care deeply about injustice but do not take the time to check the facts.

Re: EWW func add url under point as bookmark

[Emanuel Berg via Users list for the GNU Emacs text editor]

Alex wrote:

> (defun eww-bookmark-add (url title)
>   "Bookmark url with a title."

"... URL with a TITLE."

> (defun eww-bookmark-url-under-point (title)
>   "Bookmark url under point"

"... calling it TITLE"?

>   (interactive (list (read-string "Bookmark title: ")))

(interactive "sTitle: ")

>   (let ((str-url (thing-at-point 'url)))
>     (eww-bookmark-add str-url title)))

Maybe should check if `thing-at-point' found anything ...

-- 
underground experts united
https://dataswamp.org/~incal

Re: EWW func add url under point as bookmark

[Alex]

Emanuel Berg writes:
> Alex wrote:

> (interactive "sTitle: ")

right

>>   (let ((str-url (thing-at-point 'url)))
>>     (eww-bookmark-add str-url title)))

> Maybe should check if `thing-at-point' found anything ...

Already checked in func `eww-bookmark-add'

  (unless (stringp url)
    (user-error "invalid url string required"))


new simplified version:

#+begin_src elisp

(defun eww-bookmark-url-under-point (title)
  "Bookmark url under point calling it TITLE"
  (interactive "sTitle: ")
  (eww-bookmark-add (thing-at-point 'url) title))
  
#+end_src

-- 
Alex
Emacs Lover.
FSF Member.
Free/Libre Software supporter.
stallmansupport.org - Disinformation succeeds because so many people
care deeply about injustice but do not take the time to check the facts.

Re: EWW func add url under point as bookmark

[Emanuel Berg via Users list for the GNU Emacs text editor]

Alex wrote:

> (defun eww-bookmark-url-under-point (title)
>   "Bookmark url under point calling it TITLE"

Emacs thinks:

  First sentence should end with punctuation

(look who's talking LOL)

>>> (interactive "sTitle: ")
>>> (eww-bookmark-add (thing-at-point 'url) title))
>>
>> Maybe should check if `thing-at-point' found anything ...
>
> Already checked in func `eww-bookmark-add'

OK, good, but then better yet you could remove the
interface/wrapper function and instead make eww-bookmark-add
interactive (as well as non-interactive from Lisp), and for
interactive use it'll read the URL from point.

Ironically then you have to get the title the way you
initially did!

-- 
underground experts united
https://dataswamp.org/~incal

Re: EWW func add url under point as bookmark

[Emanuel Berg via Users list for the GNU Emacs text editor]

Here you go,

(defun eww-bookmark-add (url title)
  "Bookmark URL as TITLE."
  (interactive (list (thing-at-point 'url)
                     (read-string "Title: ") ))
  (when (and url title)
    (message "add %s as %s" url title) ))

;; tests:
;;
;; (eww-bookmark-add "https://dataswamp.org/~incal" "Pretty good site")
;;
;; (call-interactively #'eww-bookmark-add)https://dataswamp.org/~incal
;;                                        ^ eval here

-- 
underground experts united
https://dataswamp.org/~incal

[emacs-w3m:13862] Re: EWW func add url under point as bookmark

[Emanuel Berg]

Samuel Wales wrote:

> which is an intriguing idea if you could get all text and
> gui browsers to cooperate and go in both directions.

Indeed, that's the way you do it: unify the data format, while
diversifying the clients!

But hang on, it gets better! Because the clients are already
diversed, so no work there is needed ...

... and as for the universal data structure - capable of
holding any data arrangement theoretically conceivable in the
known and unknown multiverse - ...

You guessed it! Very much so indeed, we already have it!

It's the list :D <3

-- 
underground experts united
https://dataswamp.org/~incal

Re: EWW func add url under point as bookmark

[Alex]

Emanuel Berg via Users list for the GNU Emacs text editor
<help-gnu-emacs@gnu.org> writes:

> OK, good, but then better yet you could remove the interface/wrapper
> function and instead make eww-bookmark-add interactive (as well as
> non-interactive from Lisp), and for interactive use it'll read the URL
> from point.

new version:

#+begin_src elisp

;; Copyright 2022 Alex
;; under GPLv3-or-later License

(defun eww-bookmark-add (url title)
  "Bookmark `URL' as `TITLE'."
  (interactive (list (thing-at-point 'url)
		     (read-string "Title: ")))
  (unless (stringp url)
    (user-error "invalid url string required"))
  (unless (stringp title)
    (user-error "invalid title string required"))
  (eww-read-bookmarks)
  (dolist (bookmark eww-bookmarks)
    (when (equal url (plist-get bookmark :url))
      (user-error "Already bookmarked")))
  (push (list :url url
	      :title title
	      :time (current-time-string))
	eww-bookmarks)
  (eww-write-bookmarks)
  (message "Bookmarked %s (%s)" url title))

#+end_src

> Ironically then you have to get the title the way you initially did!

right lol

-- 
Alex
Emacs Lover.
FSF Member.
Free/Libre Software supporter.
stallmansupport.org - Disinformation succeeds because so many people
care deeply about injustice but do not take the time to check the facts.

Re: EWW func add url under point as bookmark

[Emanuel Berg via Users list for the GNU Emacs text editor]

Alex wrote:

> (defun eww-bookmark-add (url title)
>   "Bookmark `URL' as `TITLE'."

Just URL and TITLE is fine otherwise it looks like they are
part of Emacs.

>   (interactive (list (thing-at-point 'url)
> 		     (read-string "Title: ")))
>   (unless (stringp url)
>     (user-error "invalid url string required"))
>   (unless (stringp title)
>     (user-error "invalid title string required"))
>   (eww-read-bookmarks)

From the `user-error' docstring:

  In Emacs, the convention is that error messages start with
  a capital letter but *do not* end with a period.

>> Ironically then you have to get the title the way you
>> initially did!
>
> right lol

:)

-- 
underground experts united
https://dataswamp.org/~incal

Re: EWW func add url under point as bookmark

[Alex]

Emanuel Berg via Users list for the GNU Emacs text editor
<help-gnu-emacs@gnu.org> writes:

> Just URL and TITLE is fine otherwise it looks like they are part of
> Emacs.

>   In Emacs, the convention is that error messages start with a capital
>   letter but *do not* end with a period.

fixed, thanks

PD: nice website Emanuel



Ok, now, Im browsing in EWW, and Im in a page with many interesting
urls, I want bookmarks all urls after point.

But moving the cursor, M-x eww-bookmark-add RET <title> RET with all
urls is painfull.

I need a func!

#+begin_src elisp

;; Copyright 2022 Alex
;; under GPLv3-or-later License

(defun eww-bookmark-buffer-urls ()
  "Bookmark urls in current buffer"
  (interactive)
  (shr-next-link)
  (let ((url-str (thing-at-point 'url)))
    (eww-bookmark-add url-str url-str))
  (if (save-excursion (shr-next-link))
      (eww-bookmark-buffer-urls)))

#+end_src

Works, but sadly stop when find an url already bookmarked :/

Re: EWW func add url under point as bookmark

[Emanuel Berg via Users list for the GNU Emacs text editor]

Alex wrote:

> PD: nice website Emanuel

PD? thanks :)

> Ok, now, Im browsing in EWW, and Im in a page with many
> interesting urls, I want bookmarks all urls after point.

Uhm, when you say URL, you mean hyperlink?

> But moving the cursor, M-x eww-bookmark-add RET <title> RET
> with all urls is painfull.
>
> I need a func!
>
> #+begin_src elisp
>
> ;; Copyright 2022 Alex
> ;; under GPLv3-or-later License
>
> (defun eww-bookmark-buffer-urls ()
>   "Bookmark urls in current buffer"

That's (to the) right, period.

>   (interactive)
>   (shr-next-link)
>   (let ((url-str (thing-at-point 'url)))

I still think it better to check for nil here.

>   (if (save-excursion (shr-next-link))
>       (eww-bookmark-buffer-urls)))

Hm, that's look sa bit weird ... instead drop recursion and
when you find what you are looking for, just get it and
go on. (Should be `when' BTW as it stands.)

> Works, but sadly stop when find an url already bookmarked :/

Sadly, you checked this in the other code and it is signalled
as an error if it happens, sounds like overkill indeed..

-- 
underground experts united
https://dataswamp.org/~incal