From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 4fb028be6c 3/3: Fix releasing the mouse on top of the tool bar on MS Windows Date: Sat, 30 Apr 2022 15:50:53 +0800 Message-ID: <87pmkzt3fm.fsf@yahoo.com> References: <831qxf9h1p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="645"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 30 09:52:19 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nkhtq-000AYx-Ey for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Apr 2022 09:52:18 +0200 Original-Received: from localhost ([::1]:38010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkhtp-0004bs-3K for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Apr 2022 03:52:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkhsh-0003pb-HH for emacs-devel@gnu.org; Sat, 30 Apr 2022 03:51:07 -0400 Original-Received: from sonic311-23.consmr.mail.ne1.yahoo.com ([66.163.188.204]:39352) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nkhsg-0007af-1p for emacs-devel@gnu.org; Sat, 30 Apr 2022 03:51:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1651305064; bh=/jy40Kct/V6TxJqomzgmUp4J34NnKdSqkSCDOCguW3E=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=IlNQUtH8aZXKW+KgeXVqMR/PdKyctZtvazwSZ8HRJxpJKn1seQQ1LEZ75YlL99e8vyHlHg6FhAh8sm7FLKmctf58y2vZvaDv6ZdQ/KjEL4nMjhOXUlShn2xyFmqDHgmNYCm0d2rwOmROr2Ca0/AE0Vcp6xhLsaVkhXDpHITN+sxGX3GtjVtOQWgQIwewanlumHi88to9iiYXfdC0DWp17f1bf/INmtdXMwsrA+gRve+E07b1t/HXoYXjKIeW1wfSqRAiYlg1cu7asPmJ3XaO6bQ/khQ2ffq1EVpn9OooOYigvi9UPjgCTbxmeCCMqqgOcoB+6WZMGiMXo+wfpLYSqA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1651305064; bh=dcQTODIZl1NmWV1Uueg6i/UylU/DdzBrFwTc865bRPw=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=lQQ2CnyRwIC1QbDQqLybaN9Sh/QdZ7xEVr/AOeqf0l/I+xPpbpqtOgLa35V4P71hqBzazozr6f8r7q9fVEhWentm8NeAa2skDz/KLmtBAI4V2hvYlPVzD8pLybwnN51Pc654ALfGESopFrybQydZbQpA0+yuUFAe6RXoApDfWq3XkllozHQ+6KqSkdkLoHciFDtTZScJ3myjM5M8tvWpwTtjrzt+pBSkNtPheiOTu50+ziOyrJi0kC5tOH687DgDqBfQPGi+4B09Z73D/sasQiU0EoLYrsxcd2sNKo9aVj/3W5zEID65BqVCTgszTdLPUUhIVpdfBCBduUsn7v2lLw== X-YMail-OSG: t9ry.qcVM1l8KmURonUFDY0eB7xzLkeIFeWgGBu7b_EDS7mpQoRUQdmpVUYvaUS 67lRSsrxvFjOGcuFtXDaw5DiZYI2ZEcdcFOOiNM5GEbw_mEglpgxVxvJs2aJ_I0.WgCw72MTaPOl uduu6RNKm75_Qkb4AZmC6Hc7aADONG82Jshv26t3xv_LwsiDUgOjJb73AjPZPjM_kV2r9i3UUX9_ el_2bhM5XG0S8rIzvyuuS1zeonbVgqt85fXT4lFViVkd2m3UciK98Qb1Wo7QaaoqQbvVhaPCekiy YernSXF2FT4vM9q8GY66brDpXg4JZorieJ6PmdLlOjjg3_FkcyU4btfWpmJTrLgSZk21AZi2HWX9 ULL1NlnPs0WYTX48x3zoQp07a8wMeiVbW19WAKe8Yhr8imo_xHfk3HMeb1ZAFnmAa42peKXmFteN Hz135IZSECHh3KsrVL75AbO5UHPID_pLa4gwgUv2yGdFM4XvpwB0d7difNPUG3qQgf8t0aDcV0qt kxgbRoSmOBFRSUIcUIKYC5K4Kw8wBtIiZIAQ1w70wVjh9CTiAtbmayYmTTezJp1KyBNuLiqmBwXc BkVEy3BlpRod4d94JXVd7J54V05t93qeJjKtlwj57saHd4MHipn2HyShlqHlgKr5pgRwkHii6jWx 6SHZfEboYgJ_yWPYeZkWPNWm81zOizOlPpw73.XYRC1vtlxsbhM7AFHBeJ.nYqwqZNoY5zM9mgEb LyJfgmC7zz3NNczHejnU9yK9wyf7HyXZ5N7fRB9bxFatTXb_yoG3baP0Ubc2qspxsDeVaC1xbqtl 7M21wFuwpGxHgg7fch8WXV424IQCYQrF4lns2ieBiy X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ne1.yahoo.com with HTTP; Sat, 30 Apr 2022 07:51:04 +0000 Original-Received: by hermes--canary-production-sg3-795d7b4d54-xv6hw (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 99e82e7d706f3a27f4b0590c815d2490; Sat, 30 Apr 2022 07:50:57 +0000 (UTC) In-Reply-To: <831qxf9h1p.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Apr 2022 10:17:06 +0300") X-Mailer: WebService/1.1.20118 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.188.204; envelope-from=luangruo@yahoo.com; helo=sonic311-23.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289037 Archived-At: Eli Zaretskii writes: >> window = window_from_coordinates (f, x, y, 0, 1, 1); >> >> - if (EQ (window, f->tool_bar_window)) >> + if (EQ (window, f->tool_bar_window) >> + && (inev.modifiers & down_modifier >> + || f->last_tool_bar_item != -1)) >> { >> w32_handle_tool_bar_click (f, &inev); >> tool_bar_p = 1; >> > > Can you tell what was the problem, and how to see it happening before > the change? > > Thanks. Begin dragging to select some text but release the mouse pointer on top of the toolbar. Emacs will continue selecting text until you click somewhere else, because the button release event is consumed by the tool bar and never reaches Lisp.