all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 4fb028be6c 3/3: Fix releasing the mouse on top of the tool bar on MS Windows
Date: Sat, 30 Apr 2022 15:50:53 +0800	[thread overview]
Message-ID: <87pmkzt3fm.fsf@yahoo.com> (raw)
In-Reply-To: <831qxf9h1p.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Apr 2022 10:17:06 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>>                      window = window_from_coordinates (f, x, y, 0, 1, 1);
>>  
>> -                    if (EQ (window, f->tool_bar_window))
>> +                    if (EQ (window, f->tool_bar_window)
>> +			&& (inev.modifiers & down_modifier
>> +			    || f->last_tool_bar_item != -1))
>>                        {
>>                          w32_handle_tool_bar_click (f, &inev);
>>                          tool_bar_p = 1;
>> 
>
> Can you tell what was the problem, and how to see it happening before
> the change?
>
> Thanks.

Begin dragging to select some text but release the mouse pointer on top
of the toolbar.  Emacs will continue selecting text until you click
somewhere else, because the button release event is consumed by the tool
bar and never reaches Lisp.



  reply	other threads:[~2022-04-30  7:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-30  7:17 master 4fb028be6c 3/3: Fix releasing the mouse on top of the tool bar on MS Windows Eli Zaretskii
2022-04-30  7:50 ` Po Lu [this message]
2022-04-30  9:36   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmkzt3fm.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.