From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Adding icon sets to Emacs -- and next steps for icons.el
Date: Wed, 24 Aug 2022 13:25:40 +0200 [thread overview]
Message-ID: <87pmgpopcb.fsf@gnus.org> (raw)
In-Reply-To: <CADwFkmnOsrwZ3Zq=D99N7PHHFzmw4wFHnzUTN40hixZYmYVj2Q@mail.gmail.com> (Stefan Kangas's message of "Tue, 23 Aug 2022 23:45:43 -0700")
Stefan Kangas <stefankangas@gmail.com> writes:
> My idea is to keep Lars' idea of individual customizable icons, but
> leave the choice of which image file to the code I've written.
> I imagine that the `warnings-suppress' icon definition in warnings.el
> should look something like:
>
> (define-icon warnings-suppress button
> '((image "warning") ;;; <<< NEW LINE >>>
> (emoji "⛔")
> (symbol " ■ ")
> (text " stop "))
> "Suppress warnings."
> :version "29.1"
> :help-echo "Click to suppress this warning type")
>
> From here, "warning" will be fed to my `icons-get', which will be
> responsible for producing, e.g., the ".../material/alert/warning.svg"
> file from the "materials" icon set, based on whatever knobs we decide to
> have.
I don't think it's necessary to have another layer on top of the icons
layer for this, because we already have theming support for icons. That
is, if we want a Material theme, we'd just do:
(custom-theme-set-icons
'material
'(warning-suppress ((image "material/alert/warning.svg" "material/alert/warning.xpm"))
'(outline-open ((image "material/action/open.svg" "material/action/open.xpm")))))
And then users can just choose that theme.
People that create other themes would distribute the .svg/.xpm files
with the theme definition -- so the degrading from "if Material icons
aren't present, then use these other icons instead" won't happen.
next prev parent reply other threads:[~2022-08-24 11:25 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 6:45 Adding icon sets to Emacs -- and next steps for icons.el Stefan Kangas
2022-08-24 6:56 ` Po Lu
2022-08-24 7:20 ` Stefan Kangas
2022-08-24 11:25 ` Lars Ingebrigtsen [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-08-24 12:43 Angelo Graziosi
2022-08-24 13:05 ` Dmitry Gutov
2022-08-24 13:22 ` Eli Zaretskii
2022-08-24 13:26 ` Visuwesh
2022-08-24 14:19 ` Eli Zaretskii
2022-08-24 14:32 ` Visuwesh
2022-08-24 16:23 ` Stefan Monnier
2022-08-24 16:34 ` Eli Zaretskii
2022-08-25 1:11 ` Po Lu
2022-08-25 1:35 ` Visuwesh
2022-08-24 13:36 ` Po Lu
2022-08-24 13:51 ` Angelo Graziosi
2022-08-24 16:40 ` Stefan Kangas
2022-08-24 13:46 ` Angelo Graziosi
2022-08-24 13:47 ` Dmitry Gutov
2022-08-24 13:58 ` Po Lu
2022-08-24 14:26 ` Dmitry Gutov
2022-08-25 1:10 ` Po Lu
2022-08-25 1:22 ` Dmitry Gutov
2022-08-25 2:34 ` Po Lu
2022-08-24 23:09 ` Stefan Kangas
2022-08-25 1:23 ` Po Lu
2022-08-25 5:39 ` Eli Zaretskii
2022-08-25 6:49 ` Po Lu
2022-08-25 11:01 ` Visuwesh
2022-09-07 20:03 ` Jean Louis
2022-09-08 8:18 ` Po Lu
2022-09-08 8:25 ` Dmitry Gutov
2022-09-08 8:37 ` Jean Louis
2022-09-08 10:38 ` Po Lu
2022-08-25 21:26 ` Rudolf Adamkovič
2022-09-08 11:00 ` Jean Louis
2022-09-09 11:04 ` Rudolf Adamkovič
2022-08-25 9:28 ` Lars Ingebrigtsen
2022-09-07 19:11 ` Jean Louis
2022-08-24 16:08 Payas Relekar
2022-08-24 18:10 ` Dmitry Gutov
2022-08-25 1:39 ` Visuwesh
2022-08-25 5:28 ` Tim Cross
2022-09-08 10:03 Payas Relekar
2022-09-08 11:44 ` Dmitry Gutov
2022-09-09 3:03 ` Richard Stallman
2022-09-08 12:19 Payas Relekar
2022-09-08 14:03 ` Po Lu
2022-09-08 14:11 ` Payas Relekar
2022-09-08 21:24 ` Stefan Kangas
2022-09-09 1:48 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmgpopcb.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.