From: Robert Pluim <rpluim@gmail.com>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
Andreas Schwab <schwab@linux-m68k.org>,
51384@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap
Date: Wed, 21 Sep 2022 09:17:46 +0200 [thread overview]
Message-ID: <87pmfpci1x.fsf@gmail.com> (raw)
In-Reply-To: <CADwFkmmJnijdXiY2frxEDkGXTd3B+D8BuTdpdYmdXWYivapk0Q@mail.gmail.com> (Stefan Kangas's message of "Tue, 20 Sep 2022 14:03:53 -0400")
>>>>> On Tue, 20 Sep 2022 14:03:53 -0400, Stefan Kangas <stefankangas@gmail.com> said:
Stefan> This looks eerily similar to the code I removed here:
Stefan> commit ac0027f6a5480bd4739fdf71413a19012f400483
Stefan> Author: Stefan Kangas <stefan@marxist.se>
Stefan> Date: Mon Jul 11 17:21:23 2022 +0200
Stefan> Remove dead branch from substitute-command-keys
Stefan> * lisp/help.el (substitute-command-keys): Remove dead branch;
Stefan> where-is-internal will follow any remaps for us. Note also that the
Stefan> test case for remapping still pass.
Similar, but not the same. That dead branch followed remaps, this code
redoes the lookup in the global map.
Stefan> Do we have a test case that reverting that commit would fix?
No, and I donʼt see why youʼd want to revert it, it seems correct to
me.
Stefan> (I can't see Lars' message yet, so the delays with the gnu.org mail
Stefan> systems seem to be ongoing...)
Itʼs not jut gnu.org for me, but maybe thatʼs a local issue.
Anyway, Iʼve pushed the fix as cee9a2cbe0
Robert
--
next prev parent reply other threads:[~2022-09-21 7:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 9:57 bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap Robert Pluim
2021-10-25 10:16 ` Andreas Schwab
2021-10-25 10:39 ` Robert Pluim
2021-11-15 17:25 ` Juri Linkov
2021-11-15 17:48 ` Robert Pluim
2022-09-14 18:29 ` Lars Ingebrigtsen
2022-09-15 7:39 ` Robert Pluim
2022-09-15 8:55 ` Robert Pluim
2022-09-15 9:00 ` Andreas Schwab
2022-09-15 9:04 ` Robert Pluim
2022-09-15 11:54 ` Drew Adams
2022-09-16 9:29 ` Lars Ingebrigtsen
2022-09-16 9:58 ` Robert Pluim
2022-09-16 9:59 ` Lars Ingebrigtsen
2022-09-20 15:47 ` Robert Pluim
2022-09-20 15:51 ` Lars Ingebrigtsen
2022-09-20 16:41 ` Robert Pluim
2022-09-20 18:03 ` Stefan Kangas
2022-09-21 7:17 ` Robert Pluim [this message]
2022-09-21 8:55 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmfpci1x.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=51384@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
--cc=schwab@linux-m68k.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.