From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thuna Newsgroups: gmane.emacs.bugs Subject: bug#58165: [Patch] [GNU ELPA] rcirc-color: Allow recoloring nicks Date: Fri, 30 Sep 2022 02:30:22 +0200 Message-ID: <87pmfdzotd.fsf@gmail.com> References: <87mtaiw7le.fsf@gmail.com> <87ill5yjvg.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5976"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58165@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 30 02:31:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oe3w3-0001UG-T2 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Sep 2022 02:31:23 +0200 Original-Received: from localhost ([::1]:36534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oe3w2-0001ZS-QI for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Sep 2022 20:31:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oe3vj-0001ZF-3b for bug-gnu-emacs@gnu.org; Thu, 29 Sep 2022 20:31:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40863) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oe3vi-0000Xy-OF for bug-gnu-emacs@gnu.org; Thu, 29 Sep 2022 20:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oe3vi-0005eH-F2 for bug-gnu-emacs@gnu.org; Thu, 29 Sep 2022 20:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thuna Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Sep 2022 00:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58165 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58165-submit@debbugs.gnu.org id=B58165.166449783721679 (code B ref 58165); Fri, 30 Sep 2022 00:31:02 +0000 Original-Received: (at 58165) by debbugs.gnu.org; 30 Sep 2022 00:30:37 +0000 Original-Received: from localhost ([127.0.0.1]:39941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oe3vJ-0005db-37 for submit@debbugs.gnu.org; Thu, 29 Sep 2022 20:30:37 -0400 Original-Received: from mail-ej1-f54.google.com ([209.85.218.54]:41777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oe3vC-0005dJ-Np for 58165@debbugs.gnu.org; Thu, 29 Sep 2022 20:30:35 -0400 Original-Received: by mail-ej1-f54.google.com with SMTP id hy2so5958481ejc.8 for <58165@debbugs.gnu.org>; Thu, 29 Sep 2022 17:30:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=4rtXgXcQNzVIi7lOgJoWSzTXRKih+fo2FbJuT0sRm44=; b=grdEYLbl5+3QbUigynE85LxugM8f7dGbaB3ySLDr7Avw8MnyCYQ4H4ZcgBujR1Rc3e 9FzI9x5AeKP4wo9cDWXryyqOSKZKzd2diE+mtaxdr65CoLiR7zTJQOX9VkjBKzN+HtO5 3xI6eBRCox6AxqW9qMYGk7hVGNgLTw5BSBsRL81ABcaPlXl7sEHI0ErRK/Tgw9hpn8Nm M6LE5hH523c3024qbOurhvChj28E4U3550TDtw7fQb1xmTCOfUA2OQhl6bVgBFStOUNP A4gSDo1TbFo9Fj211sMji+9YnhhwkU+713HulCB5SfK6xQe0svZgxuenVU4ifviSaYjd 02Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4rtXgXcQNzVIi7lOgJoWSzTXRKih+fo2FbJuT0sRm44=; b=1ACtTtgErwH9rPx6kcKlwNKzNjKdkTVeGSW2SIKfm3xw839IMLYIk/arMm1ttKpo5n JvSf9CemDywJNjempDz3vxW03fUtt9i913WV3qM3lCHJrN8jHb6+7vW+vn5EkD5hUD38 hBnCNQc8oW+w5grQobPbvt7HIWrhRoWGjZV/VKa82jAJViCBaXfDJo6i4vAbOAM4v/1r 28HDk9glUftR0E3y44DVNY0ozs+xIWFAVjSjrReyr+affCv2kUoQu4aQ3zNm1URywl9v qIWtW4sdRAP6GO/gvimyVHDFUNHoNFW6VYZWDs+qlcIuu15yWH5KdXU/awxtE/KRVjE1 IZzg== X-Gm-Message-State: ACrzQf0nGQRgEqEPOztco3UiuJsMDu5bxlAG5TPSmW6Ei310QhURkTSM ZkeBTRKJ5wfC29iYlBCrOhxzxEG4JEg= X-Google-Smtp-Source: AMsMyM5cjqpvMFt2AoIpBCjtRM4hDTl7h7h1hIkXPhXvifdYfM6NfYKjHaZyD7iCH7mJtRulZMy6BA== X-Received: by 2002:a17:907:78d:b0:740:33e1:998 with SMTP id xd13-20020a170907078d00b0074033e10998mr4771490ejb.162.1664497823554; Thu, 29 Sep 2022 17:30:23 -0700 (PDT) Original-Received: from thuna ([90.147.71.105]) by smtp.gmail.com with ESMTPSA id f27-20020a17090631db00b0073cf6ec3276sm275267ejf.207.2022.09.29.17.30.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 17:30:23 -0700 (PDT) In-Reply-To: <87ill5yjvg.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243965 Archived-At: > While at it one could replace the `foreground-color', since (elisp) > Special Properties says: > > =E2=80=A2 A cons cell of the form =E2=80=98(foreground-color . CO= LOR-NAME)=E2=80=99 or > =E2=80=98(background-color . COLOR-NAME)=E2=80=99. This specif= ies the > foreground or background color, similar to =E2=80=98(:foreground > COLOR-NAME)=E2=80=99 or =E2=80=98(:background COLOR-NAME)=E2=80= =99. This form is > supported for backward compatibility only, and should be > avoided. I avoided it on the off chance something would break, but I don't mind either way. > Also, it would be nice to also reformat the code using a let* block. > Something like > > (let* ((index (random (length rcirc-colors))) > (color (elt rcirc-colors index)) > (face (cons 'foreground-color color))) > (puthash nick face rcirc-color-mapping)) Seems ok to me.