From: Thuna <thuna.cing@gmail.com>
To: Philip Kaludercic <philipk@posteo.net>
Cc: 58165@debbugs.gnu.org
Subject: bug#58165: [Patch] [GNU ELPA] rcirc-color: Allow recoloring nicks
Date: Fri, 30 Sep 2022 02:30:22 +0200 [thread overview]
Message-ID: <87pmfdzotd.fsf@gmail.com> (raw)
In-Reply-To: <87ill5yjvg.fsf@posteo.net>
> While at it one could replace the `foreground-color', since (elisp)
> Special Properties says:
>
> • A cons cell of the form ‘(foreground-color . COLOR-NAME)’ or
> ‘(background-color . COLOR-NAME)’. This specifies the
> foreground or background color, similar to ‘(:foreground
> COLOR-NAME)’ or ‘(:background COLOR-NAME)’. This form is
> supported for backward compatibility only, and should be
> avoided.
I avoided it on the off chance something would break, but I don't mind
either way.
> Also, it would be nice to also reformat the code using a let* block.
> Something like
>
> (let* ((index (random (length rcirc-colors)))
> (color (elt rcirc-colors index))
> (face (cons 'foreground-color color)))
> (puthash nick face rcirc-color-mapping))
Seems ok to me.
next prev parent reply other threads:[~2022-09-30 0:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 14:58 bug#58165: [Patch] [GNU ELPA] rcirc-color: Allow recoloring nicks Thuna
2022-09-29 21:02 ` Philip Kaludercic
2022-09-30 0:30 ` Thuna [this message]
2022-09-30 11:24 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmfdzotd.fsf@gmail.com \
--to=thuna.cing@gmail.com \
--cc=58165@debbugs.gnu.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.