From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 63d084d4e4: Fix encoding and decoding of process I/O in Eshell on Windows Date: Mon, 17 Oct 2022 18:05:20 +0200 Message-ID: <87pmeqwi4f.fsf@gmail.com> References: <166583166191.28035.1408947255493373295@vcs2.savannah.gnu.org> <20221015110102.361A6C1AB48@vcs2.savannah.gnu.org> <875ygiy0is.fsf@gmail.com> <83tu421oka.fsf@gnu.org> <87y1tewkms.fsf@gmail.com> <83sfjm1mrz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31491"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 17 18:08:23 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1okSf9-00083m-OY for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Oct 2022 18:08:23 +0200 Original-Received: from localhost ([::1]:42894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1okSf8-0002i5-B8 for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Oct 2022 12:08:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okScJ-0001Lc-A6 for emacs-devel@gnu.org; Mon, 17 Oct 2022 12:05:27 -0400 Original-Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:43768) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1okScH-00045S-JV; Mon, 17 Oct 2022 12:05:27 -0400 Original-Received: by mail-wm1-x336.google.com with SMTP id bh7-20020a05600c3d0700b003c6fb3b2052so1179105wmb.2; Mon, 17 Oct 2022 09:05:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=wOKhf5AMhSViL+GbAzr8yrN7hjpTlbX6sQNQd28ZR/o=; b=i3rdvjviyHVrQ/Y8AZZ8o5JxZMFC1qneKIEcQSmK/V3/g4NOw6MC6RXncy0TX5iXKP DQSIiyGG0UWCarTYj/hOdqJYMIaUhGE7hDs3FfTgvcg+2D52Mm07YjbqhKR/S6XkxF0s Zr1uVWzblSdIrJIB8a9kRVpYOOUPhTHlmnvg9jsQJw+2iuV0raB6ZPZWgFyIhKjAFG+L J+TTk80ANmukKzdZsSwZSPYblRRCecgGmnK+1cqky0YSxi/FBfGxkOfb6WSOvVmsQSCO k1gBsgAFMof1bTuSFo8SPAOLRJ3hr/m0Qn14cM4HL2uPs6N9qJP7xuQT7PjLduEQfe0k Jf1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wOKhf5AMhSViL+GbAzr8yrN7hjpTlbX6sQNQd28ZR/o=; b=dx9zxC4V4dXprZNrLTZYKXylL68AxFsheml5lGHHpDxjicARCAzbiZZvqrHU2DAL5K B604dE7sEvq6OE9x9ZGnhnTcW+q4jbEdk/1amuBX7sAs04Z63joUcJ/YG0wW6s10matE 2D1721UpE5EpU5D9Yns7hyfuc2ylnK3gWzEFk6AD0Iz6E7P0bqoh/32cyArsMtwI6oX0 z/y6QB2nyPoRt8wLoRhpU3lqKrOudjOtzJJAMGj+kZd2UCisBmlDbXX1MKE1aeFS3z8N eXLuPmm+lbRyXoi4VwYay2MAg45J3ATQvaXvUwIQUymqrr7jIHVrXvj+PIiIHP7XwWbQ h5Gw== X-Gm-Message-State: ACrzQf0CNPKKytwmruhSmnvAXB/plFbUHPSY07eDMTLEp66O7XjZmkfo Nqhx7vf6s69+Gj/G4y9CggffxEjijqE= X-Google-Smtp-Source: AMsMyM5+FmTWLRE0d42cuPKSRzcoIqgHaUBXcjq3QrWRvn4NDLZOJSHrhlI96zBxx5+WVbenRsJ/Fw== X-Received: by 2002:a05:600c:3584:b0:3c6:f234:852b with SMTP id p4-20020a05600c358400b003c6f234852bmr7161159wmq.10.1666022721622; Mon, 17 Oct 2022 09:05:21 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id d20-20020a05600c34d400b003b4de550e34sm10862078wmq.40.2022.10.17.09.05.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 09:05:20 -0700 (PDT) In-Reply-To: <83sfjm1mrz.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 17 Oct 2022 18:40:32 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=rpluim@gmail.com; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297963 Archived-At: >>>>> On Mon, 17 Oct 2022 18:40:32 +0300, Eli Zaretskii said: Eli> . the let-binding in this case is restricted to creation of the Eli> processes, so here it doesn't have more "global" effect that Eli> :coding Eli> . there are two processes being created, not one; let-binding Eli> affects both of them, whereas :coding would have to be applied= to Eli> each one separately Eli> . :coding overrides coding-system-for-read/write, which is somew= hat Eli> surprising and perhaps unexpected; while we could have code th= at Eli> sets :coding only if coding-system-for-read/write are nil, it Eli> would be a trickier code, and perhaps not self-explanatory wit= hout Eli> a suitable commentary Eli> Now let me turn the table and ask you why is :coding preferred, in Eli> your opinion? Because we=CA=BCve had bugs where coding-system-for-read/write was used, and processes created further down the call chain would use it, and by the time they did its value had changed, which would have been avoided by using :coding (I seem to remember an issue with an invocation of gpg, although I wouldn=CA=BCt be surprised if there was some asynchronicity involved as well) Robert --=20