Tags: patch To reproduce: 1. Put the following in /tmp/test/init.el (custom-set-variables '(erc-mode-hook '(erc-imenu-setup visual-line-mode))) which is exactly what you'd get by doing M-x customize-group RET erc-hooks RET and adding a `visual-line-mode' item to `erc-mode-hook'. 2. Run emacs --no-site-file --init-directory=/tmp/test 3. If you do a C-h v erc-mode-hook RET which loads `erc' behind the scenes, the hook's value will be (erc-imenu-setup) Note the missing `visual-line-mode'. Superficially, this is a regression stemming from bug#56340: 29.0.50; [PATCH] Don't ask people to order requires. which became commit c2d657e7c4fd9685591f2120007eabf78745919d Author: Dick R. Chiang Date: Fri Jul 1 11:06:51 2022 -0400 Move ERC's core dependencies to separate file But amid all that rearranging, a subtle and pernicious headache long ago swept under the rug happened to resurface [1]. I see two basic avenues of attack here. The first is a pretty safe stopgap and the second a slightly riskier comprehensive approach that should have been on the books the moment that bug was closed: hack: partially revert a tiny hunk from the commit above fix: don't require goodies at all and instead update the module mapping data and add all necessary autoloads and forward declarations Implementations of both are attached. (I didn't bother updating the required Compat version in the second patch, but that'd also need to accompany the change set.) For now, I propose we take the shorter route but with an eye toward revisiting the issue soon after the next (ERC) release. If anyone has an opinion here, now would be the time to speak up. Thanks. P.S. This bug owes its existence to Libera user jrm, who kindly brought it to our attention earlier today. [1] Some related background. For ages, `erc-goodies' was `require'd by erc.el at the very end of that file, likely in order to sidestep the manual module-to-feature mapping needed by `erc-update-modules' for outliers whose names don't match their features (arguably justified for smaller, miscellaneous modules). A secondary benefit and possible motivating factor was that various commands from goodies could feature in `erc-mode-map' without being autoloaded. However, additional liberties were eventually taken until erc-goodies.el became a de facto addendum to erc.el. In GNU Emacs 29.0.60 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.35, cairo version 1.17.6) of 2023-01-19 built on localhost Repository revision: 7b7b2b95138e691f1b155060b91a8998e3905651 Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12014000 System Description: Fedora Linux 36 (Workstation Edition) Configured using: 'configure --enable-check-lisp-object-type --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3' PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils erc iso8601 time-date auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map thingatpt pp format-spec cl-loaddefs cl-lib erc-backend erc-goodies erc-networks byte-opt gv bytecomp byte-compile erc-common erc-compat erc-loaddefs rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 64464 6515) (symbols 48 8616 0) (strings 32 23657 2042) (string-bytes 1 685680) (vectors 16 15232) (vector-slots 8 209553 7914) (floats 8 24 23) (intervals 56 228 0) (buffers 976 10))