From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#63861: [PATCH] pp.el: New "pretty printing" code Date: Fri, 09 Jun 2023 21:34:43 +0530 Message-ID: <87pm64aag4.fsf@gmail.com> References: <83fs799jmi.fsf@gnu.org> <871qirdi3a.fsf@gmail.com> <87cz25b9rw.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33713"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 63861@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 09 18:05:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7ec2-0008Ur-Cq for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Jun 2023 18:05:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7ebp-0000d8-P9; Fri, 09 Jun 2023 12:05:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7ebn-0000cj-1s for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2023 12:05:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q7ebm-0007P5-Av for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2023 12:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q7ebm-0000Xd-3H for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2023 12:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Jun 2023 16:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63861 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63861-submit@debbugs.gnu.org id=B63861.16863266942065 (code B ref 63861); Fri, 09 Jun 2023 16:05:02 +0000 Original-Received: (at 63861) by debbugs.gnu.org; 9 Jun 2023 16:04:54 +0000 Original-Received: from localhost ([127.0.0.1]:60199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7ebe-0000XE-1q for submit@debbugs.gnu.org; Fri, 09 Jun 2023 12:04:54 -0400 Original-Received: from mail-pf1-f196.google.com ([209.85.210.196]:49558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7ebc-0000X1-2U for 63861@debbugs.gnu.org; Fri, 09 Jun 2023 12:04:52 -0400 Original-Received: by mail-pf1-f196.google.com with SMTP id d2e1a72fcca58-652dd220d67so1973438b3a.3 for <63861@debbugs.gnu.org>; Fri, 09 Jun 2023 09:04:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686326686; x=1688918686; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UInROBCCFFxlCiWtvsnC2ZrJKEzVMjEtnTcVtmGH/C0=; b=I6MhX+MkujZrybaLnHbWt+QfJ3INvOsDFNP1jfTFf/rZN67A1ePqahguvuGz7+1nYb Oyl+27Nl9KT8zHYdLzR4yLaDtTZa/gD9ZaBSSv9iR/oAPXy76JAAFnkBe/FyR1QQDqeD 3Cnj21pN/nTIf/wPMK7VNJZL3R8rQShcWwtH5HZS2f65L9+zzlfVculi2A07lkSRZUck C/eJK2v00eVFMTJ45mwOj0HQvGDIKAU4rZ6h9OcA7DNRdNDpALv+XulVAbKq8XbDWU0l ZTFMvmvRQ0/lwbp1P/ZjLEJpPCdz+isM+yyznN809CPfPM8TPUczq9AQ96GDCe6bbIIX IzgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686326686; x=1688918686; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UInROBCCFFxlCiWtvsnC2ZrJKEzVMjEtnTcVtmGH/C0=; b=mF6/gsLjKBjST82SnanEA8TKxFTuP1g52LyO+HVmWSnQedRHvPZD6sDMIsbEW4xvds w9vOzCLf2zDw4UxNfCLST+XnnIpQYBW+AcYjeZfF7inNhfCOo6RlOrc4VPX0ALRtjYdH /1psjNwazJJ/7CyxBccHkypH//AvmM5E/i0yWwS4Y8/YOu0arXd2Xz2UScZHabg9Q/Ak pkmnxWAI8aEfsL1rtoxa5M7gmZqVV759ulAidkAnGvaH/RqJEAA2WJvMXKr1n3/XFYUJ SbDy3Hpss2MfQx1CgSm8oNit/U2ygkOcAqeJGCBbsl8vXZCJh7Oq0RfYzrtSVYh57FiN Hzfw== X-Gm-Message-State: AC+VfDyo9wBTnZ4n/cz2qeE/WFkXgSbxeHYCNgpRuHFuKPFq150WIiPy 6YLHr9UC5dOfi44LLmrhKRs= X-Google-Smtp-Source: ACHHUZ5O85oqbiZdKZXgH1XwE56sP/BoExr4h5r20XtneaSNeOwLRDvjRDts/haSNJJjLcKkG+mK6w== X-Received: by 2002:a05:6a20:a987:b0:10c:80a:480c with SMTP id cc7-20020a056a20a98700b0010c080a480cmr1662211pzb.41.1686326686057; Fri, 09 Jun 2023 09:04:46 -0700 (PDT) Original-Received: from localhost ([49.205.80.56]) by smtp.gmail.com with ESMTPSA id a14-20020a63e84e000000b0054a15146f53sm985323pgk.13.2023.06.09.09.04.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jun 2023 09:04:45 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Fri, 09 Jun 2023 10:59:18 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263174 Archived-At: [=E0=AE=B5=E0=AF=86=E0=AE=B3=E0=AF=8D=E0=AE=B3=E0=AE=BF =E0=AE=9C=E0=AF=82= =E0=AE=A9=E0=AF=8D 09, 2023] Stefan Monnier wrote: >>> My new code is expected to be slower than the "normal" pretty-printer, >>> but barring performance bugs in `lisp-indent-line` (such as the one >>> fixed by the patch I just sent to Thierry) it should be approximately >>> a constant factor slower. >>> AFAICT the performance of `pp-emacs-lisp-code` can be more problematic. >> Hopefully, the constant factor is quite small. > > In my tests, 10x seems to be the "worst case slowdown" of `pp-region`. > On some of the tests, it's actually faster, sometimes significantly so > (presumably due to some non-linear complexity in some parts of > `pp-buffer`). I cannot imagine how bad 10x really will be but if you are daily-driving this, I assume it is so not bad after all. Thanks for your answers!