From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#64055: [WIP Patch] Enable editing commit messages - vc-git-modify-change-comment Date: Wed, 14 Jun 2023 10:00:32 +0200 Message-ID: <87pm5yo4m7.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33970"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64055@debbugs.gnu.org To: Morgan Smith Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 14 10:01:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9LRT-0008iz-2c for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Jun 2023 10:01:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9LRA-0003K9-Kn; Wed, 14 Jun 2023 04:01:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9LR9-0003Iz-9F for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 04:01:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9LR8-0001kH-8I for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 04:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q9LR8-00078m-2s for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 04:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Jun 2023 08:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64055 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64055-submit@debbugs.gnu.org id=B64055.168672964327401 (code B ref 64055); Wed, 14 Jun 2023 08:01:02 +0000 Original-Received: (at 64055) by debbugs.gnu.org; 14 Jun 2023 08:00:43 +0000 Original-Received: from localhost ([127.0.0.1]:43599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9LQo-00077r-PE for submit@debbugs.gnu.org; Wed, 14 Jun 2023 04:00:43 -0400 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:51482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9LQm-00077c-6r for 64055@debbugs.gnu.org; Wed, 14 Jun 2023 04:00:40 -0400 Original-Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-3f8d1eb535eso2467175e9.3 for <64055@debbugs.gnu.org>; Wed, 14 Jun 2023 01:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686729634; x=1689321634; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=6K8VOU9VFFW0PNyNI4YbrznuGocuHYrHJasPlQYIIPg=; b=JOq9KOy9cD6vB+xXqq1gCFTxu7RgE9fGg0uVASOfizVNzAH8Qsd/doRYtBPkl+FaOZ 8MwvYuEGIF5uh5YyZOpulgK++02FeCPi+qzWmwAZNM1E9zELqvau3WIYvflyHIl19yE1 KTcSX1EwttR44HBnvI5BZx2l1HGtQ5ChUoAU5hwXZfz4Xu8xzy4AlK+iB8ufNZxh7Coi /5UH2L2N9zqwek990vJH7gr2UZGPPYRbL8oL3gCBOnjFWOLHNIqaxPoA601HUjfALtYB XKAC292A7eF6oEh2FCDmVw1jtHI9M3hvVD0HTxGMdv8vwSNZ0lGfz+3kdTKRs+NCkEK+ 5i4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686729634; x=1689321634; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6K8VOU9VFFW0PNyNI4YbrznuGocuHYrHJasPlQYIIPg=; b=SqcgGrovAY38UF5bbEBgJ0uTmc8hDXnLs6YxbUCPYd3awHSThfhUvR7Tlk0/SpvDXF 4+V+SNY2N5jdNPuLgD2XmbrEx4GRe8d/2vVhBDejX0VUqcYxvsEb8T+w91bZvWVMZqm3 2Fpo3tg8CJICo1N1x7U1aqFYPvY1TOdcCvB5oGLX3Xz1B4wSEhlP9lI6Y/YqKXp4n4YQ PixJr/Jnk/n+I06PkALrMDp/B3U0omDtwQ4CDrmm0+hvVeLOB4KmLtk7QTNHVimmacfm 2WmB2+P8gvIED7n/vc5+6WNmT/E5jir6+XcQPqZPy7PWc9tOt7iI9wTMEuJ3/yG9wbNg 6BGQ== X-Gm-Message-State: AC+VfDx2omSpZgxOX2TXTBZtZ4ACxi50Skfmg5txHbO4kYd2Mq6rU0El vlogdhPzLcBYl0LH6jKHWCuaHjNzg8Y= X-Google-Smtp-Source: ACHHUZ7PutZccFNM5Yb/GSXjkCs9bb7koFZO+q6cd3G7KXuuIR8tsCGpQt/Brh/zmZo9xwr4+wiz5A== X-Received: by 2002:a5d:61c4:0:b0:306:3b39:9a2a with SMTP id q4-20020a5d61c4000000b003063b399a2amr7341713wrv.42.1686729633474; Wed, 14 Jun 2023 01:00:33 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id e7-20020a056000120700b0030af8da022dsm17432359wrx.44.2023.06.14.01.00.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 01:00:32 -0700 (PDT) In-Reply-To: (Morgan Smith's message of "Tue, 13 Jun 2023 18:59:24 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263356 Archived-At: >>>>> On Tue, 13 Jun 2023 18:59:24 -0400, Morgan Smith said: Morgan> Please look at this patch. Ignore the bad commit message for n= ow, I'm Morgan> trying to figure out how to edit that :P. Morgan> I've spent far too long looking at git documentation and source= code. I Morgan> think this is the best way to enable this feature. In fact I r= eally Morgan> don't think there is another way to implement this feature that= doesn't Morgan> rely on the "autosquash" git feature. Does 'git commit --amend -m' not work? Morgan> I found the hack located in vc-git-modify-change-comment' of se= tting Morgan> "GIT_SEQUENCE_EDITOR=3D:" on the internet and I don't understan= d how it Morgan> works. Morgan> Also I'm not really sure what the 'vc-dispatcher-browsing' func= tion is Morgan> supposed to do but it's getting in my way. Like are 'diff-mode= ' buffers Morgan> a "directory browser buffer"? I don't understand the intent he= re. Morgan> Also you'll noticed I deleted some comments in vc.el. That's m= ainly to Morgan> highlight them so we can talk about them now. Is there a good = way to Morgan> stop users from editing remote commits? You can=CA=BCt stop anyone from doing anything on their local system, but I guess you could check if 'git merge-base' is upstream. Morgan> I feel like I should probably just keep working on this and get= it more Morgan> polished and answer some of my own questions before posting her= e but I'm Morgan> getting kind of frustrated with this. I am many hours deep int= o this Morgan> problem. We can be your rubber duck :-) Robert --=20