org-fold style text-properties slowdown

org-fold style text-properties slowdown

[Sebastian Wålinder]

Hello!

I write regularly in a massive org file ~160 000 lines, and experience progressive slowdowns as the buffer remains open when I have the setting `(setq org-fold-core-style 'text-properties)`.

When the file is first opened, all operations are very fast. But as I keep using, it keeps slowing down and eventually slows to a crawl where typing a single character takes several seconds. However, after closing the buffer and opening the file up again, the speed returns to normal.

With `(setq org-fold-core-style 'overlays)` in my `early-init.el`, I have no slowdown issue related to org-fold over time.

Running the CPU profiler while typing a few characters in the buffer yields me this report:
```
17969  99% - command-execute
17969  99%  - funcall-interactively
17956  99%   - org-self-insert-command
17940  99%    - org-fold-core--fix-folded-region
178   0%     - org-fold-core-next-folding-state-change
177   0%        #<compiled 0x72c2e0e7737b768>
42   0%     - org-fold-core-get-region-at-point
1   0%        org-fold-core--property-symbol-get-create
21   0%     - org-fold--reveal-outline-maybe
18   0%      - org-fold--reveal-headline-at-point
16   0%       - org-end-of-subtree
9   0%        - org-back-to-heading-or-point-min
8   0%         - org-before-first-heading-p
8   0%            org-element-at-point
1   0%           org-back-to-heading
6   0%          org-element-at-point
2   0%      - rx-to-string
2   0%       - rx--translate
2   0%        - rx--translate-form
1   0%         - rx--translate-or
1   0%            mapcan
1   0%     - org-fold-core-get-folding-spec
1   0%        org-fold-core--property-symbol-get-create
1   0%     - org-fold-core-region-folded-p
1   0%      - org-fold-core-get-folding-spec
1   0%         org-fold-core-get-folding-spec-from-alias
1   0%       #<compiled 0x1e4c54b2bcafef>
1   0%    - #<lambda 0x1e33d5fbace2c>
1   0%       let
1   0%    - org-element--cache-after-change
1   0%     - org-element--cache-submit-request
1   0%        org-element--cache-sync
3   0%   - my/system-hydra/profiler-stop-and-exit
3   0%    - hydra--call-interactively-remap-maybe
3   0%       funcall-interactively
3   0%   - evil-normal-state
1   0%    - evil-change-state
1   0%       evil-insert-state
3   0%   - my/system-hydra/profiler-report-and-exit
2   0%    - hydra--call-interactively-remap-maybe
2   0%       funcall-interactively
1   0%    - hydra-keyboard-quit
1   0%     - #<compiled 0x19801059c7c2>
1   0%      - message
1   0%       - apply
1   0%          mini-modeline--reroute-msg
1   0%   - evil-previous-line
1   0%    - evil-line-move
1   0%       line-move
1   0%   - my/system-hydra/body
1   0%    - my/hydra-pre-cursor
1   0%       evil-set-cursor-color
```
The memory profiler reports nothing significant. It appears `org-fold-core--fix-folded-region` is what's taking all the cycles. What's the best way for me to proceed debugging this? 

Setup:
`GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars)`

`Org mode version 9.6.6 (release_9.6.6 @ /nix/store/q8adc2srnbipkahbwffwg006d09yk02g-emacs-git-20230618.0/share/emacs/30.0.50/lisp/org/)`

Thanks!
Sebastian

Re: org-fold style text-properties slowdown

[Ihor Radchenko]

Sebastian Wålinder <s.walinder@gmail.com> writes:

> I write regularly in a massive org file ~160 000 lines, and experience progressive slowdowns as the buffer remains open when I have the setting `(setq org-fold-core-style 'text-properties)`.
>
> When the file is first opened, all operations are very fast. But as I keep using, it keeps slowing down and eventually slows to a crawl where typing a single character takes several seconds. However, after closing the buffer and opening the file up again, the speed returns to normal.
>
> With `(setq org-fold-core-style 'overlays)` in my `early-init.el`, I have no slowdown issue related to org-fold over time.
> ...
> The memory profiler reports nothing significant. It appears `org-fold-core--fix-folded-region` is what's taking all the cycles. What's the best way for me to proceed debugging this? 

Try the latest bugfix branch.
I recently pushed an optimization in this area:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?h=bugfix&id=7b3b7b92e784c86c4ada1150d6e17a510b5ea3d0

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>