From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#65243: [PATCH] Fix building of VC package manuals with relative org links/includes Date: Mon, 14 Aug 2023 08:14:31 +0000 Message-ID: <87pm3qhwgo.fsf@posteo.net> References: <87y1ig3atl.fsf@breatheoutbreathe.in> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19757"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65243@debbugs.gnu.org To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 14 10:15:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qVSjG-0004sP-J6 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Aug 2023 10:15:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVSj9-0002Sn-ML; Mon, 14 Aug 2023 04:15:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVSj9-0002SZ-2u for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2023 04:15:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qVSj8-0004kh-O2 for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2023 04:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qVSj8-0002IJ-Jf for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2023 04:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Aug 2023 08:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65243 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65243-submit@debbugs.gnu.org id=B65243.16920008808775 (code B ref 65243); Mon, 14 Aug 2023 08:15:02 +0000 Original-Received: (at 65243) by debbugs.gnu.org; 14 Aug 2023 08:14:40 +0000 Original-Received: from localhost ([127.0.0.1]:60988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVSim-0002HS-FD for submit@debbugs.gnu.org; Mon, 14 Aug 2023 04:14:40 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:52731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVSik-0002HF-MV for 65243@debbugs.gnu.org; Mon, 14 Aug 2023 04:14:39 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E62B4240104 for <65243@debbugs.gnu.org>; Mon, 14 Aug 2023 10:14:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692000872; bh=jwfUdHJLyfP7+7EsLSuT574tcv6UjG4AC7f4n9Adhhk=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=gEETZZZHhOJpT30xALpvxx7Fsii/yfWprJDsuWizA+aKsxKVj4ItslesXLzTYzDZZ Wxb6hATLOC1h+Grf7vf2aCbGvqg0+EpSLleCWJf1HhANmtoY7i74KTsvTVs7SaFgLb LakIt6Uv55opNQgnuXhIbdJEirUIJByhaYBU5a1ir9F/EsdoFBmmmaqnuvnvUpmjaY 1Sz/ggtGyH1Un70h+juzu25wsByvGfyCbDflt/cs03SYaCVbcwaqm6/A++ZESijH8Z Vz/UXsTT3AyN03ABM6h6d3jmMK/EeR/OVRn6WZ/HFsqnVre+fHJ1xv3U6g0LF2rXzI r3tCYA1O02G7A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RPRyJ2SKyz6tw0; Mon, 14 Aug 2023 10:14:32 +0200 (CEST) In-Reply-To: <87y1ig3atl.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Sat, 12 Aug 2023 01:43:35 -0700") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267400 Archived-At: Joseph Turner writes: > Hello, > > This patch allows for relative includes and link in org files compiled > to texinfo. > > Unfortunately, I missed this back in May > (commit 1e6a7594 ), when we fixed relative texi @include links. > > I'm not sure how the Emacs release cycle works. Would it be possible to > include this fix in 29.2? I wouldn't have any issue with that, and AFAIU now that the release has been cut, this should be fine, as this is just a bug fix. BTW, what package is this related to? > Best, > > Joseph > >>>From e951b0ea4ffa90202ecee934eddd895b706c6794 Mon Sep 17 00:00:00 2001 > From: Joseph Turner > Date: Sat, 12 Aug 2023 01:40:07 -0700 > Subject: [PATCH] Fix building of VC package manuals with relative org > links/includes > > * lisp/emacs-lisp/package-vc.el (package-vc--build-documentation): > Ensure that default-default is the docs-directory around > org-export-to-file to ensure that links to relative files work correctly. > --- > lisp/emacs-lisp/package-vc.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el > index b4c911015b5..ffc7afeb2ee 100644 > --- a/lisp/emacs-lisp/package-vc.el > +++ b/lisp/emacs-lisp/package-vc.el > @@ -356,7 +356,8 @@ otherwise it's assumed to be an Info file." > (with-temp-buffer > (insert-file-contents file) > (setq file (make-temp-file "ox-texinfo-")) > - (org-export-to-file 'texinfo file) > + (let ((default-directory docs-directory)) > + (org-export-to-file 'texinfo file)) > (setq clean-up t))) > (with-current-buffer (get-buffer-create " *package-vc doc*") > (erase-buffer)