From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#65386: [PATCH] ; Refine some 'package-vc' docstrings Date: Sun, 20 Aug 2023 20:35:30 +0000 Message-ID: <87pm3hsb8t.fsf@posteo.net> References: <7a0f6dcb-3e56-8009-3f54-bb7b9fb6fce3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11676"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Eshel Yaron , 65386@debbugs.gnu.org To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 20 22:36:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXp9m-0002ne-Ca for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Aug 2023 22:36:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXp9W-0001xS-Qv; Sun, 20 Aug 2023 16:36:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXp9U-0001x1-Od for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 16:36:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXp9U-0005kq-Cz for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 16:36:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXp9V-0006S5-Rw for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 16:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Aug 2023 20:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65386 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65386-submit@debbugs.gnu.org id=B65386.169256374924781 (code B ref 65386); Sun, 20 Aug 2023 20:36:01 +0000 Original-Received: (at 65386) by debbugs.gnu.org; 20 Aug 2023 20:35:49 +0000 Original-Received: from localhost ([127.0.0.1]:54912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXp9F-0006RZ-Gq for submit@debbugs.gnu.org; Sun, 20 Aug 2023 16:35:49 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:33305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXp9B-0006RJ-6q for 65386@debbugs.gnu.org; Sun, 20 Aug 2023 16:35:44 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id BD882240028 for <65386@debbugs.gnu.org>; Sun, 20 Aug 2023 22:35:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692563733; bh=23mEJh1+RpWXJpYcvsihUt4pkA6T2Gw4PtrUOh1j9R8=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=WPHQZyboRIc6HuXULkxqfbyDRnzt96F0I2w5KE219YRanXKOYjp/BFnU4CRvcFHF7 usvzJp9ENbFHDFBIVhyua34jC6WQPlQvyITf9gOBuwRRWODT7SYHstQjBYlF9ezs/z etLkobcm8MgccImBhL6+Lo5eR/YeSHcBO88WM0icikuQ32Z+jgyClcMEflkAYG9Iuy OXugEAm2W6HvqrmZTNFNon4m6V8wc4M2EyF2kLG7FgcAfXzLYqGDLHKYZffueca8uL 9t+gdXadmGP7f9/hTFwAHU78jeYXlLvPr39z0DdN5D3LgYlFbCY75spJjZci2HSiLC /GGlPnEjla0ag== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RTS6X6f4Wz6twG; Sun, 20 Aug 2023 22:35:32 +0200 (CEST) In-Reply-To: <7a0f6dcb-3e56-8009-3f54-bb7b9fb6fce3@gmail.com> (Mauro Aranda's message of "Sun, 20 Aug 2023 16:24:21 -0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268034 Archived-At: Mauro Aranda writes: > Eshel Yaron writes: > >> Philip Kaludercic writes: >> >>> Eshel Yaron writes: >>> >>>>> Also, would it make sense to determine this at compile-time?=C2=A0 On= the >>>>> other hand, if a VC backend is installed later on from ELPA, we would >>>>> want the custom type to reflect this. >>>> >>>> Yes, I couldn't find a way to defer computing the set of candidates to >>>> "customization type", I'm not sure if that even makes total sense.=C2= =A0 I >>>> think it's not that crucial since someone adding a VC backend and >>>> immediately trying to customize these options seems to me like a very >>>> minor edge case, and we had the same issue prior to my patch anyhow. >>> >>> Likely yes, but if we have two mostly equivalent solutions, I think that >>> flexibility without having to restart Emacs is preferable to > performance. >>> >> >> Hmm I'm not sure I completely follow.=C2=A0 Which two solutions do you h= ave >> in mind?=C2=A0 I agree that it would be nice have the `:type` updated if= the >> user adds a relevant VC backend, but I don't think `defcustom` supports >> something like that.=C2=A0 How do you propose to achieve that flexibilit= y? > > I haven't watch this thread closely, but do note that creating dynamic > choices is quite possible, if I understand correctly what you're looking > for. > > If you can, take a look at the defcustom of completion-styles, in > minibuffer.el.=C2=A0 Its type uses a choice with a specialized > :convert-widget function to keep the choices up-to date. This might be exactly what we are looking for. It should be possible to adapt `completion--update-styles-options' pretty much directly to our example.