From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: breadcrumb.el Date: Tue, 05 Sep 2023 06:21:09 +0000 Message-ID: <87pm2xb0oa.fsf@posteo.net> References: <87tts9llst.fsf@gmail.com> <87cyyx7jjk.fsf@posteo.net> <87jzt5lksr.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37969"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 05 08:22:12 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdPS0-0009fh-HS for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Sep 2023 08:22:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdPR7-0007L5-8V; Tue, 05 Sep 2023 02:21:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdPR5-0007Kw-ND for emacs-devel@gnu.org; Tue, 05 Sep 2023 02:21:15 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdPR2-00087j-FZ for emacs-devel@gnu.org; Tue, 05 Sep 2023 02:21:15 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 9AFA2240101 for ; Tue, 5 Sep 2023 08:21:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693894870; bh=MYJpoXTkbsP7b2UFXuNVKzExmMjoy0S+HheJxfo3bLk=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=gFn6tqnBJi9ClyDFKyz0/zKa02TV3Q55PNeM/ToRMGqKL0abQq5jAwZeWB8RQ3MMx ZM/BfM/RFzlRmklnXQ50rr+qJQvwN/3hbrTq6Rq26pCKbB5qNG2pqM3utJPl95ynbx WOq6+aciZUjJpCgGrROJADkCOZhjSBB+/kcShMWVx8BCn+u8+beeDjHSeIekwZh06H cIoA8hiriARNL5SXWumBi1d1uXFhY+li0jevSUmzjbOOm0NNsKUiL1Q/Z/aWe+L/Vd kVHZ3ZhXuemD/8Va6J19UeDVNt4Qsq4EE1DDLSryzwBCqltaFuEtt7WF1RFNJaYaJd ErjOLQ2iYdNeg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RfwPL1Fdkz9rxD; Tue, 5 Sep 2023 08:21:10 +0200 (CEST) In-Reply-To: <87jzt5lksr.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Mon, 04 Sep 2023 21:56:20 +0100") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310111 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > Philip Kaludercic writes: > >> Jo=C3=A3o T=C3=A1vora writes: > >>> Here's a link to the project (which has a screenshot) >>> https://github.com/joaotavora/breadcrumb >> >> Looks nice! I have no notable comments on the code, except that the >> indentation out of place in two parts of the file. > > Thanks, I just spotted that and will fix briefly. 1+ >>> Here's the patch for elpa.git >>> >>> diff --git a/elpa-packages b/elpa-packages >>> index 7bbf35a..cfceb7e 100644 >>> --- a/elpa-packages >>> +++ b/elpa-packages >>> @@ -99,6 +99,9 @@ >>> (bnf-mode :url "https://github.com/sergeyklay/bnf-mode") >>> (boxy :url "https://gitlab.com/tygrdev/boxy") >>> (boxy-headings :url "https://gitlab.com/tygrdev/boxy-headings") >>> + (breadcrumb :url "https://github.com/joaotavora/breadcrumb" >>> + :readme "README.md" >> >> Are you sure you want to use the README.md file to generate the package >> description, or wouldn't you rather rely on the Commentary section? > > Better rely on the Commentary, yes. Just consider remove that line > removed from the patch. Ok. >> Having a "Screenshot" heading followed by nothing might look weird. >> >>> + :ignored-files ("screenshot.png")) >> >> If possible, it would be nice to track this on your end with a >> .elpaignore file. > > That's perfectlky doable, but I do think it makes a bit more sense like > this. Why do you think it's "nicer"? And can we merge it as is for now > (so I can tick this off my todo? ;-) The advantage of having this information locally in your repository is that if anything changes (files are added or renamed), it is easier to update what files shouldn't be bundled in the release tarball, instead of having to change stuff in elpa.git. I guess in your case it doesn't matter that much because you also have push-access to the repository. "Nice" just means that we avoid small "Add foo.bar to :ignored-files for baz" commits, that are more noisy than useful. > Jo=C3=A3o