* ICalendar export
@ 2023-09-12 12:01 Henrik Frisk
2023-09-13 8:00 ` Ihor Radchenko
0 siblings, 1 reply; 9+ messages in thread
From: Henrik Frisk @ 2023-09-12 12:01 UTC (permalink / raw)
To: org-mode-email
[-- Attachment #1: Type: text/plain, Size: 600 bytes --]
hi,
I've had an iCal export setup working fine for several years. I have an
org-agenda-custom-commands defined with:
(org-agenda-start-day "2022-09-01")
(org-agenda-span 120) ;; number of days
(org-agenda-include-diary nil))
Recently (not sure when) the ics output came out malformed and a newline is
omitted between the end of one event and the beginning of another:
END:VEVENT
BEGIN:VEVENT
is now
END:VEVENTBEGIN:VEVENT
I can't figure out wha the pattern is, for some events the output is
correct.
This is on Org mode version 9.7-pre release_9.6.8-719-gf299fb and emacs 29.1
best,
/Henrik
[-- Attachment #2: Type: text/html, Size: 898 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: ICalendar export
2023-09-12 12:01 ICalendar export Henrik Frisk
@ 2023-09-13 8:00 ` Ihor Radchenko
2023-09-16 22:52 ` Jack Kamm
0 siblings, 1 reply; 9+ messages in thread
From: Ihor Radchenko @ 2023-09-13 8:00 UTC (permalink / raw)
To: Henrik Frisk, Jack Kamm; +Cc: org-mode-email
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
Henrik Frisk <frisk.h@gmail.com> writes:
> Recently (not sure when) the ics output came out malformed and a newline is
> omitted between the end of one event and the beginning of another:
>
> END:VEVENT
> BEGIN:VEVENT
>
> is now
>
> END:VEVENTBEGIN:VEVENT
>
> I can't figure out wha the pattern is, for some events the output is
> correct.
>
> This is on Org mode version 9.7-pre release_9.6.8-719-gf299fb and emacs 29.1
We recently did some major changes to comply better to the icalendar
specs and introduced new feature. As it usually goes, major changes can
easily introduce new bugs.
Does the attached patch fix the problem for you?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-ox-icalendar-Ensure-that-entries-in-icalendar-end-wi.patch --]
[-- Type: text/x-patch, Size: 1505 bytes --]
From 5ab376c558cbd0c1dcdbba99b4a42ff11e27418a Mon Sep 17 00:00:00 2001
Message-ID: <5ab376c558cbd0c1dcdbba99b4a42ff11e27418a.1694591956.git.yantar92@posteo.net>
From: Ihor Radchenko <yantar92@posteo.net>
Date: Wed, 13 Sep 2023 10:58:15 +0300
Subject: [PATCH] ox-icalendar: Ensure that entries in icalendar end with a
newline
* lisp/ox-icalendar.el (org-icalendar--vevent):
(org-icalendar--vtodo): Make sure that there is a newline after the
exported VEVENT and VTODO.
Reported-by: Henrik Frisk <frisk.h@gmail.com>
Link: https://orgmode.org/list/CAO0LSb4aQhUMny4xr=1LB3t5F-K-WnjK1zc+qR7Jy+69vr2wpw@mail.gmail.com
---
lisp/ox-icalendar.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/ox-icalendar.el b/lisp/ox-icalendar.el
index 980bb0ed3..20efad243 100644
--- a/lisp/ox-icalendar.el
+++ b/lisp/ox-icalendar.el
@@ -809,7 +809,7 @@ (\"PUBLIC\", \"CONFIDENTIAL\", and \"PRIVATE\") are predefined, others
"CATEGORIES:" categories "\n"
;; VALARM.
(org-icalendar--valarm entry timestamp summary)
- "END:VEVENT")))
+ "END:VEVENT\n")))
(defun org-icalendar--repeater-type (elem)
"Return ELEM's repeater-type if supported, else warn and return nil."
@@ -952,7 +952,7 @@ (defun org-icalendar--vtodo
(if (eq (org-element-property :todo-type entry) 'todo)
"NEEDS-ACTION"
"COMPLETED"))
- "END:VTODO")))
+ "END:VTODO\n")))
(defun org-icalendar--valarm (entry timestamp summary)
"Create a VALARM component.
--
2.42.0
[-- Attachment #3: Type: text/plain, Size: 224 bytes --]
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: ICalendar export
2023-09-13 8:00 ` Ihor Radchenko
@ 2023-09-16 22:52 ` Jack Kamm
2023-09-17 9:50 ` Ihor Radchenko
0 siblings, 1 reply; 9+ messages in thread
From: Jack Kamm @ 2023-09-16 22:52 UTC (permalink / raw)
To: Ihor Radchenko, Henrik Frisk; +Cc: org-mode-email
Ihor Radchenko <yantar92@posteo.net> writes:
> Henrik Frisk <frisk.h@gmail.com> writes:
>
>> Recently (not sure when) the ics output came out malformed and a newline is
>> omitted between the end of one event and the beginning of another:
>>
>> END:VEVENT
>> BEGIN:VEVENT
>>
>> is now
>>
>> END:VEVENTBEGIN:VEVENT
>>
>> I can't figure out wha the pattern is, for some events the output is
>> correct.
>>
>> This is on Org mode version 9.7-pre release_9.6.8-719-gf299fb and emacs 29.1
>
> We recently did some major changes to comply better to the icalendar
> specs and introduced new feature. As it usually goes, major changes can
> easily introduce new bugs.
>
> Does the attached patch fix the problem for you?
I can reproduce the bug by calling `org-icalendar-export-current-agenda'
in my agenda buffer. It seems to mainly happen when subsequent agenda
entries originate from different files.
Ihor's patch fixes the problem on my end.
Bisecting, the bug was introduced in f4446ce79.
^ permalink raw reply [flat|nested] 9+ messages in thread
* iCalendar export
@ 2011-07-20 12:19 Gustav Wikström
2011-07-20 18:05 ` Tassilo Horn
0 siblings, 1 reply; 9+ messages in thread
From: Gustav Wikström @ 2011-07-20 12:19 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 496 bytes --]
Hello!
I like the feature that TODO-items and calendar-items can be exportet to an
iCalendar file. But one thing bugs me, I'm having trouble finding suitable
software that supports the iCalendar-standard with vtodo items...
So my question to this newsgroup is; If you use the iCalendar export
function, what software do you use to view this information? And have anyone
got this information to their mobile devices? Android? Having this
information on the go would be killer...
Regards
Gustav
[-- Attachment #2: Type: text/html, Size: 587 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: iCalendar export
2011-07-20 12:19 iCalendar export Gustav Wikström
@ 2011-07-20 18:05 ` Tassilo Horn
2011-07-21 9:35 ` Bastien
0 siblings, 1 reply; 9+ messages in thread
From: Tassilo Horn @ 2011-07-20 18:05 UTC (permalink / raw)
To: emacs-orgmode
Gustav Wikström <gustav.erik@gmail.com> writes:
Hi Gustav,
> So my question to this newsgroup is; If you use the iCalendar export
> function, what software do you use to view this information?
Yeah, I convert to ical files on save, and there's some cron job that
copies these files to some webpage. From there, I import into Google
Calendar. But that doesn't show todos of imported ical files and has
major encoding issues with german umlauts and so on.
> And have anyone got this information to their mobile devices? Android?
Well, I have it there using the Google Calendar app. It's ok to see my
appointments in some graphical read-only view, but nothing more...
Bye,
Tassilo
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-10-04 9:33 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-12 12:01 ICalendar export Henrik Frisk
2023-09-13 8:00 ` Ihor Radchenko
2023-09-16 22:52 ` Jack Kamm
2023-09-17 9:50 ` Ihor Radchenko
2023-10-04 9:32 ` Henrik Frisk
-- strict thread matches above, loose matches on Subject: below --
2011-07-20 12:19 iCalendar export Gustav Wikström
2011-07-20 18:05 ` Tassilo Horn
2011-07-21 9:35 ` Bastien
2011-07-25 23:14 ` Arun Persaud
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.