From: Michael Albinus <michael.albinus@gmx.de>
To: Peter Oliver <p.d.oliver@mavit.org.uk>
Cc: 66667@debbugs.gnu.org
Subject: bug#66667: [PATCH] Socket forwarding in emacsclient --tramp-prefix example
Date: Sun, 22 Oct 2023 09:43:20 +0200 [thread overview]
Message-ID: <87pm17rtk7.fsf@gmx.de> (raw)
In-Reply-To: <6f458d1e-a536-7b90-2027-077c9767677b@mavit.org.uk> (Peter Oliver's message of "Sat, 21 Oct 2023 20:28:17 +0100 (BST)")
Peter Oliver <p.d.oliver@mavit.org.uk> writes:
Hi Peter,
> So, I’m not certain that one and a half examples is better than one complete example, but, anyway, here’s an updated patch.
Thanks. LGTM, just two nits:
> +If you are using a platform that does not have Unix domain sockets
> +(i.e., MS-Windows), or SSH implementations that are not able to
I'm not sure whether MS-Windows supports UNIX domain sockets or not. Eli
might know this.
> +forward them (e.g., OpenSSH before version 6.7), you can forward a TCP
> +port instead. In this example, assume that the local Emacs listens on
> +tcp port 12345. Assume further that
> @file{/home} is on a shared file system, so that the server file
> @file{~/.emacs.d/server/server} is readable on both hosts.
>
> @example
> local$ ssh -R12345:localhost:12345 remote
> -remote$ export EDITOR="emacsclient \
> - --server-file=server \
> - --tramp=/ssh:remote:"
> +remote$ export EMACSCLIENT_TRAMP=/ssh:remote:
> +remote$ export EDITOR=emacsclient
Here we need also
remote$ export EMACS_SERVER_FILE=server
Otherwise, the "Implicit local socket" rule comes to play, see
set_socket in emacsclient.c.
Otherwise, it is fine. Eli, can we still install it in the emacs-29 branch?
And another question. You have already contributed to Emacs. That
contribution, and your proposed changes here and in bug#66598 bring you
close to the limit of changes (~15 lines), which are accepted without
formal paperwork. In order to make further contributions from you
possible: would you like to assign the copyright of your future
contributions to the Free Software Foundation?
> Peter Oliver
Best regards, Michael.
next prev parent reply other threads:[~2023-10-22 7:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 15:01 bug#66667: [PATCH] Socket forwarding in emacsclient --tramp-prefix example Peter Oliver
2023-10-21 16:57 ` Michael Albinus
2023-10-21 19:28 ` Peter Oliver
2023-10-22 7:43 ` Michael Albinus [this message]
2023-10-22 9:26 ` Eli Zaretskii
2023-10-22 16:53 ` Peter Oliver
2024-01-10 10:14 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-22 1:05 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <65347577.5d0a0220.ab2d6.0249SMTPIN_ADDED_BROKEN@mx.google.com>
2023-10-22 17:09 ` Peter Oliver
2024-04-08 11:26 ` Peter Oliver
2024-04-10 8:48 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm17rtk7.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=66667@debbugs.gnu.org \
--cc=p.d.oliver@mavit.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.