From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68214: Completion sorting customization by category Date: Sat, 06 Jan 2024 18:59:44 +0100 Message-ID: <87plye9wbz.fsf@daniel-mendler.de> References: <86a5pnzst1.fsf@mail.linkov.net> <868r5630ft.fsf@mail.linkov.net> <8ebc33fb-d01f-4426-a716-69a11f6dfad1@daniel-mendler.de> <86le95m2ue.fsf@mail.linkov.net> <86sf3cjj6o.fsf@mail.linkov.net> <871qawrxh0.fsf@daniel-mendler.de> <86r0iuxu4f.fsf@mail.linkov.net> Reply-To: Daniel Mendler Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6402"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 68214@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 06 19:01:13 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rMAyv-0001TZ-IY for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Jan 2024 19:01:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rMAyi-0004r3-Cb; Sat, 06 Jan 2024 13:01:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMAyg-0004qg-5i for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2024 13:00:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rMAyf-0003Hg-7l for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2024 13:00:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rMAyk-0005VT-1T for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2024 13:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jan 2024 18:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68214 X-GNU-PR-Package: emacs Original-Received: via spool by 68214-submit@debbugs.gnu.org id=B68214.170456400413272 (code B ref 68214); Sat, 06 Jan 2024 18:01:02 +0000 Original-Received: (at 68214) by debbugs.gnu.org; 6 Jan 2024 18:00:04 +0000 Original-Received: from localhost ([127.0.0.1]:60271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMAxk-0003Q1-FV for submit@debbugs.gnu.org; Sat, 06 Jan 2024 13:00:03 -0500 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:36579 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMAxi-0003Pm-IW for 68214@debbugs.gnu.org; Sat, 06 Jan 2024 12:59:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ChPIbgW6YzvFY+9J6DnUgeVUC9x3Tua6QA5BojrpdXg=; b=EL7SB5PyDZV/GAApVLaK6T6C8T i8Jaow1viD4J+kD4sQRGW4s2vr87pphVAfbvmAl/HP6Lb+30h00T1aWsJTxOPatloqN2ITI1kpm9X S1y56AjD7NRAz1KSCidCBI1U0iAFZvZk3ipMH/GSheRyxxzw6bcLGzpCto4ZFI7T4pec=; In-Reply-To: <86r0iuxu4f.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 06 Jan 2024 19:33:36 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277476 Archived-At: Juri Linkov writes: >> If we are going with a solution which supports customizing arbitrary >> metadata based on category, we could also adjust >> `completion-metadata-get' and avoid the introduction of a separate >> function `completion-metadata-override-get'. This will result in a >> smaller and simpler code change overall. >> >> (defun completion-metadata-get (metadata prop) >> "Get PROP from completion METADATA. >> If the metadata specifies a completion category, the variables >> `completion-category-overrides' and >> `completion-category-defaults' take precedence." >> (if-let (((not (eq prop 'category))) >> (cat (alist-get 'category metadata)) >> (over (completion--category-override cat prop))) >> (cdr over) >> (alist-get prop metadata))) > > This is what I already considered but hesitated to make this change > since it modifies the default behavior. OTOH, probably there is > no possible harm from this change. So I'll give this a try. Thanks. Seems better to take that route, instead of changing all `completion-metadata-get' calls to `completion-metadata-override-get' and leaving `completion-metadata-get' mostly unused. As long as we don't modify `completion-category-defaults' or `completion-category-overrides' there won't be a change in behavior.