Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

[Michael Albinus]

Eli Zaretskii <eliz@gnu.org> writes:

Hi,

> branch: master
> commit 84e4bc6219af2c08097027d4b75043b23c1fcce6
> Author: Rahguzar <rahguzar@zohomail.eu>
> Commit: Eli Zaretskii <eliz@gnu.org>
>
>     Add input methods for Urdu, Pashto and Sindhi (bug#66470)

This commit has added the following error in Emacs' tests:

--8<---------------cut here---------------start------------->8---
# make -C test test-custom-deps
The following load problems appeared:
(pakistan-urdu-input pakistan (file-missing Cannot open load file No such file or directory pakistan))
(quail pakistan (file-missing Cannot open load file No such file or directory pakistan))
Test test-custom-deps backtrace:
  signal(ert-test-failed (((should-not cus-test-deps-errors) :form cus
  ert-fail(((should-not cus-test-deps-errors) :form cus-test-deps-erro
  (if (not (unwind-protect (setq value-5 cus-test-deps-errors) (setq f
  (let (form-description-6) (if (not (unwind-protect (setq value-5 cus
  (let ((value-5 (gensym "ert-form-evaluation-aborted-"))) (let (form-
  (closure (cus-test-deps-errors t) nil (let* ((fn-0 #'file-readable-p
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name test-custom-deps :documentation nil :
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
  ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
  ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
  eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
  command-line-1(("-L" ":." "-l" "ert" "-l" "misc/test-custom-deps.el"
  command-line()
  normal-top-level()
Test test-custom-deps condition:
    (ert-test-failed
     ((should-not cus-test-deps-errors) :form cus-test-deps-errors :value
      ((pakistan-urdu-input pakistan
			    (file-missing "Cannot open load file"
					  "No such file or directory"
					  "pakistan"))
       (quail pakistan
	      (file-missing "Cannot open load file"
			    "No such file or directory" "pakistan")))))
   FAILED  1/1  test-custom-deps (40.411856 sec) at misc/test-custom-deps.el:35

Ran 1 tests, 0 results as expected, 1 unexpected (2024-01-18 21:00:25+0100, 41.295278 sec)

1 unexpected results:
   FAILED  test-custom-deps
--8<---------------cut here---------------end--------------->8---

Best regards, Michael.

Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

[Rahguzar]

Hi Michael and Eli,

I am not very familiar with the Emacs test and I don't understand
where the file missing error is coming from. I will look into this but
if someone can explain what the test is try to do, I will appreciate
that help.

Rahguzar

Michael Albinus <michael.albinus@gmx.de> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
> Hi,
>
>> branch: master
>> commit 84e4bc6219af2c08097027d4b75043b23c1fcce6
>> Author: Rahguzar <rahguzar@zohomail.eu>
>> Commit: Eli Zaretskii <eliz@gnu.org>
>>
>>     Add input methods for Urdu, Pashto and Sindhi (bug#66470)
>
> This commit has added the following error in Emacs' tests:
>
> # make -C test test-custom-deps
> The following load problems appeared:
> (pakistan-urdu-input pakistan (file-missing Cannot open load file No such file or directory pakistan))
> (quail pakistan (file-missing Cannot open load file No such file or directory pakistan))
> Test test-custom-deps backtrace:
>   signal(ert-test-failed (((should-not cus-test-deps-errors) :form cus
>   ert-fail(((should-not cus-test-deps-errors) :form cus-test-deps-erro
>   (if (not (unwind-protect (setq value-5 cus-test-deps-errors) (setq f
>   (let (form-description-6) (if (not (unwind-protect (setq value-5 cus
>   (let ((value-5 (gensym "ert-form-evaluation-aborted-"))) (let (form-
>   (closure (cus-test-deps-errors t) nil (let* ((fn-0 #'file-readable-p
>   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
>   ert-run-test(#s(ert-test :name test-custom-deps :documentation nil :
>   ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
>   ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
>   ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
>   ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
>   eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
>   command-line-1(("-L" ":." "-l" "ert" "-l" "misc/test-custom-deps.el"
>   command-line()
>   normal-top-level()
> Test test-custom-deps condition:
>     (ert-test-failed
>      ((should-not cus-test-deps-errors) :form cus-test-deps-errors :value
>       ((pakistan-urdu-input pakistan
> 			    (file-missing "Cannot open load file"
> 					  "No such file or directory"
> 					  "pakistan"))
>        (quail pakistan
> 	      (file-missing "Cannot open load file"
> 			    "No such file or directory" "pakistan")))))
>    FAILED  1/1  test-custom-deps (40.411856 sec) at misc/test-custom-deps.el:35
>
> Ran 1 tests, 0 results as expected, 1 unexpected (2024-01-18 21:00:25+0100, 41.295278 sec)
>
> 1 unexpected results:
>    FAILED  test-custom-deps
>
> Best regards, Michael.

Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

[Eli Zaretskii]

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: Rahguzar <rahguzar@zohomail.eu>
> Date: Fri, 19 Jan 2024 09:45:36 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > branch: master
> > commit 84e4bc6219af2c08097027d4b75043b23c1fcce6
> > Author: Rahguzar <rahguzar@zohomail.eu>
> > Commit: Eli Zaretskii <eliz@gnu.org>
> >
> >     Add input methods for Urdu, Pashto and Sindhi (bug#66470)
> 
> This commit has added the following error in Emacs' tests:
> 
> --8<---------------cut here---------------start------------->8---
> # make -C test test-custom-deps
> The following load problems appeared:
> (pakistan-urdu-input pakistan (file-missing Cannot open load file No such file or directory pakistan))
> (quail pakistan (file-missing Cannot open load file No such file or directory pakistan))
> Test test-custom-deps backtrace:
>   signal(ert-test-failed (((should-not cus-test-deps-errors) :form cus
>   ert-fail(((should-not cus-test-deps-errors) :form cus-test-deps-erro
>   (if (not (unwind-protect (setq value-5 cus-test-deps-errors) (setq f
>   (let (form-description-6) (if (not (unwind-protect (setq value-5 cus
>   (let ((value-5 (gensym "ert-form-evaluation-aborted-"))) (let (form-
>   (closure (cus-test-deps-errors t) nil (let* ((fn-0 #'file-readable-p
>   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
>   ert-run-test(#s(ert-test :name test-custom-deps :documentation nil :
>   ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
>   ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
>   ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
>   ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
>   eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
>   command-line-1(("-L" ":." "-l" "ert" "-l" "misc/test-custom-deps.el"
>   command-line()
>   normal-top-level()
> Test test-custom-deps condition:
>     (ert-test-failed
>      ((should-not cus-test-deps-errors) :form cus-test-deps-errors :value
>       ((pakistan-urdu-input pakistan
> 			    (file-missing "Cannot open load file"
> 					  "No such file or directory"
> 					  "pakistan"))
>        (quail pakistan
> 	      (file-missing "Cannot open load file"
> 			    "No such file or directory" "pakistan")))))
>    FAILED  1/1  test-custom-deps (40.411856 sec) at misc/test-custom-deps.el:35
> 
> Ran 1 tests, 0 results as expected, 1 unexpected (2024-01-18 21:00:25+0100, 41.295278 sec)
> 
> 1 unexpected results:
>    FAILED  test-custom-deps
> --8<---------------cut here---------------end--------------->8---

I tried to look into this.  It seems test-custom-deps runs
cus-test-deps and then requires that cus-test-deps-errors is nil.  I
therefore ran cus-test-deps interactively, and looked at
cus-test-deps-errors.  It is not nil, but its value is

  ((org-babel ob-vala (file-missing "Cannot open load file" "No such file or directory" "ob-vala")) (org-babel ob-stan (file-missing "Cannot open load file" "No such file or directory" "ob-stan")) (org-babel ob-picolisp (file-missing "Cannot open load file" "No such file or directory" "ob-picolisp")) (org-babel ob-J (file-missing "Cannot open load file" "No such file or directory" "ob-J")))

which doesn't mention pakistan at all.

So I'm unsure how to proceed.  It would be useful to see the value of
cus-test-deps-errors in the test that fails, or maybe I'm missing
something in how this test should be run interactively.

P.S. My guess is that some autoload is missing from pakistan.el, but
without reproducing the problem I cannot verify that and cannot test a
solution, and the error message from the failing test is not helpful,
as it doesn't divulge the important details.

Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

[Rahguzar]

Hi Eli,

Eli Zaretskii <eliz@gnu.org> writes:

> I tried to look into this.  It seems test-custom-deps runs
> cus-test-deps and then requires that cus-test-deps-errors is nil.  I
> therefore ran cus-test-deps interactively, and looked at
> cus-test-deps-errors.  It is not nil, but its value is
>
>   ((org-babel ob-vala (file-missing "Cannot open load file" "No such file or directory" "ob-vala")) (org-babel ob-stan (file-missing "Cannot open load file" "No
> such file or directory" "ob-stan")) (org-babel ob-picolisp (file-missing "Cannot open load file" "No such file or directory" "ob-picolisp")) (org-babel ob-J
> (file-missing "Cannot open load file" "No such file or directory" "ob-J")))
>
> which doesn't mention pakistan at all.
>
> So I'm unsure how to proceed.  It would be useful to see the value of
> cus-test-deps-errors in the test that fails, or maybe I'm missing
> something in how this test should be run interactively.
>
> P.S. My guess is that some autoload is missing from pakistan.el, but
> without reproducing the problem I cannot verify that and cannot test a
> solution, and the error message from the failing test is not helpful,
> as it doesn't divulge the important details.

I tried to look into this. The only input method that depends on custom
variables other than `urdu-custom` is `tamil-phonetic`. The variable
`tamil-translation-rules` has a setter function so situation from the
perspective of custom is similar to `pakistan.el`. However `indian.el`
where `tamil-phonetic` is defined has neither `autoload` cookies nor any
`autoload` forms.

There are only two autoload cookies in the files in `lisp/leim/quail/`
and these are for function activating input methods.

Rahguzar

Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

[Rahguzar]

Actually can be it be because `leim-list.el` needs to be updated with
call to `register-input-method` for the input methods in pakistan.el?

Rahguzar

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Michael Albinus <michael.albinus@gmx.de>
>> Cc: Rahguzar <rahguzar@zohomail.eu>
>> Date: Fri, 19 Jan 2024 09:45:36 +0100
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> > branch: master
>> > commit 84e4bc6219af2c08097027d4b75043b23c1fcce6
>> > Author: Rahguzar <rahguzar@zohomail.eu>
>> > Commit: Eli Zaretskii <eliz@gnu.org>
>> >
>> >     Add input methods for Urdu, Pashto and Sindhi (bug#66470)
>>
>> This commit has added the following error in Emacs' tests:
>>
>> --8<---------------cut here---------------start------------->8---
>> # make -C test test-custom-deps
>> The following load problems appeared:
>> (pakistan-urdu-input pakistan (file-missing Cannot open load file No such file or directory pakistan))
>> (quail pakistan (file-missing Cannot open load file No such file or directory pakistan))
>> Test test-custom-deps backtrace:
>>   signal(ert-test-failed (((should-not cus-test-deps-errors) :form cus
>>   ert-fail(((should-not cus-test-deps-errors) :form cus-test-deps-erro
>>   (if (not (unwind-protect (setq value-5 cus-test-deps-errors) (setq f
>>   (let (form-description-6) (if (not (unwind-protect (setq value-5 cus
>>   (let ((value-5 (gensym "ert-form-evaluation-aborted-"))) (let (form-
>>   (closure (cus-test-deps-errors t) nil (let* ((fn-0 #'file-readable-p
>>   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
>>   ert-run-test(#s(ert-test :name test-custom-deps :documentation nil :
>>   ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
>>   ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
>>   ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
>>   ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
>>   eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
>>   command-line-1(("-L" ":." "-l" "ert" "-l" "misc/test-custom-deps.el"
>>   command-line()
>>   normal-top-level()
>> Test test-custom-deps condition:
>>     (ert-test-failed
>>      ((should-not cus-test-deps-errors) :form cus-test-deps-errors :value
>>       ((pakistan-urdu-input pakistan
>> 			    (file-missing "Cannot open load file"
>> 					  "No such file or directory"
>> 					  "pakistan"))
>>        (quail pakistan
>> 	      (file-missing "Cannot open load file"
>> 			    "No such file or directory" "pakistan")))))
>>    FAILED  1/1  test-custom-deps (40.411856 sec) at misc/test-custom-deps.el:35
>>
>> Ran 1 tests, 0 results as expected, 1 unexpected (2024-01-18 21:00:25+0100, 41.295278 sec)
>>
>> 1 unexpected results:
>>    FAILED  test-custom-deps
>> --8<---------------cut here---------------end--------------->8---
>
> I tried to look into this.  It seems test-custom-deps runs
> cus-test-deps and then requires that cus-test-deps-errors is nil.  I
> therefore ran cus-test-deps interactively, and looked at
> cus-test-deps-errors.  It is not nil, but its value is
>
>   ((org-babel ob-vala (file-missing "Cannot open load file" "No such file or directory" "ob-vala")) (org-babel ob-stan (file-missing "Cannot open load file" "No
> such file or directory" "ob-stan")) (org-babel ob-picolisp (file-missing "Cannot open load file" "No such file or directory" "ob-picolisp")) (org-babel ob-J
> (file-missing "Cannot open load file" "No such file or directory" "ob-J")))
>
> which doesn't mention pakistan at all.
>
> So I'm unsure how to proceed.  It would be useful to see the value of
> cus-test-deps-errors in the test that fails, or maybe I'm missing
> something in how this test should be run interactively.
>
> P.S. My guess is that some autoload is missing from pakistan.el, but
> without reproducing the problem I cannot verify that and cannot test a
> solution, and the error message from the failing test is not helpful,
> as it doesn't divulge the important details.

Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

[Eli Zaretskii]

> From: Rahguzar <rahguzar@zohomail.eu>
> Cc: Michael Albinus <michael.albinus@gmx.de>, emacs-devel@gnu.org
> Date: Sat, 20 Jan 2024 12:30:20 +0100
> 
> Actually can be it be because `leim-list.el` needs to be updated with
> call to `register-input-method` for the input methods in pakistan.el?

It should, and it does here.

Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

[Rahguzar]

Hi Eli,

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Rahguzar <rahguzar@zohomail.eu>
>> Cc: Michael Albinus <michael.albinus@gmx.de>, emacs-devel@gnu.org
>> Date: Sat, 20 Jan 2024 12:30:20 +0100
>>
>> Actually can be it be because `leim-list.el` needs to be updated with
>> call to `register-input-method` for the input methods in pakistan.el?
>
> It should, and it does here.

Sorry, I didn't realize that the file is autogenerated. After running
make I indeed see those entries.

Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

[Michael Albinus]

Eli Zaretskii <eliz@gnu.org> writes:

Hi Eli,

>> Test test-custom-deps condition:
>>     (ert-test-failed
>>      ((should-not cus-test-deps-errors) :form cus-test-deps-errors :value
>>       ((pakistan-urdu-input pakistan
>> 			    (file-missing "Cannot open load file"
>> 					  "No such file or directory"
>> 					  "pakistan"))
>>        (quail pakistan
>> 	      (file-missing "Cannot open load file"
>> 			    "No such file or directory" "pakistan")))))
>>    FAILED  1/1  test-custom-deps (40.411856 sec) at misc/test-custom-deps.el:35
>>
>> Ran 1 tests, 0 results as expected, 1 unexpected (2024-01-18 21:00:25+0100, 41.295278 sec)
>>
>> 1 unexpected results:
>>    FAILED  test-custom-deps
>> --8<---------------cut here---------------end--------------->8---
>
> So I'm unsure how to proceed.  It would be useful to see the value of
> cus-test-deps-errors in the test that fails, or maybe I'm missing
> something in how this test should be run interactively.

That value is given above, and it is

--8<---------------cut here---------------start------------->8---
     ((pakistan-urdu-input pakistan
			    (file-missing "Cannot open load file"
					  "No such file or directory"
					  "pakistan"))
       (quail pakistan
	      (file-missing "Cannot open load file"
			    "No such file or directory" "pakistan")))
--8<---------------cut here---------------end--------------->8---

As a data point, `pakistan-urdu-input' is a defgroup defined in
pakistan.el, and `quail' is the defgroup `pakistan-urdu-input' points to
via `:group 'quail'.

Best regards, Michael.

Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

[Rahguzar]

Hi Michael,

Michael Albinus <michael.albinus@gmx.de> writes:

> That value is given above, and it is
>
>      ((pakistan-urdu-input pakistan
> 			    (file-missing "Cannot open load file"
> 					  "No such file or directory"
> 					  "pakistan"))
>        (quail pakistan
> 	      (file-missing "Cannot open load file"
> 			    "No such file or directory" "pakistan")))
>
> As a data point, `pakistan-urdu-input' is a defgroup defined in
> pakistan.el, and `quail' is the defgroup `pakistan-urdu-input' points to
> via `:group 'quail'.

Thanks a lot for the pointer and explaining the connection. It was not
obvious to me that the error was related to `defgroup`. So the test
will probably pass if we add an autoload cookie above the definition of
`pakistan-urdu-input` group?

I see that if the `pakistan.el` is loaded `pakistan-urdu-input` shows up
as subgroup of `quail` in customize and if it is not load it is not
listed.

So I wonder if the test is encouraging the correct behavior. I think
that seeing the `pakistan-urdu-input` subgroup would be useful for
people using `urdu-custom` input method but perhaps for majority of
people we shouldn't cause pakistan.el to load just because they wanted
to customize a quail option.

Maybe it is better to just remove `quail` as the parent group of
`pakistan-urdu-input`?

> Best regards, Michael.

Rahguzar

Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

[Michael Albinus]

Rahguzar <rahguzar@zohomail.eu> writes:

> Hi Michael,

Hi Rahguzar,

> So I wonder if the test is encouraging the correct behavior. I think
> that seeing the `pakistan-urdu-input` subgroup would be useful for
> people using `urdu-custom` input method but perhaps for majority of
> people we shouldn't cause pakistan.el to load just because they wanted
> to customize a quail option.
>
> Maybe it is better to just remove `quail` as the parent group of
> `pakistan-urdu-input`?

No idea. Note, that there is also lisp/leim/quail/indian.el. It declares
defgroup `tamil-input', and it doesn't show an error in the test.

I've tried to replace the parent group of `pakistan-urdu-input' to be
`leim' instead of `quail'. But the error about the missing pakistan.el
persists, just using `leim' instead of `quail' in the error message.

> Rahguzar

Best regards, Michael.

Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

[Rahguzar]

Hi Michael,

Michael Albinus <michael.albinus@gmx.de> writes:

> Rahguzar <rahguzar@zohomail.eu> writes:
>
>> Hi Michael,
>
> Hi Rahguzar,
>
>> So I wonder if the test is encouraging the correct behavior. I think
>> that seeing the `pakistan-urdu-input` subgroup would be useful for
>> people using `urdu-custom` input method but perhaps for majority of
>> people we shouldn't cause pakistan.el to load just because they wanted
>> to customize a quail option.
>>
>> Maybe it is better to just remove `quail` as the parent group of
>> `pakistan-urdu-input`?
>
> No idea. Note, that there is also lisp/leim/quail/indian.el. It declares
> defgroup `tamil-input', and it doesn't show an error in the test.
>
> I've tried to replace the parent group of `pakistan-urdu-input' to be
> `leim' instead of `quail'. But the error about the missing pakistan.el
> persists, just using `leim' instead of `quail' in the error message.

Poking around `cus-test.el` a little I think this is a load path problem
and unrelated to the defgroup form.

I can run

src/emacs -batch --eval="(require 'indian)"

in a shell and it exists without any error.

But

src/emacs -batch --eval="(require 'pakistan)"

results in

Error: file-missing ("Cannot open load file" "No such file or directory" "pakistan")
  mapbacktrace(#f(compiled-function (evald func args flags) #<bytecode -0x188ce6540514dc1>))
  debug-early-backtrace()
  debug-early(error (file-missing "Cannot open load file" "No such file or directory" "pakistan"))
  require(pakistan)
  eval((require 'pakistan) t)
  command-line-1(("--eval=(require 'pakistan)"))
  command-line()
  normal-top-level()
Cannot open load file: No such file or directory, pakistan

Similarly starting with

src/emacs -Q

M-: (require 'indian) RET

works

but

M-: (require 'pakistan) RET

doesn't.

Neither do any of,

M-: (require 'ipa) RET
M-: (require 'uni-input) RET

If fact there are 10 files in lisp/leim/quail with provide forms.

Out of these requiring one philippine, indonesian, indian, misc-lang and
emoji succeeds.

While requiring one of uni-input, rfc1345, compose, pakistan or hangul
leads to an error.

I don't know why this is the case.

> Best regards, Michael.

Rahguzar

Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

[Rahguzar]

Actually I see what is happening now. `cus-test-deps` is checking if it
can load the files defining the custom variables. None of the files in
lisp/leim/quail are on the load path. The cases where require succeeds
it is because some other file with the same file-name-non-directory is
on the load path e.g. for indian.el it is,

lisp/language/indian.el

which does not define any custom variable.

I think the problem is with the test.

P.S. Both lisp/leim/quail/indian.el and lisp/language/indian.el provide
the feature indian which doesn't seem like the right thing.

Rahguzar <rahguzar@zohomail.eu> writes:

> Hi Michael,
>
> Michael Albinus <michael.albinus@gmx.de> writes:
>
>> Rahguzar <rahguzar@zohomail.eu> writes:
>>
>>> Hi Michael,
>>
>> Hi Rahguzar,
>>
>>> So I wonder if the test is encouraging the correct behavior. I think
>>> that seeing the `pakistan-urdu-input` subgroup would be useful for
>>> people using `urdu-custom` input method but perhaps for majority of
>>> people we shouldn't cause pakistan.el to load just because they wanted
>>> to customize a quail option.
>>>
>>> Maybe it is better to just remove `quail` as the parent group of
>>> `pakistan-urdu-input`?
>>
>> No idea. Note, that there is also lisp/leim/quail/indian.el. It declares
>> defgroup `tamil-input', and it doesn't show an error in the test.
>>
>> I've tried to replace the parent group of `pakistan-urdu-input' to be
>> `leim' instead of `quail'. But the error about the missing pakistan.el
>> persists, just using `leim' instead of `quail' in the error message.
>
> Poking around `cus-test.el` a little I think this is a load path problem
> and unrelated to the defgroup form.
>
> I can run
>
> src/emacs -batch --eval="(require 'indian)"
>
> in a shell and it exists without any error.
>
> But
>
> src/emacs -batch --eval="(require 'pakistan)"
>
> results in
>
> Error: file-missing ("Cannot open load file" "No such file or directory" "pakistan")
>   mapbacktrace(#f(compiled-function (evald func args flags) #<bytecode -0x188ce6540514dc1>))
>   debug-early-backtrace()
>   debug-early(error (file-missing "Cannot open load file" "No such file or directory" "pakistan"))
>   require(pakistan)
>   eval((require 'pakistan) t)
>   command-line-1(("--eval=(require 'pakistan)"))
>   command-line()
>   normal-top-level()
> Cannot open load file: No such file or directory, pakistan
>
> Similarly starting with
>
> src/emacs -Q
>
> M-: (require 'indian) RET
>
> works
>
> but
>
> M-: (require 'pakistan) RET
>
> doesn't.
>
> Neither do any of,
>
> M-: (require 'ipa) RET
> M-: (require 'uni-input) RET
>
> If fact there are 10 files in lisp/leim/quail with provide forms.
>
> Out of these requiring one philippine, indonesian, indian, misc-lang and
> emoji succeeds.
>
> While requiring one of uni-input, rfc1345, compose, pakistan or hangul
> leads to an error.
>
> I don't know why this is the case.
>
>> Best regards, Michael.
>
> Rahguzar

Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

[Michael Albinus]

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

Rahguzar <rahguzar@zohomail.eu> writes:

Hi Rahguzar,

> Actually I see what is happening now. `cus-test-deps` is checking if it
> can load the files defining the custom variables. None of the files in
> lisp/leim/quail are on the load path. The cases where require succeeds
> it is because some other file with the same file-name-non-directory is
> on the load path e.g. for indian.el it is,
>
> lisp/language/indian.el
>
> which does not define any custom variable.
>
> I think the problem is with the test.

Good catch! One possible solution is to add the quail/ subdirectory to
load-path, temporarily. Like this:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 600 bytes --]

diff --git a/admin/cus-test.el b/admin/cus-test.el
index b86643a769a..96f0c1ff0c4 100644
--- a/admin/cus-test.el
+++ b/admin/cus-test.el
@@ -424,7 +424,12 @@ cus-test-deps
   (mapatoms
    ;; This code is mainly from `custom-load-symbol'.
    (lambda (symbol)
-     (let ((custom-load-recursion t))
+     (let ((custom-load-recursion t)
+           (load-path
+            (cons
+             (expand-file-name
+              "quail" (file-name-directory (locate-library leim-list-file-name)))
+             load-path)))
        (dolist (load (get symbol 'custom-loads))
 	 (cond
 	  ((symbolp load)

[-- Attachment #3: Type: text/plain, Size: 526 bytes --]


Likely there are also other solutions, don't know what's the best. Eli?

> P.S. Both lisp/leim/quail/indian.el and lisp/language/indian.el provide
> the feature indian which doesn't seem like the right thing.

Yes, that's unfortune.

Another minor annoyance is, that `tamil-input' of
lisp/leim/quail/indian.el and `pakistan-urdu-input' of
lisp/leim/quail/pakistan.el have different parent groups, `leim' and
`quail'. Shouldn't this be `quail' in both cases?

> Rahguzar <rahguzar@zohomail.eu> writes:

Best regards, Michael.

Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

[Visuwesh]

[ஞாயிறு ஜனவரி 21, 2024] Michael Albinus wrote:

> [...]
> Another minor annoyance is, that `tamil-input' of
> lisp/leim/quail/indian.el and `pakistan-urdu-input' of
> lisp/leim/quail/pakistan.el have different parent groups, `leim' and
> `quail'. Shouldn't this be `quail' in both cases?

When I picked the parent group for tamil-input, leim seemed to be the
best choice since it called itself "Library of Emacs Input Methods".
But if you think quail is a better choice, please change it.

Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

[Michael Albinus]

Visuwesh <visuweshm@gmail.com> writes:

Hi Visuwesh,

>> Another minor annoyance is, that `tamil-input' of
>> lisp/leim/quail/indian.el and `pakistan-urdu-input' of
>> lisp/leim/quail/pakistan.el have different parent groups, `leim' and
>> `quail'. Shouldn't this be `quail' in both cases?
>
> When I picked the parent group for tamil-input, leim seemed to be the
> best choice since it called itself "Library of Emacs Input Methods".
> But if you think quail is a better choice, please change it.

Thanks for the feedback, I've changed this in the master branch.

Best regards, Michael.

Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

[Eli Zaretskii]

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
> Date: Sun, 21 Jan 2024 19:16:31 +0100
> 
> Good catch! One possible solution is to add the quail/ subdirectory to
> load-path, temporarily. Like this:
> 
> diff --git a/admin/cus-test.el b/admin/cus-test.el
> index b86643a769a..96f0c1ff0c4 100644
> --- a/admin/cus-test.el
> +++ b/admin/cus-test.el
> @@ -424,7 +424,12 @@ cus-test-deps
>    (mapatoms
>     ;; This code is mainly from `custom-load-symbol'.
>     (lambda (symbol)
> -     (let ((custom-load-recursion t))
> +     (let ((custom-load-recursion t)
> +           (load-path
> +            (cons
> +             (expand-file-name
> +              "quail" (file-name-directory (locate-library leim-list-file-name)))
> +             load-path)))
>         (dolist (load (get symbol 'custom-loads))
>  	 (cond
>  	  ((symbolp load)
> 
> Likely there are also other solutions, don't know what's the best. Eli?

The above is fine by me, thanks.

Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

[Michael Albinus]

Eli Zaretskii <eliz@gnu.org> writes:

Hi Eli,

>> Likely there are also other solutions, don't know what's the best. Eli?
>
> The above is fine by me, thanks.

Pushed to master.

Best regards, Michael.