org-store-link modifies readonly-buffer

org-store-link modifies readonly-buffer

[Tennyson Bardwell]

[-- Attachment #1: Type: text/plain, Size: 825 bytes --]

Hi org-mode devs,

My apologies for the sparse & trivial bug report.

It seems as though =org-store-link= does not respect the "readonly" part of
read-only buffers. I noticed it myself[1], found a bug report on
stackexchange[2], and did not see the appropriate check in the code[3].

If this is unintended, I would be happy to try to submit a PR. I have not
yet contributed to any emacs ecosystem, so I would be slow & bad at this,
but happy to try.

🌸
Tennyson

[1]
Evil spacemacs, heavily customized

[2]
https://emacs.stackexchange.com/questions/79220/how-to-ignore-buffer-read-only-when-archiving-subtrees-in-org-mode

[3]
- https://github.com/bzg/org-mode/blob/main/lisp/ol.el#L1687-L1703
-
https://github.com/bzg/org-mode/blob/9183e3c723b812360d1042196416d521db590e9f/lisp/ol.el#L1687-L1703

[-- Attachment #2: Type: text/html, Size: 1427 bytes --]

Re: org-store-link modifies readonly-buffer

[Ihor Radchenko]

Tennyson Bardwell <tennysontaylorbardwell@gmail.com> writes:

> It seems as though =org-store-link= does not respect the "readonly" part of
> read-only buffers. I noticed it myself[1], found a bug report on
> stackexchange[2], and did not see the appropriate check in the code[3].
>
> If this is unintended, I would be happy to try to submit a PR. I have not
> yet contributed to any emacs ecosystem, so I would be slow & bad at this,
> but happy to try.

Confirmed.
This is intended, with the main purpose of not barfing with error when
users call `org-store-link' in read-only *Org goto* indirect buffers.

More generally, Org mode handling of read-only state is rather
inconsistent. We have a number of places that do ignore read-only and a
number of places that don't.

I do believe that the right things to do is respecting read-only state
with an exception to *Org goto* buffers (or maybe other buffers that we
should explicitly mark). But doing so might break user workflows.
We need to carefully study various instances where Org mode ignores
read-only state to decide what is the best course of action.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>