From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: master 4b79c80c999 1/2: New function 'sort-on' Date: Fri, 02 Feb 2024 16:30:03 +0100 Message-ID: <87plxe28as.fsf@web.de> References: <170688047526.14693.2994051491358257471@vcs2.savannah.gnu.org> <20240202132756.4272CC0EFE7@vcs2.savannah.gnu.org> <87cytej4hy.fsf@daniel-mendler.de> <86zfwi52m1.fsf@gnu.org> Reply-To: Michael Heerdegen Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11700"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:CFtdINNEDtnBDhE6dG3+B+ALRyU= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 02 16:30:08 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rVvUW-0002oh-6Q for ged-emacs-devel@m.gmane-mx.org; Fri, 02 Feb 2024 16:30:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVvUH-00035K-4m; Fri, 02 Feb 2024 10:29:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVvUF-00035C-Q2 for emacs-devel@gnu.org; Fri, 02 Feb 2024 10:29:51 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVvUE-0007ti-1P for emacs-devel@gnu.org; Fri, 02 Feb 2024 10:29:51 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rVvUA-0002QU-Il for emacs-devel@gnu.org; Fri, 02 Feb 2024 16:29:46 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315756 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: > This function can only sort lists, so at least from that aspect its > place is not in seq.el. In addition, I see no reason to have it > preloaded. > > I've put it in sort.el because the function 'sort' is there. Both places make no sense to me. sort.el doesn't define `sort' - it's completely and only about sorting _text_ entities. Reverse lines or columns etc. The new function doesn't fit there. Maybe subr.el or subr-x.el? Here are two more typos, @Eli please review and install if you agree. I guess there could be more, I only have had a quick look at the text: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-more-typos-in-sort-on-change.patch >From cd94b493a50d98623c5d354ca9dac854bfc6cf6a Mon Sep 17 00:00:00 2001 From: Michael Heerdegen Date: Fri, 2 Feb 2024 16:23:23 +0100 Subject: [PATCH] Fix more typos in 'sort-on' change --- doc/lispref/sequences.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/lispref/sequences.texi b/doc/lispref/sequences.texi index 896dac35c8e..28b9591a148 100644 --- a/doc/lispref/sequences.texi +++ b/doc/lispref/sequences.texi @@ -462,8 +462,8 @@ Sequence Functions This function implements what is known as @dfn{decorate-sort-undecorate} paradigm, of the Schwartzian transform. It basically trades CPU for memory, creating a temporary list with the -computed sport keys, then mapping @code{car} over the result of -sorting that temporary list. Unlike with @code{sort}, the return list +computed sort keys, then mapping @code{car} over the result of +sorting that temporary list. Unlike with @code{sort}, the returned list is a copy; the original list is left intact. @end defun -- 2.39.2 --=-=-= Content-Type: text/plain Thx, Michael. --=-=-=--