From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#69646: [PATCH] Have insert 'submit-emacs-patch' maintainers into X-Debbugs-Cc Date: Fri, 08 Mar 2024 17:50:46 +0000 Message-ID: <87plw4d349.fsf@posteo.net> References: <87frx0eneh.fsf@posteo.net> <871q8kel1w.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4161"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69646@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 08 18:51:49 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rieNo-0000sp-M5 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Mar 2024 18:51:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rieNY-0002zz-7z; Fri, 08 Mar 2024 12:51:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rieNX-0002zq-13 for bug-gnu-emacs@gnu.org; Fri, 08 Mar 2024 12:51:31 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rieNW-0002XI-Oo for bug-gnu-emacs@gnu.org; Fri, 08 Mar 2024 12:51:30 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rieO2-0007EB-FH for bug-gnu-emacs@gnu.org; Fri, 08 Mar 2024 12:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Mar 2024 17:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69646 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69646-submit@debbugs.gnu.org id=B69646.170992029127732 (code B ref 69646); Fri, 08 Mar 2024 17:52:02 +0000 Original-Received: (at 69646) by debbugs.gnu.org; 8 Mar 2024 17:51:31 +0000 Original-Received: from localhost ([127.0.0.1]:59504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rieNW-0007DE-Ff for submit@debbugs.gnu.org; Fri, 08 Mar 2024 12:51:30 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:35419) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rieNR-0007Cw-El for 69646@debbugs.gnu.org; Fri, 08 Mar 2024 12:51:29 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 66B2E240027 for <69646@debbugs.gnu.org>; Fri, 8 Mar 2024 18:50:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1709920247; bh=6rOYv2i7n5wdeSqLPYaKDnVB/yiyIHPnGPvcN6maMB8=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=Z0NeAOM9Zp1bD0By7CvrUq2zfkq3O4VUXgcZPmn86pk+YCvSHxbvMnmagU/hCOZJc 3eiM9TGl9x6JIAS7MfTcbu3I3zXdZYyEGekvyO6pZ12TWKBVAhF2Pm5fWfcRsdxr1n vg9kjiN29k5mUFoHaQZn0TA3VNfionymo5bId+CummiaJ8qRggYhPpTIdtBIqtchZ3 OB5lR0dOnwasU4A88X+eo2jDe5V40dk3RmRWFkKqBwB1zCVsSFApA862KvkEW+y5iQ d8D4okjuiWif6XYoFYog6/jKZsYGUqEmWFSsgxSXhMBqNxrTIF/6VanEG38tL8Zk6J fOQey0YlLk6IA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Trtxf6KZKz6ty8; Fri, 8 Mar 2024 18:50:46 +0100 (CET) In-Reply-To: (Andrea Corallo's message of "Fri, 08 Mar 2024 12:41:27 -0500") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281257 Archived-At: Andrea Corallo writes: > Philip Kaludercic writes: > >> Andrea Corallo writes: >> >>> Philip Kaludercic writes: >>> >>>> Tags: patch >>>> >>>> >>>> Here's a suggestion, to have the submit-emacs-patch command >>>> automatically ping maintainers, in case they are not following the bug >>>> tracker. Basically it goes through all the files and extracts the >>>> information from the Maintainer: header. >>>> >>>> One non-technical issue here is that the maintainer information might >>>> not be up to date. I've run a quick scan to see who is mentioned how >>>> frequently. It might be necessary to clean up this list or to check who >>>> is still around: >>> >>> Hi Philip, >>> >>> IIUC with this patch I'd be in Cc of all bugs? If that's the case I'm >>> not personally in favor of this, I score mails on bug-gnu-emacs also >>> based on me being in Cc or not. >> >> Why should that be? I have tested the new command out with bug#69647, >> and you weren't added automatically. In fact, a quick grep tells me you >> aren't listed as the maintainer in any file, so you wouldn't be affected >> by this. > > Maybe your patch should parse also admin/MAINTAINERS and collect names > from there as well? Imaginable, but that is much more difficult to parse. If we want to do this, when some more general function should be written to extract this information. >>> I think the bug is that maintainers should be subscribed to >>> bug-gnu-emacs (otherwise I'm not sure how they can actually maintain). >> >> The issue is that for someone like me, who maintains a few little things >> around Emacs, following all bugs and all discussions would be too much. >> >>> Isn't a long list of people in Cc technically just another mailing list? >> >> It shouldn't be a long list, just the people responsible for the >> specific files being modified. My idea is to have something comparable >> to Linux's "get_maintainer.pl"[0], and a bit more streamlined (assuming >> people even use M-x submit-emacs-patch). > > If we want to Cc maintainers who are impacted by a patch I'm in favor, > if we want to Cc all maintainers then I'm not. I haven't read your > patch but from the initial description I thought was the first case, > I've now the impression is the second. Apologies if there was some > miss-understanding on my side. No, definitely the second case. The data-flow is .patch file -> list of modified files -> list of maintainers of these files and only those are added to X-Debbugs-CC. > Thanks > > Andrea -- Philip Kaludercic on peregrine